automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw88010 [PATCH 2/7] net/qede/base: changes for HSI to support new HW
       [not found] <20210219101422.19121-3-rmody@marvell.com>
@ 2021-02-19 10:17 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-02-19 10:17 UTC (permalink / raw)
  To: test-report; +Cc: Rasesh Mody

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88010

_coding style issues_


WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#63: 
Subject: [dpdk-dev] [PATCH 2/7] net/qede/base: changes for HSI to support

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#150: FILE: drivers/net/qede/base/common_hsi.h:13:
+/* Temporarily here should be added to HSI automatically by resource allocation tool. */

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1492: FILE: drivers/net/qede/base/common_hsi.h:1264:
+#define E4_RDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_MASK  0xF

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1493: FILE: drivers/net/qede/base/common_hsi.h:1265:
+#define E4_RDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_SHIFT 4

WARNING:TYPO_SPELLING: 'refernce' may be misspelled - perhaps 'reference'?
#1498: FILE: drivers/net/qede/base/common_hsi.h:1270:
+/* mask for refernce tag handling */

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1520: FILE: drivers/net/qede/base/common_hsi.h:1291:
+#define E4_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_B_MASK  0xF

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1521: FILE: drivers/net/qede/base/common_hsi.h:1292:
+#define E4_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_B_SHIFT 4

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1571: FILE: drivers/net/qede/base/common_hsi.h:1342:
+#define E4_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_A_MASK  0xF

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1572: FILE: drivers/net/qede/base/common_hsi.h:1343:
+#define E4_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_A_SHIFT 18

WARNING:TYPO_SPELLING: 'refernce' may be misspelled - perhaps 'reference'?
#1577: FILE: drivers/net/qede/base/common_hsi.h:1348:
+/* mask for refernce tag handling */

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1657: FILE: drivers/net/qede/base/common_hsi.h:1428:
+#define E5_RDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_MASK  0xF

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1658: FILE: drivers/net/qede/base/common_hsi.h:1429:
+#define E5_RDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_SHIFT 4

WARNING:TYPO_SPELLING: 'refernce' may be misspelled - perhaps 'reference'?
#1663: FILE: drivers/net/qede/base/common_hsi.h:1434:
+/* mask for refernce tag handling; used only in reg_e4_backward_compatible_mod */

WARNING:TYPO_SPELLING: 'refernce' may be misspelled - perhaps 'reference'?
#1668: FILE: drivers/net/qede/base/common_hsi.h:1439:
+/* mask for refernce tag handling; used only in 0=reg_e4_backward_compatible_mod **/

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1687: FILE: drivers/net/qede/base/common_hsi.h:1458:
+#define E5_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_B_MASK  0xF

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1688: FILE: drivers/net/qede/base/common_hsi.h:1459:
+#define E5_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_B_SHIFT 4

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1736: FILE: drivers/net/qede/base/common_hsi.h:1507:
+#define E5_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_A_MASK  0xF

WARNING:TYPO_SPELLING: 'TRANSMITED' may be misspelled - perhaps 'TRANSMITTED'?
#1737: FILE: drivers/net/qede/base/common_hsi.h:1508:
+#define E5_TDIF_TASK_CONTEXT_TRANSMITED_DIF_BYTES_LEFT_A_SHIFT 18

WARNING:TYPO_SPELLING: 'refernce' may be misspelled - perhaps 'reference'?
#1742: FILE: drivers/net/qede/base/common_hsi.h:1513:
+/* mask for refernce tag handlingl used only in tdif_reg_e4_backward_compatible_mode */

WARNING:TYPO_SPELLING: 'applyed' may be misspelled - perhaps 'applied'?
#1899: FILE: drivers/net/qede/base/common_hsi.h:1670:
+/* The operation will be applyed to the bit only if this bit is set. */

WARNING:TYPO_SPELLING: 'applyed' may be misspelled - perhaps 'applied'?
#1902: FILE: drivers/net/qede/base/common_hsi.h:1673:
+/* The operation will be applyed to the bit only if this bit is set. */

WARNING:TYPO_SPELLING: 'fiel' may be misspelled - perhaps 'feel'?
#2032: FILE: drivers/net/qede/base/common_hsi.h:1794:
+/* corresponds to the same 8021q tag that is selected for 8021q-tag fiel. This flag should be set if

WARNING:TYPO_SPELLING: 'wasnt' may be misspelled - perhaps 'wasn't'?
#2137: FILE: drivers/net/qede/base/common_hsi.h:1871:
+/* cksm calculated and value isn't 0xffff or L4-cksm-wasnt-calculated for any reason, like: udp/ipv4

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#2617: FILE: drivers/net/qede/base/ecore.h:781:
+#define ECORE_IS_E4(dev)	(ECORE_IS_BB(dev) || ECORE_IS_AH(dev))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#2642: FILE: drivers/net/qede/base/ecore.h:1122:
+#define USTORM_QZONE_START(dev) \
+	(MSTORM_QZONE_START(dev) + \
+	 (MSTORM_QZONE_SIZE(dev) *  NUM_OF_L2_QUEUES(dev)))

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#3747: FILE: drivers/net/qede/base/ecore_hsi_common.h:546:
+	DONT_UPDATE_DCB_DSCP /* Set when no change should be done to DCB data */,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4947: FILE: drivers/net/qede/base/ecore_hsi_common.h:1813:
+ * TID HSI Structure

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#4949: FILE: drivers/net/qede/base/ecore_hsi_common.h:1815:
+struct hsi_tid {

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4951: FILE: drivers/net/qede/base/ecore_hsi_common.h:1817:
+#define HSI_TID_ITID_MASK        0x3FFFF /* iTID. */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4952: FILE: drivers/net/qede/base/ecore_hsi_common.h:1818:
+#define HSI_TID_ITID_SHIFT       0

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4953: FILE: drivers/net/qede/base/ecore_hsi_common.h:1819:
+#define HSI_TID_SEGMENT_ID_MASK  0x3 /* Segment ID (Set by FW / HSI function). */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4953: FILE: drivers/net/qede/base/ecore_hsi_common.h:1819:
+#define HSI_TID_SEGMENT_ID_MASK  0x3 /* Segment ID (Set by FW / HSI function). */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4954: FILE: drivers/net/qede/base/ecore_hsi_common.h:1820:
+#define HSI_TID_SEGMENT_ID_SHIFT 18

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4955: FILE: drivers/net/qede/base/ecore_hsi_common.h:1821:
+#define HSI_TID_OPAQUE_FID_MASK  0xFFF /* Opaque FID. */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#4956: FILE: drivers/net/qede/base/ecore_hsi_common.h:1822:
+#define HSI_TID_OPAQUE_FID_SHIFT 20

WARNING:TYPO_SPELLING: 'cant' may be misspelled - perhaps 'can't'?
#5023: FILE: drivers/net/qede/base/ecore_hsi_common.h:1870:
+	ETH_VLAN_INSERT_AND_INBAND_VLAN /* Vlan cant be added to inband tag */,

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5226: FILE: drivers/net/qede/base/ecore_hsi_common.h:2024:
+	u8 dont_log_ramrods /* If set, FW will not log ramrods */;

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#5245: FILE: drivers/net/qede/base/ecore_hsi_common.h:2034:
+	struct hsi_fp_ver_struct hsi_fp_ver /* FP HSI version to be used by FW */;

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#5245: FILE: drivers/net/qede/base/ecore_hsi_common.h:2034:
+	struct hsi_fp_ver_struct hsi_fp_ver /* FP HSI version to be used by FW */;

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#5245: FILE: drivers/net/qede/base/ecore_hsi_common.h:2034:
+	struct hsi_fp_ver_struct hsi_fp_ver /* FP HSI version to be used by FW */;

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#5257: FILE: drivers/net/qede/base/ecore_hsi_common.h:2049:
+/* When DCB is enabled - if this flag is set, dont add VLAN 0 tag to untagged frames **/

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#5588: FILE: drivers/net/qede/base/ecore_hsi_common.h:2346:
+	struct hsi_fp_ver_struct hsi_fp_ver /* FP HSI version to be used by FW */;

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#5588: FILE: drivers/net/qede/base/ecore_hsi_common.h:2346:
+	struct hsi_fp_ver_struct hsi_fp_ver /* FP HSI version to be used by FW */;

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#5588: FILE: drivers/net/qede/base/ecore_hsi_common.h:2346:
+	struct hsi_fp_ver_struct hsi_fp_ver /* FP HSI version to be used by FW */;

WARNING:TYPO_SPELLING: 'thats' may be misspelled - perhaps 'that's'?
#6027: FILE: drivers/net/qede/base/ecore_hsi_common.h:2819:
+	__le32 size /* Size of the fw_info structure (thats located at the grc_addr). */;

WARNING:TYPO_SPELLING: 'theres' may be misspelled - perhaps 'there's'?
#6757: FILE: drivers/net/qede/base/ecore_hsi_debug_tools.h:600:
+/* idle check failure should cause an error only if theres no traffic **/

WARNING:TYPO_SPELLING: 'coallecing' may be misspelled - perhaps 'coalescing'?
#8441: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1016:
+	u8 tx_q0_int_coallecing_timeset /* byte2 */;

WARNING:TYPO_SPELLING: 'coallecing' may be misspelled - perhaps 'coalescing'?
#8530: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1105:
+	__le32 tx_int_coallecing_timeset /* reg3 */;

WARNING:TYPO_SPELLING: 'ENRTY' may be misspelled - perhaps 'ENTRY'?
#8786: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1342:
+	ETH_FILTERS_GFS_ADD_FILTER_FAIL_NO_FREE_ENRTY,

WARNING:TYPO_SPELLING: 'ENRTY' may be misspelled - perhaps 'ENTRY'?
#8795: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1351:
+	ETH_FILTERS_GFS_DEL_FILTER_FAIL_NO_MATCH_ENRTY,

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#8843: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1426:
+/* 0 - dont assert in case of filter configuration error. Just return an error code. 1 - assert in

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#8892: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1483:
+	struct hsi_tid tid;

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#9310: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1915:
+/* Note: the Segment ID is set/overridden by internal HSI Function / FW */

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#9311: FILE: drivers/net/qede/base/ecore_hsi_eth.h:1916:
+	struct hsi_tid tid;

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#9526: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2131:
+/* 0 - dont assert in case of filter configuration error, return an error code. 1 - assert in case

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#9614: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2219:
+	u8 dont_frag_flag /* dont frag flag value. */;

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#9614: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2219:
+	u8 dont_frag_flag /* dont frag flag value. */;

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#9737: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2342:
+/* 0 - dont assert in case of filter configuration error, return an error code. 1 - assert in case

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#9814: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2388:
+ * each consecutive CID. HSI Documentation defines that per-PF, the 1st Hairpin (Tx/Rx) Queue Start

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#9818: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2392:
+/* Appropriate PF s numPfHairpinQueues is increased per either Hairpin Tx/Rx Queue start. HSI

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#9822: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2396:
+/* Default Vport for redirection. vport_id Field in First Tx/Rx Queue Start Ramrod. HSI

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#10142: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2606:
+/* 0 - dont assert in case of error. Just return an error code. 1 - assert in case of error. */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#10247: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2691:
+ * tx queue by setting value to ETH_TX_INACTIVE_SAME_AS_LAST (HSI constant). For E5: Switch off SAL

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#10248: FILE: drivers/net/qede/base/ecore_hsi_eth.h:2692:
+ * for this tx queue by setting value to ETH_TX_INACTIVE_SAME_AS_LAST (HSI constant), otherwise

WARNING:TYPO_SPELLING: 'Descriptot' may be misspelled - perhaps 'Descriptor'?
#12389: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:22:
+ * GFS context Descriptot QREG (0)

WARNING:TYPO_SPELLING: 'indexs' may be misspelled - perhaps 'indexes'?
#12526: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:159:
+	u16 dst_ip_index /* Inner IPv6 destination IP indirection indexs. */;

WARNING:TYPO_SPELLING: 'indexs' may be misspelled - perhaps 'indexes'?
#12527: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:160:
+	u16 src_ip_index /* Inner IPv6 source IP indirection indexs. */;

WARNING:TYPO_SPELLING: 'indexs' may be misspelled - perhaps 'indexes'?
#12532: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:165:
+	struct gfs_modify_inner_ipv6_addr ipv6 /* Inner IPv6 indirection indexs. */;

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#12564: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:197:
+#define GFS_PUSH_TUNNEL_IPV4_HEADER_FLAGS_DONT_FRAG_FLAG_MASK             0x1

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#12565: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:198:
+#define GFS_PUSH_TUNNEL_IPV4_HEADER_FLAGS_DONT_FRAG_FLAG_SHIFT            0

WARNING:TYPO_SPELLING: 'indexs' may be misspelled - perhaps 'indexes'?
#12713: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:346:
+/* HDR Modify   inner IPv4 destination IP or IPv6 indirection indexs. */

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#13143: FILE: drivers/net/qede/base/ecore_hsi_init_func.h:794:
+/* WFQ weight. A value of 0 means dont configure. ignored if VPORT WFQ is globally disabled. */

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#13441: FILE: drivers/net/qede/base/ecore_hsi_init_tool.h:245:
+#define INIT_IF_MODE_OP_CMD_OFFSET_MASK  0xFFFF /* Commands to skip if the modes dont match */

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#13464: FILE: drivers/net/qede/base/ecore_hsi_init_tool.h:261:
+#define INIT_IF_PHASE_OP_CMD_OFFSET_MASK  0xFFFF /* Commands to skip if the phases dont match */

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'map' - possible side-effects?
#13615: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:169:
+#define QM_INIT_TX_PQ_MAP(p_hwfn, map, chip, pq_id, vp_pq_id, rl_valid, rl_id, ext_voq, wrr) \
 	do { \
 		OSAL_MEMSET(&(map), 0, sizeof(map)); \
+		SET_FIELD((map).reg, QM_RF_PQ_MAP_##chip##_PQ_VALID, 1); \
+		SET_FIELD((map).reg, QM_RF_PQ_MAP_##chip##_RL_VALID, rl_valid ? 1 : 0); \
+		SET_FIELD((map).reg, QM_RF_PQ_MAP_##chip##_RL_ID, rl_id); \
+		SET_FIELD((map).reg, QM_RF_PQ_MAP_##chip##_VP_PQ_ID, vp_pq_id); \
+		SET_FIELD((map).reg, QM_RF_PQ_MAP_##chip##_VOQ, ext_voq); \
+		SET_FIELD((map).reg, QM_RF_PQ_MAP_##chip##_WRR_WEIGHT_GROUP, wrr); \
+		STORE_RT_REG(p_hwfn, QM_REG_TXPQMAP_RT_OFFSET + (pq_id), *((u32 *)&(map))); \
 	} while (0)

total: 0 errors, 72 warnings, 3 checks, 13832 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-19 10:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210219101422.19121-3-rmody@marvell.com>
2021-02-19 10:17 ` [dpdk-test-report] |WARNING| pw88010 [PATCH 2/7] net/qede/base: changes for HSI to support new HW checkpatch

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git