* [dpdk-test-report] |WARNING| pw94274-94287 [PATCH] [v1, 14/14] common/mlx5: clean up legacy PCI bus driver
@ 2021-06-16 4:43 dpdklab
0 siblings, 0 replies; only message in thread
From: dpdklab @ 2021-06-16 4:43 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 20365 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/94274
_apply patch failure_
Submitter: Xueming Li <xuemingl@nvidia.com>
Date: Wednesday, June 16 2021 04:09:35
Applied on: CommitID:2ca92f54410400af76a1f0bc3bfecc8077e282aa
Apply patch set 94274-94287 failed:
Checking patch drivers/net/mlx5/linux/mlx5_os.c...
Hunk #1 succeeded at 1977 (offset 8 lines).
Hunk #2 succeeded at 2409 (offset 8 lines).
Hunk #3 succeeded at 2459 (offset 8 lines).
Checking patch drivers/net/mlx5/linux/mlx5_os.h...
Checking patch drivers/net/mlx5/mlx5.c...
Checking patch drivers/net/mlx5/mlx5.h...
Checking patch drivers/net/mlx5/mlx5_mr.c...
Hunk #2 succeeded at 312 (offset 5 lines).
Hunk #3 succeeded at 327 (offset 5 lines).
Hunk #4 succeeded at 361 (offset 5 lines).
Hunk #5 succeeded at 376 (offset 5 lines).
Hunk #6 succeeded at 385 (offset 5 lines).
error: while searching for:
mr = mlx5_mr_lookup_list(&sh->share_cache, &entry, (uintptr_t)addr);
if (!mr) {
rte_rwlock_read_unlock(&sh->share_cache.rwlock);
DRV_LOG(WARNING, "address 0x%" PRIxPTR " wasn't registered "
"to PCI device %p", (uintptr_t)addr,
(void *)pdev);
rte_errno = EINVAL;
return -1;
}
LIST_REMOVE(mr, mr);
mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb);
DRV_LOG(DEBUG, "port %u remove MR(%p) from list", dev->data->port_id,
(void *)mr);
mlx5_mr_rebuild_cache(&sh->share_cache);
/*
* No explicit wmb is needed after updating dev_gen due to
error: patch failed: drivers/net/mlx5/mlx5_mr.c:394
Checking patch drivers/net/mlx5/mlx5_rxtx.h...
Applied patch drivers/net/mlx5/linux/mlx5_os.c cleanly.
Applied patch drivers/net/mlx5/linux/mlx5_os.h cleanly.
Applied patch drivers/net/mlx5/mlx5.c cleanly.
Applied patch drivers/net/mlx5/mlx5.h cleanly.
Applying patch drivers/net/mlx5/mlx5_mr.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Rejected hunk #7.
Applied patch drivers/net/mlx5/mlx5_rxtx.h cleanly.
diff a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c (rejected hunks)
@@ -394,16 +393,15 @@ mlx5_dma_unmap(struct rte_pci_device *pdev, void *addr,
mr = mlx5_mr_lookup_list(&sh->share_cache, &entry, (uintptr_t)addr);
if (!mr) {
rte_rwlock_read_unlock(&sh->share_cache.rwlock);
- DRV_LOG(WARNING, "address 0x%" PRIxPTR " wasn't registered "
- "to PCI device %p", (uintptr_t)addr,
- (void *)pdev);
+ DRV_LOG(WARNING, "address 0x%" PRIxPTR " wasn't registered to device %s",
+ (uintptr_t)addr, rte_dev->name);
rte_errno = EINVAL;
return -1;
}
LIST_REMOVE(mr, mr);
- mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb);
DRV_LOG(DEBUG, "port %u remove MR(%p) from list", dev->data->port_id,
(void *)mr);
+ mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb);
mlx5_mr_rebuild_cache(&sh->share_cache);
/*
* No explicit wmb is needed after updating dev_gen due to
Skipped patch 'doc/guides/nics/mlx5.rst'.
Checking patch drivers/net/mlx5/linux/mlx5_ethdev_os.c...
Checking patch drivers/net/mlx5/linux/mlx5_os.c...
error: drivers/net/mlx5/linux/mlx5_os.c: does not match index
Checking patch drivers/net/mlx5/linux/mlx5_os.h...
error: drivers/net/mlx5/linux/mlx5_os.h: does not match index
Checking patch drivers/net/mlx5/mlx5.c...
error: drivers/net/mlx5/mlx5.c: does not match index
Checking patch drivers/net/mlx5/mlx5.h...
error: drivers/net/mlx5/mlx5.h: does not match index
Checking patch drivers/net/mlx5/mlx5_mac.c...
Checking patch drivers/net/mlx5/mlx5_rxmode.c...
Checking patch drivers/net/mlx5/mlx5_trigger.c...
Checking patch drivers/net/mlx5/windows/mlx5_os.c...
Applied patch drivers/net/mlx5/linux/mlx5_ethdev_os.c cleanly.
Applied patch drivers/net/mlx5/mlx5_mac.c cleanly.
Applied patch drivers/net/mlx5/mlx5_rxmode.c cleanly.
Applied patch drivers/net/mlx5/mlx5_trigger.c cleanly.
Applied patch drivers/net/mlx5/windows/mlx5_os.c cleanly.
Checking patch drivers/net/mlx5/linux/mlx5_os.c...
error: drivers/net/mlx5/linux/mlx5_os.c: does not match index
Checking patch drivers/common/mlx5/linux/mlx5_common_os.h...
Checking patch drivers/common/mlx5/mlx5_common.c...
Checking patch drivers/common/mlx5/mlx5_common.h...
Checking patch drivers/common/mlx5/mlx5_common_pci.c...
error: while searching for:
#include <rte_devargs.h>
#include <rte_errno.h>
#include <rte_class.h>
#include "mlx5_common_log.h"
#include "mlx5_common_pci.h"
#include "mlx5_common_private.h"
static struct rte_pci_driver mlx5_common_pci_driver;
/********** Legacy PCI bus driver, to be removed ********/
struct mlx5_pci_device {
struct rte_pci_device *pci_dev;
TAILQ_ENTRY(mlx5_pci_device) next;
uint32_t classes_loaded;
};
/* Head of list of drivers. */
static TAILQ_HEAD(mlx5_pci_bus_drv_head, mlx5_pci_driver) drv_list =
TAILQ_HEAD_INITIALIZER(drv_list);
/* Head of mlx5 pci devices. */
static TAILQ_HEAD(mlx5_pci_devices_head, mlx5_pci_device) devices_list =
TAILQ_HEAD_INITIALIZER(devices_list);
static const struct {
const char *name;
unsigned int driver_class;
} mlx5_classes[] = {
{ .name = "vdpa", .driver_class = MLX5_CLASS_VDPA },
{ .name = "net", .driver_class = MLX5_CLASS_NET },
{ .name = "regex", .driver_class = MLX5_CLASS_REGEX },
{ .name = "compress", .driver_class = MLX5_CLASS_COMPRESS },
};
static const unsigned int mlx5_class_combinations[] = {
MLX5_CLASS_NET,
MLX5_CLASS_VDPA,
MLX5_CLASS_REGEX,
MLX5_CLASS_COMPRESS,
MLX5_CLASS_NET | MLX5_CLASS_REGEX,
MLX5_CLASS_VDPA | MLX5_CLASS_REGEX,
MLX5_CLASS_NET | MLX5_CLASS_COMPRESS,
MLX5_CLASS_VDPA | MLX5_CLASS_COMPRESS,
MLX5_CLASS_REGEX | MLX5_CLASS_COMPRESS,
MLX5_CLASS_NET | MLX5_CLASS_REGEX | MLX5_CLASS_COMPRESS,
MLX5_CLASS_VDPA | MLX5_CLASS_REGEX | MLX5_CLASS_COMPRESS,
/* New class combination should be added here. */
};
static int
class_name_to_value(const char *class_name)
{
unsigned int i;
for (i = 0; i < RTE_DIM(mlx5_classes); i++) {
if (strcmp(class_name, mlx5_classes[i].name) == 0)
return mlx5_classes[i].driver_class;
}
return -EINVAL;
}
static struct mlx5_pci_driver *
driver_get(uint32_t class)
{
struct mlx5_pci_driver *driver;
TAILQ_FOREACH(driver, &drv_list, next) {
if (driver->driver_class == class)
return driver;
}
return NULL;
}
static int
bus_cmdline_options_handler(__rte_unused const char *key,
const char *class_names, void *opaque)
{
int *ret = opaque;
char *nstr_org;
int class_val;
char *found;
char *nstr;
char *refstr = NULL;
*ret = 0;
nstr = strdup(class_names);
if (!nstr) {
*ret = -ENOMEM;
return *ret;
}
nstr_org = nstr;
found = strtok_r(nstr, ":", &refstr);
if (!found)
goto err;
do {
/* Extract each individual class name. Multiple
* class key,value is supplied as class=net:vdpa:foo:bar.
*/
class_val = class_name_to_value(found);
/* Check if its a valid class. */
if (class_val < 0) {
*ret = -EINVAL;
goto err;
}
*ret |= class_val;
found = strtok_r(NULL, ":", &refstr);
} while (found);
err:
free(nstr_org);
if (*ret < 0)
DRV_LOG(ERR, "Invalid mlx5 class options %s."
" Maybe typo in device class argument setting?",
class_names);
return *ret;
}
static int
parse_class_options(const struct rte_devargs *devargs)
{
const char *key = RTE_DEVARGS_KEY_CLASS;
struct rte_kvargs *kvlist;
int ret = 0;
if (devargs == NULL)
return 0;
kvlist = rte_kvargs_parse(devargs->args, NULL);
if (kvlist == NULL)
return 0;
if (rte_kvargs_count(kvlist, key))
rte_kvargs_process(kvlist, key, bus_cmdline_options_handler,
&ret);
rte_kvargs_free(kvlist);
return ret;
}
static bool
mlx5_bus_match(const struct mlx5_pci_driver *drv,
const struct rte_pci_device *pci_dev)
{
const struct rte_pci_id *id_table;
for (id_table = drv->pci_driver.id_table; id_table->vendor_id != 0;
id_table++) {
/* Check if device's ids match the class driver's ids. */
if (id_table->vendor_id != pci_dev->id.vendor_id &&
id_table->vendor_id != RTE_PCI_ANY_ID)
continue;
if (id_table->device_id != pci_dev->id.device_id &&
id_table->device_id != RTE_PCI_ANY_ID)
continue;
if (id_table->subsystem_vendor_id !=
pci_dev->id.subsystem_vendor_id &&
id_table->subsystem_vendor_id != RTE_PCI_ANY_ID)
continue;
if (id_table->subsystem_device_id !=
pci_dev->id.subsystem_device_id &&
id_table->subsystem_device_id != RTE_PCI_
error: patch failed: drivers/common/mlx5/mlx5_common_pci.c:8
Hunk #2 succeeded at 509 (offset 414 lines).
Hunk #3 succeeded at 516 (offset 414 lines).
Checking patch drivers/common/mlx5/mlx5_common_pci.h...
Checking patch drivers/common/mlx5/mlx5_common_private.h...
Checking patch drivers/common/mlx5/version.map...
Applied patch drivers/common/mlx5/linux/mlx5_common_os.h cleanly.
Applied patch drivers/common/mlx5/mlx5_common.c cleanly.
Applied patch drivers/common/mlx5/mlx5_common.h cleanly.
Applying patch drivers/common/mlx5/mlx5_common_pci.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Applied patch drivers/common/mlx5/mlx5_common_pci.h cleanly.
Applied patch drivers/common/mlx5/mlx5_common_private.h cleanly.
Applied patch drivers/common/mlx5/version.map cleanly.
diff a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c (rejected hunks)
@@ -8,431 +8,17 @@
#include <rte_devargs.h>
#include <rte_errno.h>
#include <rte_class.h>
+#include <rte_pci.h>
+#include <rte_bus_pci.h>
#include "mlx5_common_log.h"
-#include "mlx5_common_pci.h"
#include "mlx5_common_private.h"
static struct rte_pci_driver mlx5_common_pci_driver;
-/********** Legacy PCI bus driver, to be removed ********/
-
-struct mlx5_pci_device {
- struct rte_pci_device *pci_dev;
- TAILQ_ENTRY(mlx5_pci_device) next;
- uint32_t classes_loaded;
-};
-
-/* Head of list of drivers. */
-static TAILQ_HEAD(mlx5_pci_bus_drv_head, mlx5_pci_driver) drv_list =
- TAILQ_HEAD_INITIALIZER(drv_list);
-
-/* Head of mlx5 pci devices. */
-static TAILQ_HEAD(mlx5_pci_devices_head, mlx5_pci_device) devices_list =
- TAILQ_HEAD_INITIALIZER(devices_list);
-
-static const struct {
- const char *name;
- unsigned int driver_class;
-} mlx5_classes[] = {
- { .name = "vdpa", .driver_class = MLX5_CLASS_VDPA },
- { .name = "net", .driver_class = MLX5_CLASS_NET },
- { .name = "regex", .driver_class = MLX5_CLASS_REGEX },
- { .name = "compress", .driver_class = MLX5_CLASS_COMPRESS },
-};
-
-static const unsigned int mlx5_class_combinations[] = {
- MLX5_CLASS_NET,
- MLX5_CLASS_VDPA,
- MLX5_CLASS_REGEX,
- MLX5_CLASS_COMPRESS,
- MLX5_CLASS_NET | MLX5_CLASS_REGEX,
- MLX5_CLASS_VDPA | MLX5_CLASS_REGEX,
- MLX5_CLASS_NET | MLX5_CLASS_COMPRESS,
- MLX5_CLASS_VDPA | MLX5_CLASS_COMPRESS,
- MLX5_CLASS_REGEX | MLX5_CLASS_COMPRESS,
- MLX5_CLASS_NET | MLX5_CLASS_REGEX | MLX5_CLASS_COMPRESS,
- MLX5_CLASS_VDPA | MLX5_CLASS_REGEX | MLX5_CLASS_COMPRESS,
- /* New class combination should be added here. */
-};
-
-static int
-class_name_to_value(const char *class_name)
-{
- unsigned int i;
-
- for (i = 0; i < RTE_DIM(mlx5_classes); i++) {
- if (strcmp(class_name, mlx5_classes[i].name) == 0)
- return mlx5_classes[i].driver_class;
- }
- return -EINVAL;
-}
-
-static struct mlx5_pci_driver *
-driver_get(uint32_t class)
-{
- struct mlx5_pci_driver *driver;
-
- TAILQ_FOREACH(driver, &drv_list, next) {
- if (driver->driver_class == class)
- return driver;
- }
- return NULL;
-}
-
-static int
-bus_cmdline_options_handler(__rte_unused const char *key,
- const char *class_names, void *opaque)
-{
- int *ret = opaque;
- char *nstr_org;
- int class_val;
- char *found;
- char *nstr;
- char *refstr = NULL;
-
- *ret = 0;
- nstr = strdup(class_names);
- if (!nstr) {
- *ret = -ENOMEM;
- return *ret;
- }
- nstr_org = nstr;
- found = strtok_r(nstr, ":", &refstr);
- if (!found)
- goto err;
- do {
- /* Extract each individual class name. Multiple
- * class key,value is supplied as class=net:vdpa:foo:bar.
- */
- class_val = class_name_to_value(found);
- /* Check if its a valid class. */
- if (class_val < 0) {
- *ret = -EINVAL;
- goto err;
- }
- *ret |= class_val;
- found = strtok_r(NULL, ":", &refstr);
- } while (found);
-err:
- free(nstr_org);
- if (*ret < 0)
- DRV_LOG(ERR, "Invalid mlx5 class options %s."
- " Maybe typo in device class argument setting?",
- class_names);
- return *ret;
-}
-
-static int
-parse_class_options(const struct rte_devargs *devargs)
-{
- const char *key = RTE_DEVARGS_KEY_CLASS;
- struct rte_kvargs *kvlist;
- int ret = 0;
-
- if (devargs == NULL)
- return 0;
- kvlist = rte_kvargs_parse(devargs->args, NULL);
- if (kvlist == NULL)
- return 0;
- if (rte_kvargs_count(kvlist, key))
- rte_kvargs_process(kvlist, key, bus_cmdline_options_handler,
- &ret);
- rte_kvargs_free(kvlist);
- return ret;
-}
-
-static bool
-mlx5_bus_match(const struct mlx5_pci_driver *drv,
- const struct rte_pci_device *pci_dev)
-{
- const struct rte_pci_id *id_table;
-
- for (id_table = drv->pci_driver.id_table; id_table->vendor_id != 0;
- id_table++) {
- /* Check if device's ids match the class driver's ids. */
- if (id_table->vendor_id != pci_dev->id.vendor_id &&
- id_table->vendor_id != RTE_PCI_ANY_ID)
- continue;
- if (id_table->device_id != pci_dev->id.device_id &&
- id_table->device_id != RTE_PCI_ANY_ID)
- continue;
- if (id_table->subsystem_vendor_id !=
- pci_dev->id.subsystem_vendor_id &&
- id_table->subsystem_vendor_id != RTE_PCI_ANY_ID)
- continue;
- if (id_table->subsystem_device_id !=
- pci_dev->id.subsystem_device_id &&
- id_table->subsystem_device_id != RTE_PCI_ANY_ID)
- continue;
- if (id_table->class_id != pci_dev->id.class_id &&
- id_table->class_id != RTE_CLASS_ANY_ID)
- continue;
- return true;
- }
- return false;
-}
-
-static int
-is_valid_class_combination(uint32_t user_classes)
-{
- unsigned int i;
-
- /* Verify if user specified valid supported combination. */
- for (i = 0; i < RTE_DIM(mlx5_class_combinations); i++) {
- if (mlx5_class_combinations[i] == user_classes)
- return 0;
- }
- /* Not found any valid class combination. */
- return -EINVAL;
-}
-
-static struct mlx5_pci_device *
-pci_to_mlx5_device(const struct rte_pci_device *pci_dev)
-{
- struct mlx5_pci_device *dev;
-
- TAILQ_FOREACH(dev, &devices_list, next) {
- if (dev->pci_dev == pci_dev)
- return dev;
- }
- return NULL;
-}
-
-static bool
-device_class_enabled(const struct mlx5_pci_device *device, uint32_t class)
-{
- return (device->classes_loaded & class) ? true : false;
-}
-
-static void
-dev_release(struct mlx5_pci_device *dev)
-{
- TAILQ_REMOVE(&devices_list, dev, next);
- rte_free(dev);
-}
-
-static int
-drivers_remove(struct mlx5_pci_device *dev, uint32_t enabled_classes)
-{
- struct mlx5_pci_driver *driver;
- int local_ret = -ENODEV;
- unsigned int i = 0;
- int ret = 0;
-
- enabled_classes &= dev->classes_loaded;
- while (enabled_classes) {
- driver = driver_get(RTE_BIT64(i));
- if (driver) {
- local_ret = driver->pci_driver.remove(dev->pci_dev);
- if (!local_ret)
- dev->classes_loaded &= ~RTE_BIT64(i);
- else if (ret == 0)
- ret = local_ret;
- }
- enabled_classes &= ~RTE_BIT64(i);
- i++;
- }
- if (local_ret)
- ret = local_ret;
- return ret;
-}
-
-static int
-drivers_probe(struct mlx5_pci_device *dev, struct rte_pci_driver *pci_drv,
- struct rte_pci_device *pci_dev, uint32_t user_classes)
-{
- struct mlx5_pci_driver *driver;
- uint32_t enabled_classes = 0;
- bool already_loaded;
- int ret;
-
- TAILQ_FOREACH(driver, &drv_list, next) {
- if ((driver->driver_class & user_classes) == 0)
- continue;
- if (!mlx5_bus_match(driver, pci_dev))
- continue;
- already_loaded = dev->classes_loaded & driver->driver_class;
- if (already_loaded &&
- !(driver->pci_driver.drv_flags & RTE_PCI_DRV_PROBE_AGAIN)) {
- DRV_LOG(ERR, "Device %s is already probed",
- pci_dev->device.name);
- ret = -EEXIST;
- goto probe_err;
- }
- ret = driver->pci_driver.probe(pci_drv, pci_dev);
- if (ret < 0) {
- DRV_LOG(ERR, "Failed to load driver %s",
- driver->pci_driver.driver.name);
- goto probe_err;
- }
- enabled_classes |= driver->driver_class;
- }
- dev->classes_loaded |= enabled_classes;
- return 0;
-probe_err:
- /* Only unload drivers which are enabled which were enabled
- * in this probe instance.
- */
- drivers_remove(dev, enabled_classes);
- return ret;
-}
-
-/**
- * DPDK callback to register to probe multiple drivers for a PCI device.
- *
- * @param[in] pci_drv
- * PCI driver structure.
- * @param[in] dev
- * PCI device information.
- *
- * @return
- * 0 on success, a negative errno value otherwise and rte_errno is set.
- */
-static int
-mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
- struct rte_pci_device *pci_dev)
-{
- struct mlx5_pci_device *dev;
- uint32_t user_classes = 0;
- bool new_device = false;
- int ret;
-
- ret = parse_class_options(pci_dev->device.devargs);
- if (ret < 0)
- return ret;
- user_classes = ret;
- if (user_classes) {
- /* Validate combination here. */
- ret = is_valid_class_combination(user_classes);
- if (ret) {
- DRV_LOG(ERR, "Unsupported mlx5 classes supplied.");
- return ret;
- }
- } else {
- /* Default to net class. */
- user_classes = MLX5_CLASS_NET;
- }
- dev = pci_to_mlx5_device(pci_dev);
- if (!dev) {
- dev = rte_zmalloc("mlx5_pci_device", sizeof(*dev), 0);
- if (!dev)
- return -ENOMEM;
- dev->pci_dev = pci_dev;
- TAILQ_INSERT_HEAD(&devices_list, dev, next);
- new_device = true;
- }
- ret = drivers_probe(dev, pci_drv, pci_dev, user_classes);
- if (ret)
- goto class_err;
- return 0;
-class_err:
- if (new_device)
- dev_release(dev);
- return ret;
-}
-
-/**
- * DPDK callback to remove one or more drivers for a PCI device.
- *
- * This function removes all drivers probed for a given PCI device.
- *
- * @param[in] pci_dev
- * Pointer to the PCI device.
- *
- * @return
- * 0 on success, the function cannot fail.
- */
-static int
-mlx5_pci_remove(struct rte_pci_device *pci_dev)
-{
- struct mlx5_pci_device *dev;
- int ret;
-
- dev = pci_to_mlx5_device(pci_dev);
- if (!dev)
- return -ENODEV;
- /* Matching device found, cleanup and unload drivers. */
- ret = drivers_remove(dev, dev->classes_loaded);
- if (!ret)
- dev_release(dev);
- return ret;
-}
-
-static int
-mlx5_pci_dma_map(struct rte_pci_device *pci_dev, void *addr,
- uint64_t iova, size_t len)
-{
- struct mlx5_pci_driver *driver = NULL;
- struct mlx5_pci_driver *temp;
- struct mlx5_pci_device *dev;
- int ret = -EINVAL;
-
- dev = pci_to_mlx5_device(pci_dev);
- if (!dev)
- return -ENODEV;
- TAILQ_FOREACH(driver, &drv_list, next) {
- if (device_class_enabled(dev, driver->driver_class) &&
- driver->pci_driver.dma_map) {
- ret = driver->pci_driver.dma_map(pci_dev, addr,
- iova, len);
- if (ret)
- goto map_err;
- }
- }
- return ret;
-map_err:
- TAILQ_FOREACH(temp, &drv_list, next) {
- if (temp == driver)
- break;
- if (device_class_enabled(dev, temp->driver_class) &&
- temp->pci_driver.dma_map && temp->pci_driver.dma_unmap)
- temp->pci_driver.dma_unmap(pci_dev, addr, iova, len);
- }
- return ret;
-}
-
-static int
-mlx5_pci_dma_unmap(struct rte_pci_device *pci_dev, void *addr,
- uint64_t iova, size_t len)
-{
- struct mlx5_pci_driver *driver;
- struct mlx5_pci_device *dev;
- int local_ret = -EINVAL;
- int ret;
-
- dev = pci_to_mlx5_device(pci_dev);
- if (!dev)
- return -ENODEV;
- ret = 0;
- /* There is no unmap error recovery in current implementation. */
- TAILQ_FOREACH_REVERSE(driver, &drv_list, mlx5_pci_bus_drv_head, next) {
- if (device_class_enabled(dev, driver->driver_class) &&
- driver->pci_driver.dma_unmap) {
- local_ret = driver->pci_driver.dma_unmap(pci_dev, addr,
- iova, len);
- if (local_ret && (ret == 0))
- ret = local_ret;
- }
- }
- if (local_ret)
- ret = local_ret;
- return ret;
-}
-
/* PCI ID table is build dynamically based on registered mlx5 drivers. */
static struct rte_pci_id *mlx5_pci_id_table;
-static struct rte_pci_driver mlx5_pci_driver = {
- .driver = {
- .name = MLX5_PCI_DRIVER_NAME,
- },
- .probe = mlx5_pci_probe,
- .remove = mlx5_pci_remove,
- .dma_map = mlx5_pci_dma_map,
- .dma_unmap = mlx5_pci_dma_unmap,
-};
-
static int
pci_id_table_size_get(const struct rte_pci_id *id_table)
{
https://lab.dpdk.org/results/dashboard/patchsets/17402/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-16 4:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 4:43 [dpdk-test-report] |WARNING| pw94274-94287 [PATCH] [v1, 14/14] common/mlx5: clean up legacy PCI bus driver dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).