* [dpdk-test-report] |WARNING| pw97949 [PATCH] compress/mlx5: allow partial transformations support
@ 2021-09-03 16:37 dpdklab
0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2021-09-03 16:37 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 2313 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/97949
_apply patch failure_
Submitter: Raja Zidane <rzidane@nvidia.com>
Date: Friday, September 03 2021 14:22:48
Applied on: CommitID:60d792c7d01bfdc7db2bf32293ab77fbdd5cef48
Apply patch set 97949 failed:
Checking patch drivers/compress/mlx5/mlx5_compress.c...
Hunk #1 succeeded at 287 (offset -4 lines).
error: while searching for:
rte_errno = ENODEV;
return -rte_errno;
}
if (mlx5_devx_cmd_query_hca_attr(ctx, &att) != 0 ||
((att.mmo_compress_sq_en == 0 || att.mmo_decompress_sq_en == 0 ||
att.mmo_dma_sq_en == 0) && (att.mmo_compress_qp_en == 0 ||
att.mmo_decompress_qp_en == 0 || att.mmo_dma_qp_en == 0))) {
DRV_LOG(ERR, "Not enough capabilities to support compress "
"operations, maybe old FW/OFED version?");
claim_zero(mlx5_glue->close_device(ctx));
rte_errno = ENOTSUP;
return -ENOTSUP;
error: patch failed: drivers/compress/mlx5/mlx5_compress.c:816
Applying patch drivers/compress/mlx5/mlx5_compress.c with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
diff a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c (rejected hunks)
@@ -816,12 +845,16 @@ mlx5_compress_dev_probe(struct rte_device *dev)
rte_errno = ENODEV;
return -rte_errno;
}
- if (mlx5_devx_cmd_query_hca_attr(ctx, &att) != 0 ||
- ((att.mmo_compress_sq_en == 0 || att.mmo_decompress_sq_en == 0 ||
- att.mmo_dma_sq_en == 0) && (att.mmo_compress_qp_en == 0 ||
- att.mmo_decompress_qp_en == 0 || att.mmo_dma_qp_en == 0))) {
- DRV_LOG(ERR, "Not enough capabilities to support compress "
- "operations, maybe old FW/OFED version?");
+ if (mlx5_devx_cmd_query_hca_attr(ctx, &att) != 0) {
+ DRV_LOG(ERR, "Failed to query device capabilities");
+ claim_zero(mlx5_glue->close_device(ctx));
+ rte_errno = ENOTSUP;
+ return -ENOTSUP;
+ }
+ if(!att.mmo_decompress_qp_en && !att.mmo_decompress_sq_en
+ && !att.mmo_compress_qp_en && !att.mmo_compress_sq_en
+ && !att.mmo_dma_qp_en && !att.mmo_dma_sq_en) {
+ DRV_LOG(ERR, "Not enough capabilities to support compress operations, maybe old FW/OFED version?");
claim_zero(mlx5_glue->close_device(ctx));
rte_errno = ENOTSUP;
return -ENOTSUP;
https://lab.dpdk.org/results/dashboard/patchsets/18543/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-test-report] |WARNING| pw97949 [PATCH] compress/mlx5: allow partial transformations support
[not found] <20210903142248.25710-1-rzidane@nvidia.com>
@ 2021-09-03 14:24 ` checkpatch
0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2021-09-03 14:24 UTC (permalink / raw)
To: test-report; +Cc: Raja Zidane
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97949
_coding style issues_
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#145: FILE: drivers/compress/mlx5/mlx5_compress.c:294:
+ switch(xform->type) {
+ case RTE_COMP_COMPRESS:
[...]
+ case RTE_COMP_DECOMPRESS:
[...]
+ default:
ERROR:SPACING: space required before the open parenthesis '('
#145: FILE: drivers/compress/mlx5/mlx5_compress.c:294:
+ switch(xform->type) {
ERROR:SPACING: space required before the open parenthesis '('
#147: FILE: drivers/compress/mlx5/mlx5_compress.c:296:
+ if(xform->compress.algo == RTE_COMP_ALGO_NULL &&
ERROR:SPACING: space required before the open parenthesis '('
#152: FILE: drivers/compress/mlx5/mlx5_compress.c:301:
+ else if(!priv->mmo_comp_qp && !priv->mmo_comp_sq) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#152: FILE: drivers/compress/mlx5/mlx5_compress.c:301:
+ }
+ else if(!priv->mmo_comp_qp && !priv->mmo_comp_sq) {
ERROR:SPACING: space required before the open parenthesis '('
#156: FILE: drivers/compress/mlx5/mlx5_compress.c:305:
+ if(xform->compress.level == RTE_COMP_LEVEL_NONE) {
ERROR:SPACING: space required before the open parenthesis '('
#160: FILE: drivers/compress/mlx5/mlx5_compress.c:309:
+ if(xform->compress.hash_algo != RTE_COMP_HASH_ALGO_NONE) {
ERROR:SPACING: space required before the open parenthesis '('
#166: FILE: drivers/compress/mlx5/mlx5_compress.c:315:
+ if(xform->decompress.algo == RTE_COMP_ALGO_NULL &&
ERROR:SPACING: space required before the open parenthesis '('
#171: FILE: drivers/compress/mlx5/mlx5_compress.c:320:
+ else if(!priv->mmo_decomp_qp && !priv->mmo_decomp_sq) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#171: FILE: drivers/compress/mlx5/mlx5_compress.c:320:
+ }
+ else if(!priv->mmo_decomp_qp && !priv->mmo_decomp_sq) {
ERROR:SPACING: space required before the open parenthesis '('
#175: FILE: drivers/compress/mlx5/mlx5_compress.c:324:
+ if(xform->compress.hash_algo != RTE_COMP_HASH_ALGO_NONE) {
ERROR:SPACING: space required before the open parenthesis '('
#204: FILE: drivers/compress/mlx5/mlx5_compress.c:854:
+ if(!att.mmo_decompress_qp_en && !att.mmo_decompress_sq_en
total: 12 errors, 0 warnings, 78 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-03 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 16:37 [dpdk-test-report] |WARNING| pw97949 [PATCH] compress/mlx5: allow partial transformations support dpdklab
[not found] <20210903142248.25710-1-rzidane@nvidia.com>
2021-09-03 14:24 ` checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).