From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <eagostini@nvidia.com>
Subject: [dpdk-test-report] |WARNING| pw103978 [PATCH v5 8/9] gpudev: add communication list
Date: Mon, 8 Nov 2021 11:49:10 +0100 (CET) [thread overview]
Message-ID: <20211108104910.1A5DE123056@dpdk.org> (raw)
In-Reply-To: <20211108185805.3887-9-eagostini@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/103978
_coding style issues_
WARNING:TYPO_SPELLING: 'erroneusly' may be misspelled - perhaps 'erroneously'?
#241: FILE: app/test-gpudev/main.c:271:
+ fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet
");
WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'?
#241: FILE: app/test-gpudev/main.c:271:
+ fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet
");
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#243: FILE: app/test-gpudev/main.c:273:
+ return -1;
+ } else {
WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'?
#244: FILE: app/test-gpudev/main.c:274:
+ fprintf(stderr, "rte_gpu_comm_cleanup_list correctly didn't clean up the packets because they have not beeing consumed yet
");
WARNING:TYPO_SPELLING: 'expecially' may be misspelled - perhaps 'especially'?
#300: FILE: doc/guides/prog_guide/gpudev.rst:94:
+Best practice, expecially in a multithreaded application,
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#360: FILE: lib/gpudev/gpudev.c:766:
+ ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_list) * num_comm_items, comm_list);
WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#367: FILE: lib/gpudev/gpudev.c:773:
+ comm_list[idx_l].pkt_list = rte_zmalloc(NULL, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, 0);
WARNING:LONG_LINE: line length of 136 exceeds 100 columns
#373: FILE: lib/gpudev/gpudev.c:779:
+ ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, comm_list[idx_l].pkt_list);
WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#383: FILE: lib/gpudev/gpudev.c:789:
+ comm_list[idx_l].mbufs = rte_zmalloc(NULL, sizeof(struct rte_mbuf *) * RTE_GPU_COMM_LIST_PKTS_MAX, 0);
total: 0 errors, 9 warnings, 472 lines checked
parent reply other threads:[~2021-11-08 10:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20211108185805.3887-9-eagostini@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108104910.1A5DE123056@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).