|WARNING| pw104414 [PATCH] [v3, 1/1] app/testpmd: add GPU memory option for mbuf pools

|WARNING| pw104414 [PATCH] [v3, 1/1] app/testpmd: add GPU memory option for mbuf pools

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 3852 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/104414

_apply patch failure_

Submitter: Elena Agostini <eagostini@nvidia.com>
Date: Wednesday, November 17 2021 03:04:59 
Applied on: CommitID:d4fb4eb08725a3e667042c1f5cd3ed72b94505a7
Apply patch set 104414 failed:

.git/rebase-apply/patch:172: trailing whitespace.
			TESTPMD_LOG(ERR, 
Checking patch app/test-pmd/cmdline.c...
error: while searching for:
			item_name, nb_item + 1, max_items);
		return 0;
	}
	parsed_items[nb_item++] = value;
	if (! check_unique_values)
		return nb_item;

	/*
	 * Then, check that all values in the list are different.
	 * No optimization here...
	 */
	for (i = 0; i < nb_item; i++) {

error: patch failed: app/test-pmd/cmdline.c:3648
Hunk #5 succeeded at 6882 (offset -3 lines).
Checking patch app/test-pmd/config.c...
error: while searching for:
}

/*
 * Displays the RSS hash functions of a port, and, optionally, the RSS hash
 * key of the port.
 */
void

error: patch failed: app/test-pmd/config.c:2965
error: while searching for:
{
	port->mc_addr_nb--;
	if (addr_idx == port->mc_addr_nb) {
		/* No need to recompact the set of multicast addresses. */
		if (port->mc_addr_nb == 0) {
			/* free the pool of multicast addresses. */
			free(port->mc_addr_pool);

error: patch failed: app/test-pmd/config.c:5250
Checking patch app/test-pmd/icmpecho.c...
error: while searching for:
	default:
		break;
	}
	return "Unknown ARP op";
}

static const char *

error: patch failed: app/test-pmd/icmpecho.c:54
Checking patch app/test-pmd/meson.build...
Checking patch app/test-pmd/parameters.c...
Hunk #3 succeeded at 1542 (offset -6 lines).
Checking patch app/test-pmd/testpmd.c...
Checking patch app/test-pmd/testpmd.h...
Applying patch app/test-pmd/cmdline.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Rejected hunk #4.
Hunk #5 applied cleanly.
Applying patch app/test-pmd/config.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
Applying patch app/test-pmd/icmpecho.c with 1 reject...
Rejected hunk #1.
Applied patch app/test-pmd/meson.build cleanly.
Applied patch app/test-pmd/parameters.c cleanly.
Applied patch app/test-pmd/testpmd.c cleanly.
Applied patch app/test-pmd/testpmd.h cleanly.
diff a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c	(rejected hunks)
@@ -3648,12 +3665,15 @@ parse_item_list(const char *str, const char *item_name, unsigned int max_items,
 			item_name, nb_item + 1, max_items);
 		return 0;
 	}
+
+	mbuf_mem_types[nb_item] = gpu_mbuf ? MBUF_MEM_GPU : MBUF_MEM_CPU;
+
 	parsed_items[nb_item++] = value;
 	if (! check_unique_values)
 		return nb_item;
 
 	/*
-	 * Then, check that all values in the list are different.
+	 * Then, check that all values in the list are differents.
 	 * No optimization here...
 	 */
 	for (i = 0; i < nb_item; i++) {
diff a/app/test-pmd/config.c b/app/test-pmd/config.c	(rejected hunks)
@@ -2965,7 +2965,7 @@ port_rss_reta_info(portid_t port_id,
 }
 
 /*
- * Displays the RSS hash functions of a port, and, optionally, the RSS hash
+ * Displays the RSS hash functions of a port, and, optionaly, the RSS hash
  * key of the port.
  */
 void
@@ -5250,7 +5250,7 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx)
 {
 	port->mc_addr_nb--;
 	if (addr_idx == port->mc_addr_nb) {
-		/* No need to recompact the set of multicast addresses. */
+		/* No need to recompact the set of multicast addressses. */
 		if (port->mc_addr_nb == 0) {
 			/* free the pool of multicast addresses. */
 			free(port->mc_addr_pool);
diff a/app/test-pmd/icmpecho.c b/app/test-pmd/icmpecho.c	(rejected hunks)
@@ -54,7 +54,7 @@ arp_op_name(uint16_t arp_op)
 	default:
 		break;
 	}
-	return "Unknown ARP op";
+	return "Unkwown ARP op";
 }
 
 static const char *

https://lab.dpdk.org/results/dashboard/patchsets/20244/

UNH-IOL DPDK Community Lab

|WARNING| pw104414 [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104414

_coding style issues_


WARNING:TYPO_SPELLING: 'differents' may be misspelled - perhaps 'different'?
#198: FILE: app/test-pmd/cmdline.c:3676:
+	 * Then, check that all values in the list are differents.

WARNING:TYPO_SPELLING: 'optionaly' may be misspelled - perhaps 'optionally'?
#228: FILE: app/test-pmd/config.c:2968:
+ * Displays the RSS hash functions of a port, and, optionaly, the RSS hash

WARNING:TYPO_SPELLING: 'addressses' may be misspelled - perhaps 'addresses'?
#237: FILE: app/test-pmd/config.c:5253:
+		/* No need to recompact the set of multicast addressses. */

WARNING:TYPO_SPELLING: 'Unkwown' may be misspelled - perhaps 'Unknown'?
#250: FILE: app/test-pmd/icmpecho.c:57:
+	return "Unkwown ARP op";

ERROR:TRAILING_WHITESPACE: trailing whitespace
#299: FILE: app/test-pmd/parameters.c:1555:
+^I^I^ITESTPMD_LOG(ERR, $

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#331: FILE: app/test-pmd/testpmd.c:557:
+int gpu_id = 0;

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#390: FILE: app/test-pmd/testpmd.c:1169:
+	ret = rte_extmem_register(gpu_mem.buf_ptr, gpu_mem.buf_len, NULL, gpu_mem.buf_iova, gpu_page_size);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#392: FILE: app/test-pmd/testpmd.c:1171:
+		rte_exit(EXIT_FAILURE, "Unable to register addr 0x%p, ret %d
", gpu_mem.buf_ptr, ret);

WARNING:LONG_LINE: line length of 128 exceeds 100 columns
#405: FILE: app/test-pmd/testpmd.c:1184:
+	rte_mp = rte_pktmbuf_pool_create_extbuf(pool_name, nb_mbuf, mb_mempool_cache, 0, mbuf_seg_size, socket_id, &gpu_mem, 1);

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#430: FILE: app/test-pmd/testpmd.c:1790:
 			for (j = 0; j < mbuf_data_size_n; j++)
+			{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#453: FILE: app/test-pmd/testpmd.c:1809:
 		for (i = 0; i < mbuf_data_size_n; i++)
+		{

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#497: FILE: app/test-pmd/testpmd.c:3541:
+								(uint8_t *)mempools_ext_ptr[i], ret, rte_errno);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#502: FILE: app/test-pmd/testpmd.c:3546:
+						if (ret != 0)

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#508: FILE: app/test-pmd/testpmd.c:3552:
+								(void *)mempools_ext_ptr[i], RTE_BAD_IOVA,

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#511: FILE: app/test-pmd/testpmd.c:3555:
+						if (ret)

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#514: FILE: app/test-pmd/testpmd.c:3558:
+									(uint8_t *)mempools_ext_ptr[i], ret, rte_errno);

total: 4 errors, 12 warnings, 389 lines checked