|WARNING| pw104438-104449 [PATCH] [v3, 12/12] app: remove unnecessary include of atomic header file

|WARNING| pw104438-104449 [PATCH] [v3, 12/12] app: remove unnecessary include of atomic header file

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 2627 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/104438

_apply patch failure_

Submitter: Joyce Kong <joyce.kong@arm.com>
Date: Wednesday, November 17 2021 08:22:00 
Applied on: CommitID:329f73eb355ebd7ca5ff37916d37872d28365452
Apply patch set 104438-104449 failed:

Checking patch app/test/test_func_reentrancy.c...
error: while searching for:
	for (i = 0; i < MAX_ITER_ONCE; i++) {
		handle = rte_hash_create(&hash_params);
		if (handle != NULL)
			rte_atomic32_inc(&obj_count);
	}

	/* create mutiple times simultaneously */

error: patch failed: app/test/test_func_reentrancy.c:250
error: while searching for:
	for (i = 0; i < MAX_ITER_ONCE; i++) {
		handle = rte_fbk_hash_create(&fbk_params);
		if (handle != NULL)
			rte_atomic32_inc(&obj_count);
	}

	/* create mutiple fbk tables simultaneously */

error: patch failed: app/test/test_func_reentrancy.c:318
error: while searching for:
	for (i = 0; i < MAX_ITER_ONCE; i++) {
		lpm = rte_lpm_create("fr_test_once",  SOCKET_ID_ANY, &config);
		if (lpm != NULL)
			rte_atomic32_inc(&obj_count);
	}

	/* create mutiple fbk tables simultaneously */

error: patch failed: app/test/test_func_reentrancy.c:384
Applying patch app/test/test_func_reentrancy.c with 3 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Rejected hunk #6.
Rejected hunk #7.
Rejected hunk #8.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Hunk #11 applied cleanly.
diff a/app/test/test_func_reentrancy.c b/app/test/test_func_reentrancy.c	(rejected hunks)
@@ -250,7 +249,7 @@ hash_create_free(__rte_unused void *arg)
 	for (i = 0; i < MAX_ITER_ONCE; i++) {
 		handle = rte_hash_create(&hash_params);
 		if (handle != NULL)
-			rte_atomic32_inc(&obj_count);
+			__atomic_fetch_add(&obj_count, 1, __ATOMIC_RELAXED);
 	}
 
 	/* create mutiple times simultaneously */
@@ -318,7 +317,7 @@ fbk_create_free(__rte_unused void *arg)
 	for (i = 0; i < MAX_ITER_ONCE; i++) {
 		handle = rte_fbk_hash_create(&fbk_params);
 		if (handle != NULL)
-			rte_atomic32_inc(&obj_count);
+			__atomic_fetch_add(&obj_count, 1, __ATOMIC_RELAXED);
 	}
 
 	/* create mutiple fbk tables simultaneously */
@@ -384,7 +383,7 @@ lpm_create_free(__rte_unused void *arg)
 	for (i = 0; i < MAX_ITER_ONCE; i++) {
 		lpm = rte_lpm_create("fr_test_once",  SOCKET_ID_ANY, &config);
 		if (lpm != NULL)
-			rte_atomic32_inc(&obj_count);
+			__atomic_fetch_add(&obj_count, 1, __ATOMIC_RELAXED);
 	}
 
 	/* create mutiple fbk tables simultaneously */

https://lab.dpdk.org/results/dashboard/patchsets/20254/

UNH-IOL DPDK Community Lab