|WARNING| pw106987 [PATCH] [v3, 1/1] vhost: integrate dmadev in asynchronous data-path

|WARNING| pw106987 [PATCH] [v3, 1/1] vhost: integrate dmadev in asynchronous data-path

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 4109 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/106987

_apply patch failure_

Submitter: Jiayu Hu <jiayu.hu@intel.com>
Date: Tuesday, February 08 2022 10:40:31 
Applied on: CommitID:0e4dc6af06228c8504a5538512cb31ed7bf6cc23
Apply patch set 106987 failed:

Checking patch doc/guides/prog_guide/vhost_lib.rst...
error: while searching for:

  Called to get the notify area info of the queue.

Recommended IOVA mode in async datapath
---------------------------------------


error: patch failed: doc/guides/prog_guide/vhost_lib.rst:443
error: while searching for:
For PA mode, page by page mapping may exceed IOMMU's max capability,
better to use 1G guest hugepage.

For uio driver, any vfio related error message can be ignored.
error: patch failed: doc/guides/prog_guide/vhost_lib.rst:450
Checking patch examples/vhost/Makefile...
Checking patch examples/vhost/ioat.c...
Checking patch examples/vhost/ioat.h...
Checking patch examples/vhost/main.c...
Checking patch examples/vhost/main.h...
Checking patch examples/vhost/meson.build...
Checking patch lib/vhost/meson.build...
Checking patch lib/vhost/rte_vhost.h...
Checking patch lib/vhost/rte_vhost_async.h...
Checking patch lib/vhost/version.map...
Checking patch lib/vhost/vhost.c...
Checking patch lib/vhost/vhost.h...
Checking patch lib/vhost/virtio_net.c...
Applying patch doc/guides/prog_guide/vhost_lib.rst with 2 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Rejected hunk #5.
Rejected hunk #6.
Applied patch examples/vhost/Makefile cleanly.
Applied patch examples/vhost/ioat.c cleanly.
Applied patch examples/vhost/ioat.h cleanly.
Applied patch examples/vhost/main.c cleanly.
Applied patch examples/vhost/main.h cleanly.
Applied patch examples/vhost/meson.build cleanly.
Applied patch lib/vhost/meson.build cleanly.
Applied patch lib/vhost/rte_vhost.h cleanly.
Applied patch lib/vhost/rte_vhost_async.h cleanly.
Applied patch lib/vhost/version.map cleanly.
Applied patch lib/vhost/vhost.c cleanly.
Applied patch lib/vhost/vhost.h cleanly.
Applied patch lib/vhost/virtio_net.c cleanly.
diff a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst	(rejected hunks)
@@ -443,6 +415,29 @@ Finally, a set of device ops is defined for device specific operations:
 
   Called to get the notify area info of the queue.
 
+Vhost asynchronous data path
+----------------------------
+
+Vhost asynchronous data path leverages DMA devices to offload memory
+copies from the CPU and it is implemented in an asynchronous way. It
+enables applications, like OVS, to save CPU cycles and hide memory copy
+overhead, thus achieving higher throughput.
+
+Vhost doesn't manage DMA devices and applications, like OVS, need to
+manage and configure DMA devices. Applications need to tell vhost what
+DMA devices to use in every data path function call. This design enables
+the flexibility for applications to dynamically use DMA channels in
+different function modules, not limited in vhost.
+
+In addition, vhost supports M:N mapping between vrings and DMA virtual
+channels. Specifically, one vring can use multiple different DMA channels
+and one DMA channel can be shared by multiple vrings at the same time.
+The reason of enabling one vring to use multiple DMA channels is that
+it's possible that more than one dataplane threads enqueue packets to
+the same vring with their own DMA virtual channels. Besides, the number
+of DMA devices is limited. For the purpose of scaling, it's necessary to
+support sharing DMA channels among vrings.
+
 Recommended IOVA mode in async datapath
 ---------------------------------------
 
@@ -450,4 +445,4 @@ When DMA devices are bound to vfio driver, VA mode is recommended.
 For PA mode, page by page mapping may exceed IOMMU's max capability,
 better to use 1G guest hugepage.
 
-For uio driver, any vfio related error message can be ignored.
\ No newline at end of file
+For uio driver, any vfio related error message can be ignored.

https://lab.dpdk.org/results/dashboard/patchsets/20935/

UNH-IOL DPDK Community Lab

|WARNING| pw106987 [PATCH v3 1/1] vhost: integrate dmadev in asynchronous data-path

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106987

_coding style issues_


WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#1373: FILE: lib/vhost/vhost.c:1654:
+	async->pkts_cmpl_flag = rte_zmalloc_socket(NULL, vq->size * sizeof(bool), RTE_CACHE_LINE_SIZE,

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1756: FILE: lib/vhost/virtio_net.c:112:
+		ret = vhost_async_dma_transfer_one(dev, vq, dma_id, vchan_id, head_idx, &pkts[pkt_idx]);

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#1931: FILE: lib/vhost/virtio_net.c:1829:
+	n_xfer = vhost_async_dma_transfer(dev, vq, dma_id, vchan_id, async->pkts_idx, async->iov_iter,

total: 0 errors, 3 warnings, 1610 lines checked