|WARNING| pw108315-108316 [PATCH] [v2, 2/2] net/cnxk: align perfetchs to CN10K cache model

|WARNING| pw108315-108316 [PATCH] [v2, 2/2] net/cnxk: align perfetchs to CN10K cache model

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 3359 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/108315

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Thursday, February 24 2022 16:10:12 
Applied on: CommitID:ee05a93e1e6633d0fdec409faf09f12a2e05b991
Apply patch set 108315-108316 failed:

Checking patch drivers/event/cnxk/cn10k_worker.h...
Hunk #1 succeeded at 114 (offset -4 lines).
error: while searching for:
		cn10k_nix_mbuf_to_tstamp((struct rte_mbuf *)mbuf, tstamp,
					flags & NIX_RX_OFFLOAD_TSTAMP_F,
					(uint64_t *)tstamp_ptr);
		wqe[0] = (uint64_t *)mbuf;
		non_vec--;
		wqe++;
	}

error: patch failed: drivers/event/cnxk/cn10k_worker.h:182
Hunk #3 succeeded at 603 (offset -9 lines).
Checking patch drivers/net/cnxk/cn10k_rx.h...
Hunk #2 succeeded at 625 (offset -65 lines).
error: while searching for:
			nix_cqe_xtract_mseg((union nix_rx_parse_u *)
					    (CQE_PTR_OFF(cq0, 3, 8, flags)),
					    mbuf3, mbuf_initializer, flags);
		} else {
			/* Update that no more segments */
			mbuf0->next = NULL;
			mbuf1->next = NULL;
			mbuf2->next = NULL;
			mbuf3->next = NULL;
		}

		/* Prefetch mbufs */
		roc_prefetch_store_keep(mbuf0);
		roc_prefetch_store_keep(mbuf1);
		roc_prefetch_store_keep(mbuf2);
		roc_prefetch_store_keep(mbuf3);

		packets += NIX_DESCS_PER_LOOP;


error: patch failed: drivers/net/cnxk/cn10k_rx.h:997
Checking patch drivers/net/cnxk/cn10k_tx.h...
Applying patch drivers/event/cnxk/cn10k_worker.h with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
Applying patch drivers/net/cnxk/cn10k_rx.h with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Applied patch drivers/net/cnxk/cn10k_tx.h cleanly.
diff a/drivers/event/cnxk/cn10k_worker.h b/drivers/event/cnxk/cn10k_worker.h	(rejected hunks)
@@ -182,7 +182,7 @@ cn10k_process_vwqe(uintptr_t vwqe, uint16_t port_id, const uint32_t flags,
 		cn10k_nix_mbuf_to_tstamp((struct rte_mbuf *)mbuf, tstamp,
 					flags & NIX_RX_OFFLOAD_TSTAMP_F,
 					(uint64_t *)tstamp_ptr);
-		wqe[0] = (uint64_t *)mbuf;
+		wqe[0] = (struct rte_mbuf *)mbuf;
 		non_vec--;
 		wqe++;
 	}
diff a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h	(rejected hunks)
@@ -997,19 +1069,18 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,
 			nix_cqe_xtract_mseg((union nix_rx_parse_u *)
 					    (CQE_PTR_OFF(cq0, 3, 8, flags)),
 					    mbuf3, mbuf_initializer, flags);
-		} else {
-			/* Update that no more segments */
-			mbuf0->next = NULL;
-			mbuf1->next = NULL;
-			mbuf2->next = NULL;
-			mbuf3->next = NULL;
 		}
 
-		/* Prefetch mbufs */
-		roc_prefetch_store_keep(mbuf0);
-		roc_prefetch_store_keep(mbuf1);
-		roc_prefetch_store_keep(mbuf2);
-		roc_prefetch_store_keep(mbuf3);
+		/* Mark mempool obj as "get" as it is alloc'ed by NIX */
+		RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1);
+		RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1);
+		RTE_MEMPOOL_CHECK_COOKIES(mbuf2->pool, (void **)&mbuf2, 1, 1);
+		RTE_MEMPOOL_CHECK_COOKIES(mbuf3->pool, (void **)&mbuf3, 1, 1);
+
+		NIX_MBUF_VALIDATE_NEXT(mbuf0);
+		NIX_MBUF_VALIDATE_NEXT(mbuf1);
+		NIX_MBUF_VALIDATE_NEXT(mbuf2);
+		NIX_MBUF_VALIDATE_NEXT(mbuf3);
 
 		packets += NIX_DESCS_PER_LOOP;
 

https://lab.dpdk.org/results/dashboard/patchsets/21265/

UNH-IOL DPDK Community Lab