|WARNING| pw109701-109702 [PATCH] [v2, 2/2] cryptodev: add dh padding options

|WARNING| pw109701-109702 [PATCH] [v2, 2/2] cryptodev: add dh padding options

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 2555 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/109701

_apply patch failure_

Submitter: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Date: Wednesday, April 13 2022 14:03:27 
Applied on: CommitID:1e230b9be8866939ef7ce9f7f16b8c8369b7bc28
Apply patch set 109701-109702 failed:

Checking patch lib/cryptodev/rte_crypto_asym.h...
Hunk #1 succeeded at 115 (offset -2 lines).
error: while searching for:
	 * For ECDH it is a point on the curve.
	 * Output for RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE
	 * Input for RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE
	 */

	union {

error: patch failed: lib/cryptodev/rte_crypto_asym.h:412
error: while searching for:
	 * For ECDH it is a point on the curve.
	 * Output for RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE
	 */
};

/**

error: patch failed: lib/cryptodev/rte_crypto_asym.h:424
Checking patch lib/cryptodev/rte_cryptodev.c...
Applying patch lib/cryptodev/rte_crypto_asym.h with 2 rejects...
Hunk #1 applied cleanly.
Rejected hunk #2.
Rejected hunk #3.
Applied patch lib/cryptodev/rte_cryptodev.c cleanly.
diff a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h	(rejected hunks)
@@ -412,6 +414,11 @@ struct rte_crypto_dh_op_param {
 	 * For ECDH it is a point on the curve.
 	 * Output for RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE
 	 * Input for RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE
+	 * Input for RTE_CRYPTO_ASYM_OP_DH_KEY_VERIFY
+	 *
+	 * VERIFY option can be used only for elliptic curve
+	 * point validation, for FFDH (DH) it is user's reponsability
+	 * to check the public key accordingly.
 	 */
 
 	union {
@@ -424,6 +431,18 @@ struct rte_crypto_dh_op_param {
 	 * For ECDH it is a point on the curve.
 	 * Output for RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE
 	 */
+	 uint16_t flags;
+	 /*
+	  * Diffie-Hellman operation flags
+	  * Flag                | Bit pos |      Description
+	  *--------------------------------------------------------------------------------
+	  *                     |         | If set to 1 - verification will use all four
+	  * Full verification   |    0    | steps of point verification (full validation),
+	  *                     |         | otherwise three (partial validation - default).
+	  *--------------------------------------------------------------------------------
+	  * Reserved            |   1-15  | Reserved
+	  */
+
 };
 
 /**
Checking patch lib/cryptodev/rte_crypto_asym.h...
error: lib/cryptodev/rte_crypto_asym.h: does not match index

https://lab.dpdk.org/results/dashboard/patchsets/21797/

UNH-IOL DPDK Community Lab