* |WARNING| pw113915 [PATCH v1 3/4] test/power: add unit tests for uncore api
[not found] <20220711162300.3308684-4-tadhg.kearney@intel.com>
@ 2022-07-11 16:24 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-07-11 16:24 UTC (permalink / raw)
To: test-report; +Cc: tadhgkearney
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/113915
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: app/test/test_power_uncore.c:12:
+ printf("Power management library not supported, skipping test
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#112: FILE: app/test/test_power_uncore.c:13:
+ return TEST_SKIPPED;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: app/test/test_power_uncore.c:29:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: app/test/test_power_uncore.c:32:
+ ret = rte_power_uncore_init(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: app/test/test_power_uncore.c:33:
+ if(ret < 0){$
ERROR:SPACING: space required before the open brace '{'
#132: FILE: app/test/test_power_uncore.c:33:
+ if(ret < 0){
ERROR:SPACING: space required before the open parenthesis '('
#132: FILE: app/test/test_power_uncore.c:33:
+ if(ret < 0){
ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: app/test/test_power_uncore.c:34:
+ printf("Cannot initialise uncore power management for pkg %u die %u, this "$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: app/test/test_power_uncore.c:34:
+ printf("Cannot initialise uncore power management for pkg %u die %u, this "$
ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: app/test/test_power_uncore.c:35:
+ "may occur if environment is not configured "$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: app/test/test_power_uncore.c:35:
+ "may occur if environment is not configured "$
ERROR:CODE_INDENT: code indent should use tabs where possible
#135: FILE: app/test/test_power_uncore.c:36:
+ "correctly(APCI cpufreq) or operating in another valid "$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: app/test/test_power_uncore.c:36:
+ "correctly(APCI cpufreq) or operating in another valid "$
ERROR:CODE_INDENT: code indent should use tabs where possible
#136: FILE: app/test/test_power_uncore.c:37:
+ "Power management environment
", VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: app/test/test_power_uncore.c:37:
+ "Power management environment
", VALID_PKG, VALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: app/test/test_power_uncore.c:38:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: app/test/test_power_uncore.c:38:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: app/test/test_power_uncore.c:39:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#141: FILE: app/test/test_power_uncore.c:42:
+ ret = rte_power_uncore_init(INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#142: FILE: app/test/test_power_uncore.c:43:
+ if (ret == 0) {$
WARNING:TYPO_SPELLING: 'managment' may be misspelled - perhaps 'management'?
#143: FILE: app/test/test_power_uncore.c:44:
+ printf("Unexpectedly was able to initialise uncore power managment "
ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: app/test/test_power_uncore.c:44:
+ printf("Unexpectedly was able to initialise uncore power managment "$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: app/test/test_power_uncore.c:44:
+ printf("Unexpectedly was able to initialise uncore power managment "$
ERROR:CODE_INDENT: code indent should use tabs where possible
#144: FILE: app/test/test_power_uncore.c:45:
+ "for pkg %u die %u
", INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: app/test/test_power_uncore.c:45:
+ "for pkg %u die %u
", INVALID_PKG, INVALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#145: FILE: app/test/test_power_uncore.c:46:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#145: FILE: app/test/test_power_uncore.c:46:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#146: FILE: app/test/test_power_uncore.c:47:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: app/test/test_power_uncore.c:49:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#154: FILE: app/test/test_power_uncore.c:55:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: app/test/test_power_uncore.c:58:
+ ret = rte_power_get_uncore_freq(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: app/test/test_power_uncore.c:59:
+ if (ret < 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: app/test/test_power_uncore.c:60:
+ printf("Failed to get uncore frequency for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: app/test/test_power_uncore.c:60:
+ printf("Failed to get uncore frequency for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: app/test/test_power_uncore.c:61:
+ VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: app/test/test_power_uncore.c:61:
+ VALID_PKG, VALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: app/test/test_power_uncore.c:62:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: app/test/test_power_uncore.c:62:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: app/test/test_power_uncore.c:63:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: app/test/test_power_uncore.c:66:
+ ret = rte_power_get_uncore_freq(INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#166: FILE: app/test/test_power_uncore.c:67:
+ if (ret >= 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#167: FILE: app/test/test_power_uncore.c:68:
+ printf("Unexpectedly got invalid uncore frequency for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#167: FILE: app/test/test_power_uncore.c:68:
+ printf("Unexpectedly got invalid uncore frequency for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: app/test/test_power_uncore.c:69:
+ INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: app/test/test_power_uncore.c:69:
+ INVALID_PKG, INVALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#169: FILE: app/test/test_power_uncore.c:70:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: app/test/test_power_uncore.c:70:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#170: FILE: app/test/test_power_uncore.c:71:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: app/test/test_power_uncore.c:73:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: app/test/test_power_uncore.c:79:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: app/test/test_power_uncore.c:82:
+ ret = rte_power_set_uncore_freq(VALID_PKG, VALID_DIE, VALID_INDEX);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: app/test/test_power_uncore.c:83:
+ if (ret < 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: app/test/test_power_uncore.c:84:
+ printf("Failed to set uncore frequency for pkg %u die %u index %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: app/test/test_power_uncore.c:84:
+ printf("Failed to set uncore frequency for pkg %u die %u index %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: app/test/test_power_uncore.c:85:
+ VALID_PKG, VALID_DIE, VALID_INDEX);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: app/test/test_power_uncore.c:85:
+ VALID_PKG, VALID_DIE, VALID_INDEX);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#185: FILE: app/test/test_power_uncore.c:86:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#185: FILE: app/test/test_power_uncore.c:86:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: app/test/test_power_uncore.c:87:
+ }$
WARNING:TYPO_SPELLING: 'unsuccesfully' may be misspelled - perhaps 'unsuccessfully'?
#188: FILE: app/test/test_power_uncore.c:89:
+ /* Try to unsuccesfully set invlaid uncore freq index */
WARNING:TYPO_SPELLING: 'invlaid' may be misspelled - perhaps 'invalid'?
#188: FILE: app/test/test_power_uncore.c:89:
+ /* Try to unsuccesfully set invlaid uncore freq index */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: app/test/test_power_uncore.c:90:
+ ret = rte_power_set_uncore_freq(VALID_PKG, VALID_DIE, INVALID_INDEX);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: app/test/test_power_uncore.c:91:
+ if (ret == 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#191: FILE: app/test/test_power_uncore.c:92:
+ printf("Unexpectedly set invalid uncore index for pkg %u die %u index %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#191: FILE: app/test/test_power_uncore.c:92:
+ printf("Unexpectedly set invalid uncore index for pkg %u die %u index %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#192: FILE: app/test/test_power_uncore.c:93:
+ VALID_PKG, VALID_DIE, INVALID_INDEX);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#192: FILE: app/test/test_power_uncore.c:93:
+ VALID_PKG, VALID_DIE, INVALID_INDEX);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: app/test/test_power_uncore.c:94:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#193: FILE: app/test/test_power_uncore.c:94:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: app/test/test_power_uncore.c:95:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: app/test/test_power_uncore.c:98:
+ ret = rte_power_set_uncore_freq(INVALID_PKG, INVALID_DIE, VALID_INDEX);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: app/test/test_power_uncore.c:99:
+ if (ret == 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#199: FILE: app/test/test_power_uncore.c:100:
+ printf("Unexpectedly set invalid uncore frequency for pkg %u die %u index %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: app/test/test_power_uncore.c:100:
+ printf("Unexpectedly set invalid uncore frequency for pkg %u die %u index %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#200: FILE: app/test/test_power_uncore.c:101:
+ INVALID_PKG, INVALID_DIE, VALID_INDEX);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: app/test/test_power_uncore.c:101:
+ INVALID_PKG, INVALID_DIE, VALID_INDEX);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: app/test/test_power_uncore.c:102:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: app/test/test_power_uncore.c:102:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: app/test/test_power_uncore.c:103:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: app/test/test_power_uncore.c:105:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: app/test/test_power_uncore.c:111:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: app/test/test_power_uncore.c:114:
+ ret = rte_power_uncore_freq_max(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: app/test/test_power_uncore.c:115:
+ if (ret < 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#215: FILE: app/test/test_power_uncore.c:116:
+ printf("Failed to set max uncore frequency for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: app/test/test_power_uncore.c:116:
+ printf("Failed to set max uncore frequency for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#216: FILE: app/test/test_power_uncore.c:117:
+ VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#216: FILE: app/test/test_power_uncore.c:117:
+ VALID_PKG, VALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#217: FILE: app/test/test_power_uncore.c:118:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#217: FILE: app/test/test_power_uncore.c:118:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#218: FILE: app/test/test_power_uncore.c:119:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: app/test/test_power_uncore.c:122:
+ ret = rte_power_uncore_freq_max(INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: app/test/test_power_uncore.c:123:
+ if (ret == 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#223: FILE: app/test/test_power_uncore.c:124:
+ printf("Unexpectedly set invalid max uncore frequency for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: app/test/test_power_uncore.c:124:
+ printf("Unexpectedly set invalid max uncore frequency for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#224: FILE: app/test/test_power_uncore.c:125:
+ INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: app/test/test_power_uncore.c:125:
+ INVALID_PKG, INVALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#225: FILE: app/test/test_power_uncore.c:126:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#225: FILE: app/test/test_power_uncore.c:126:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: app/test/test_power_uncore.c:127:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: app/test/test_power_uncore.c:129:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: app/test/test_power_uncore.c:135:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#237: FILE: app/test/test_power_uncore.c:138:
+ ret = rte_power_uncore_freq_min(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: app/test/test_power_uncore.c:139:
+ if (ret < 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#239: FILE: app/test/test_power_uncore.c:140:
+ printf("Failed to set min uncore frequency for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#239: FILE: app/test/test_power_uncore.c:140:
+ printf("Failed to set min uncore frequency for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: app/test/test_power_uncore.c:141:
+ VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: app/test/test_power_uncore.c:141:
+ VALID_PKG, VALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: app/test/test_power_uncore.c:142:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#241: FILE: app/test/test_power_uncore.c:142:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: app/test/test_power_uncore.c:143:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: app/test/test_power_uncore.c:146:
+ ret = rte_power_uncore_freq_min(INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: app/test/test_power_uncore.c:147:
+ if (ret == 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: app/test/test_power_uncore.c:148:
+ printf("Unexpectedly set invalid min uncore frequency for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: app/test/test_power_uncore.c:148:
+ printf("Unexpectedly set invalid min uncore frequency for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#248: FILE: app/test/test_power_uncore.c:149:
+ INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: app/test/test_power_uncore.c:149:
+ INVALID_PKG, INVALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: app/test/test_power_uncore.c:150:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: app/test/test_power_uncore.c:150:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: app/test/test_power_uncore.c:151:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#252: FILE: app/test/test_power_uncore.c:153:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#258: FILE: app/test/test_power_uncore.c:159:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: app/test/test_power_uncore.c:162:
+ ret = rte_power_uncore_get_num_freqs(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#262: FILE: app/test/test_power_uncore.c:163:
+ if (ret < 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: app/test/test_power_uncore.c:164:
+ printf("Failed to get number of uncore frequencies for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: app/test/test_power_uncore.c:164:
+ printf("Failed to get number of uncore frequencies for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#264: FILE: app/test/test_power_uncore.c:165:
+ VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#264: FILE: app/test/test_power_uncore.c:165:
+ VALID_PKG, VALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#265: FILE: app/test/test_power_uncore.c:166:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: app/test/test_power_uncore.c:166:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#266: FILE: app/test/test_power_uncore.c:167:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#269: FILE: app/test/test_power_uncore.c:170:
+ ret = rte_power_uncore_get_num_freqs(INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: app/test/test_power_uncore.c:171:
+ if (ret >= 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#271: FILE: app/test/test_power_uncore.c:172:
+ printf("Unexpectedly got number of invalid frequencies for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#271: FILE: app/test/test_power_uncore.c:172:
+ printf("Unexpectedly got number of invalid frequencies for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#272: FILE: app/test/test_power_uncore.c:173:
+ INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: app/test/test_power_uncore.c:173:
+ INVALID_PKG, INVALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#273: FILE: app/test/test_power_uncore.c:174:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: app/test/test_power_uncore.c:174:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#274: FILE: app/test/test_power_uncore.c:175:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#276: FILE: app/test/test_power_uncore.c:177:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#282: FILE: app/test/test_power_uncore.c:183:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: app/test/test_power_uncore.c:186:
+ ret = rte_power_uncore_exit(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: app/test/test_power_uncore.c:187:
+ if(ret < 0) {$
ERROR:SPACING: space required before the open parenthesis '('
#286: FILE: app/test/test_power_uncore.c:187:
+ if(ret < 0) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: app/test/test_power_uncore.c:188:
+ printf("Failed to exit uncore power management for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: app/test/test_power_uncore.c:188:
+ printf("Failed to exit uncore power management for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: app/test/test_power_uncore.c:189:
+ VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: app/test/test_power_uncore.c:189:
+ VALID_PKG, VALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: app/test/test_power_uncore.c:190:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: app/test/test_power_uncore.c:190:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: app/test/test_power_uncore.c:191:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#293: FILE: app/test/test_power_uncore.c:194:
+ ret = rte_power_uncore_exit(INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#294: FILE: app/test/test_power_uncore.c:195:
+ if (ret == 0) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#295: FILE: app/test/test_power_uncore.c:196:
+ printf("Unexpectedly was able to exit uncore power management for pkg %u die %u
",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#295: FILE: app/test/test_power_uncore.c:196:
+ printf("Unexpectedly was able to exit uncore power management for pkg %u die %u
",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#296: FILE: app/test/test_power_uncore.c:197:
+ INVALID_PKG, INVALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: app/test/test_power_uncore.c:197:
+ INVALID_PKG, INVALID_DIE);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#297: FILE: app/test/test_power_uncore.c:198:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#297: FILE: app/test/test_power_uncore.c:198:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: app/test/test_power_uncore.c:199:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: app/test/test_power_uncore.c:201:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#306: FILE: app/test/test_power_uncore.c:207:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#308: FILE: app/test/test_power_uncore.c:209:
+ ret = check_power_uncore_init();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: app/test/test_power_uncore.c:210:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#310: FILE: app/test/test_power_uncore.c:211:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: app/test/test_power_uncore.c:211:
+ goto fail_all;$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#311: FILE: app/test/test_power_uncore.c:212:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#311: FILE: app/test/test_power_uncore.c:212:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#312: FILE: app/test/test_power_uncore.c:213:
+ ret = check_power_get_uncore_freq();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#313: FILE: app/test/test_power_uncore.c:214:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#314: FILE: app/test/test_power_uncore.c:215:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#314: FILE: app/test/test_power_uncore.c:215:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#316: FILE: app/test/test_power_uncore.c:217:
+ ret = check_power_set_uncore_freq();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#317: FILE: app/test/test_power_uncore.c:218:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#318: FILE: app/test/test_power_uncore.c:219:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: app/test/test_power_uncore.c:219:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#320: FILE: app/test/test_power_uncore.c:221:
+ ret = check_power_uncore_freq_max();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#321: FILE: app/test/test_power_uncore.c:222:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#322: FILE: app/test/test_power_uncore.c:223:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#322: FILE: app/test/test_power_uncore.c:223:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#324: FILE: app/test/test_power_uncore.c:225:
+ ret = check_power_uncore_freq_min();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: app/test/test_power_uncore.c:226:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: app/test/test_power_uncore.c:227:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: app/test/test_power_uncore.c:227:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: app/test/test_power_uncore.c:229:
+ ret = check_power_uncore_get_num_freqs();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: app/test/test_power_uncore.c:230:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#330: FILE: app/test/test_power_uncore.c:231:
+ goto fail_all;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: app/test/test_power_uncore.c:231:
+ goto fail_all;$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#331: FILE: app/test/test_power_uncore.c:232:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: app/test/test_power_uncore.c:232:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#332: FILE: app/test/test_power_uncore.c:233:
+ ret = check_power_uncore_exit();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: app/test/test_power_uncore.c:234:
+ if (ret < 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#334: FILE: app/test/test_power_uncore.c:235:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#334: FILE: app/test/test_power_uncore.c:235:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: app/test/test_power_uncore.c:237:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#339: FILE: app/test/test_power_uncore.c:240:
+ rte_power_uncore_exit(VALID_PKG, VALID_DIE);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#340: FILE: app/test/test_power_uncore.c:241:
+ return -1;$
total: 59 errors, 138 warnings, 259 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-11 16:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220711162300.3308684-4-tadhg.kearney@intel.com>
2022-07-11 16:24 ` |WARNING| pw113915 [PATCH v1 3/4] test/power: add unit tests for uncore api checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).