From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw117061 [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.
Date: Wed, 28 Sep 2022 10:29:33 -0400 (EDT) [thread overview]
Message-ID: <20220928142933.283816D509@noxus.dpdklab.iol.unh.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/117061
_apply patch failure_
Submitter: jiangheng (G) <jiangheng14@huawei.com>
Date: Wednesday, September 28 2022 14:10:52
Applied on: CommitID:3fe71706abc1f13294c82477a0538047f8e4ebbf
Apply patch set 117061 failed:
Checking patch lib/gro/gro_tcp4.c...
error: while searching for:
* Don't process the packet whose payload length is less than or
* equal to 0.
*/
tcp_dl = pkt->pkt_len - hdr_len;
if (tcp_dl <= 0)
return -1;
error: patch failed: lib/gro/gro_tcp4.c:229
Applying patch lib/gro/gro_tcp4.c with 1 reject...
Rejected hunk #1.
diff a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c (rejected hunks)
@@ -229,7 +229,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
* Don't process the packet whose payload length is less than or
* equal to 0.
*/
- tcp_dl = pkt->pkt_len - hdr_len;
+ tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;
if (tcp_dl <= 0)
return -1;
https://lab.dpdk.org/results/dashboard/patchsets/23681/
UNH-IOL DPDK Community Lab
next reply other threads:[~2022-09-28 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 14:29 dpdklab [this message]
[not found] <1c1df455cdb640c9889d359186d38637@huawei.com>
2022-09-28 14:12 ` checkpatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928142933.283816D509@noxus.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).