* |WARNING| pw117848 [PATCH] [v1, 20/35] net/ionic: overhaul transmit side for performance
@ 2022-10-11 5:09 dpdklab
0 siblings, 0 replies; only message in thread
From: dpdklab @ 2022-10-11 5:09 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
[-- Attachment #1: Type: text/plain, Size: 8252 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/117848
_apply patch failure_
Submitter: Andrew Boyer <Andrew.Boyer@amd.com>
Date: Tuesday, October 11 2022 00:50:17
Applied on: CommitID:f13604fad12a81383da7b04821a4befb3d01e2ed
Apply patch set 117848 failed:
Checking patch drivers/net/ionic/ionic_lif.c...
error: while searching for:
"tx",
flags,
ntxq_descs,
1,
sizeof(struct ionic_txq_desc),
sizeof(struct ionic_txq_comp),
sizeof(struct ionic_txq_sg_desc_v1),
error: patch failed: drivers/net/ionic/ionic_lif.c:817
Checking patch drivers/net/ionic/ionic_rxtx.c...
error: while searching for:
{
struct ionic_queue *q = &txq->qcq.q;
ionic_empty_array(q->info, q->num_descs, 0);
}
static void __rte_cold
error: patch failed: drivers/net/ionic/ionic_rxtx.c:64
Hunk #2 succeeded at 70 (offset -32 lines).
error: while searching for:
uint16_t vlan_tci, bool has_vlan,
bool start, bool done)
{
void **info;
uint64_t cmd;
uint8_t flags = 0;
flags |= has_vlan ? IONIC_TXQ_DESC_FLAG_VLAN : 0;
flags |= encap ? IONIC_TXQ_DESC_FLAG_ENCAP : 0;
flags |= start ? IONIC_TXQ_DESC_FLAG_TSO_SOT : 0;
error: patch failed: drivers/net/ionic/ionic_rxtx.c:327
Hunk #4 succeeded at 314 (offset -33 lines).
error: while searching for:
struct ionic_tx_stats *stats = &txq->stats;
struct rte_mbuf *txm_seg;
void **info;
bool encap;
bool has_vlan;
uint64_t ol_flags = txm->ol_flags;
uint64_t addr, cmd;
uint8_t opcode = IONIC_TXQ_DESC_OPCODE_CSUM_NONE;
error: patch failed: drivers/net/ionic/ionic_rxtx.c:497
error: while searching for:
if (opcode == IONIC_TXQ_DESC_OPCODE_CSUM_NONE)
stats->no_csum++;
has_vlan = (ol_flags & RTE_MBUF_F_TX_VLAN);
encap = ((ol_flags & RTE_MBUF_F_TX_OUTER_IP_CKSUM) ||
(ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM)) &&
((ol_flags & RTE_MBUF_F_TX_OUTER_IPV4) ||
(ol_flags & RTE_MBUF_F_TX_OUTER_IPV6));
flags |= has_vlan ? IONIC_TXQ_DESC_FLAG_VLAN : 0;
flags |= encap ? IONIC_TXQ_DESC_FLAG_ENCAP : 0;
addr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm));
cmd = encode_txq_desc_cmd(opcode, flags, txm->nb_segs - 1, addr);
desc->cmd = rte_cpu_to_le_64(cmd);
desc->len = rte_cpu_to_le_16(txm->data_len);
desc->vlan_tci = rte_cpu_to_le_16(txm->vlan_tci);
info[0] = txm;
elem = sg_desc_base[q->head_idx].elems;
txm_seg = txm->next;
while (txm_seg != NULL) {
elem->len = rte_cpu_to_le_16(txm_seg->data_len);
elem->addr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm_seg));
elem++;
txm_seg = txm_seg->next;
}
q->head_idx = Q_NEXT_TO_POST(q, 1);
error: patch failed: drivers/net/ionic/ionic_rxtx.c:524
error: while searching for:
struct ionic_queue *q = &txq->qcq.q;
struct ionic_tx_stats *stats = &txq->stats;
struct rte_mbuf *mbuf;
uint32_t next_q_head_idx;
uint32_t bytes_tx = 0;
uint16_t nb_avail, nb_tx = 0;
int err;
/* Cleaning old buffers */
ionic_tx_flush(txq);
error: patch failed: drivers/net/ionic/ionic_rxtx.c:565
error: while searching for:
}
while (nb_tx < nb_pkts) {
next_q_head_idx = Q_NEXT_TO_POST(q, 1);
if ((next_q_head_idx & 0x3) == 0) {
struct ionic_txq_desc *desc_base = q->base;
rte_prefetch0(&desc_base[next_q_head_idx]);
rte_prefetch0(&q->info[next_q_head_idx]);
}
mbuf = tx_pkts[nb_tx];
error: patch failed: drivers/net/ionic/ionic_rxtx.c:580
Hunk #9 succeeded at 576 (offset -58 lines).
Applying patch drivers/net/ionic/ionic_lif.c with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/ionic/ionic_rxtx.c with 6 rejects...
Rejected hunk #1.
Hunk #2 applied cleanly.
Rejected hunk #3.
Hunk #4 applied cleanly.
Rejected hunk #5.
Rejected hunk #6.
Rejected hunk #7.
Rejected hunk #8.
Hunk #9 applied cleanly.
diff a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c (rejected hunks)
@@ -817,7 +817,7 @@ ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index,
"tx",
flags,
ntxq_descs,
- 1,
+ num_segs_fw,
sizeof(struct ionic_txq_desc),
sizeof(struct ionic_txq_comp),
sizeof(struct ionic_txq_sg_desc_v1),
diff a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c (rejected hunks)
@@ -64,7 +64,7 @@ ionic_tx_empty(struct ionic_tx_qcq *txq)
{
struct ionic_queue *q = &txq->qcq.q;
- ionic_empty_array(q->info, q->num_descs, 0);
+ ionic_empty_array(q->info, q->num_descs * q->num_segs, 0);
}
static void __rte_cold
@@ -327,9 +326,12 @@ ionic_tx_tso_post(struct ionic_queue *q, struct ionic_txq_desc *desc,
uint16_t vlan_tci, bool has_vlan,
bool start, bool done)
{
+ struct rte_mbuf *txm_seg;
void **info;
uint64_t cmd;
uint8_t flags = 0;
+ int i;
+
flags |= has_vlan ? IONIC_TXQ_DESC_FLAG_VLAN : 0;
flags |= encap ? IONIC_TXQ_DESC_FLAG_ENCAP : 0;
flags |= start ? IONIC_TXQ_DESC_FLAG_TSO_SOT : 0;
@@ -497,8 +505,7 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm)
struct ionic_tx_stats *stats = &txq->stats;
struct rte_mbuf *txm_seg;
void **info;
- bool encap;
- bool has_vlan;
+ rte_iova_t data_iova;
uint64_t ol_flags = txm->ol_flags;
uint64_t addr, cmd;
uint8_t opcode = IONIC_TXQ_DESC_OPCODE_CSUM_NONE;
@@ -524,32 +531,44 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm)
if (opcode == IONIC_TXQ_DESC_OPCODE_CSUM_NONE)
stats->no_csum++;
- has_vlan = (ol_flags & RTE_MBUF_F_TX_VLAN);
- encap = ((ol_flags & RTE_MBUF_F_TX_OUTER_IP_CKSUM) ||
- (ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM)) &&
- ((ol_flags & RTE_MBUF_F_TX_OUTER_IPV4) ||
- (ol_flags & RTE_MBUF_F_TX_OUTER_IPV6));
+ if (((ol_flags & RTE_MBUF_F_TX_OUTER_IP_CKSUM) ||
+ (ol_flags & RTE_MBUF_F_TX_OUTER_UDP_CKSUM)) &&
+ ((ol_flags & RTE_MBUF_F_TX_OUTER_IPV4) ||
+ (ol_flags & RTE_MBUF_F_TX_OUTER_IPV6))) {
+ flags |= IONIC_TXQ_DESC_FLAG_ENCAP;
+ }
- flags |= has_vlan ? IONIC_TXQ_DESC_FLAG_VLAN : 0;
- flags |= encap ? IONIC_TXQ_DESC_FLAG_ENCAP : 0;
+ if (ol_flags & RTE_MBUF_F_TX_VLAN) {
+ flags |= IONIC_TXQ_DESC_FLAG_VLAN;
+ desc->vlan_tci = rte_cpu_to_le_16(txm->vlan_tci);
+ }
addr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm));
cmd = encode_txq_desc_cmd(opcode, flags, txm->nb_segs - 1, addr);
desc->cmd = rte_cpu_to_le_64(cmd);
desc->len = rte_cpu_to_le_16(txm->data_len);
- desc->vlan_tci = rte_cpu_to_le_16(txm->vlan_tci);
info[0] = txm;
- elem = sg_desc_base[q->head_idx].elems;
+ if (txm->nb_segs > 1) {
+ txm_seg = txm->next;
- txm_seg = txm->next;
- while (txm_seg != NULL) {
- elem->len = rte_cpu_to_le_16(txm_seg->data_len);
- elem->addr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm_seg));
- elem++;
- txm_seg = txm_seg->next;
+ elem = sg_desc_base[q->head_idx].elems;
+
+ while (txm_seg != NULL) {
+ /* Stash the mbuf ptr in the array */
+ info++;
+ *info = txm_seg;
+
+ /* Configure the SGE */
+ data_iova = rte_mbuf_data_iova(txm_seg);
+ elem->len = rte_cpu_to_le_16(txm_seg->data_len);
+ elem->addr = rte_cpu_to_le_64(data_iova);
+ elem++;
+
+ txm_seg = txm_seg->next;
+ }
}
q->head_idx = Q_NEXT_TO_POST(q, 1);
@@ -565,11 +584,19 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
struct ionic_queue *q = &txq->qcq.q;
struct ionic_tx_stats *stats = &txq->stats;
struct rte_mbuf *mbuf;
- uint32_t next_q_head_idx;
uint32_t bytes_tx = 0;
uint16_t nb_avail, nb_tx = 0;
int err;
+ struct ionic_txq_desc *desc_base = q->base;
+ rte_prefetch0(&desc_base[q->head_idx]);
+ rte_prefetch0(IONIC_INFO_PTR(q, q->head_idx));
+
+ if (tx_pkts) {
+ rte_mbuf_prefetch_part1(tx_pkts[0]);
+ rte_mbuf_prefetch_part2(tx_pkts[0]);
+ }
+
/* Cleaning old buffers */
ionic_tx_flush(txq);
@@ -580,11 +607,13 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
}
while (nb_tx < nb_pkts) {
- next_q_head_idx = Q_NEXT_TO_POST(q, 1);
- if ((next_q_head_idx & 0x3) == 0) {
- struct ionic_txq_desc *desc_base = q->base;
- rte_prefetch0(&desc_base[next_q_head_idx]);
- rte_prefetch0(&q->info[next_q_head_idx]);
+ uint16_t next_idx = Q_NEXT_TO_POST(q, 1);
+ rte_prefetch0(&desc_base[next_idx]);
+ rte_prefetch0(IONIC_INFO_PTR(q, next_idx));
+
+ if (nb_tx + 1 < nb_pkts) {
+ rte_mbuf_prefetch_part1(tx_pkts[nb_tx + 1]);
+ rte_mbuf_prefetch_part2(tx_pkts[nb_tx + 1]);
}
mbuf = tx_pkts[nb_tx];
https://lab.dpdk.org/results/dashboard/patchsets/23889/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-11 5:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11 5:09 |WARNING| pw117848 [PATCH] [v1, 20/35] net/ionic: overhaul transmit side for performance dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).