* |WARNING| pw119120 [PATCH 3/8] ethdev: use VXLAN protocol struct for flow matching
[not found] <20221025214410.715864-4-thomas@monjalon.net>
@ 2022-10-25 21:45 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-10-25 21:45 UTC (permalink / raw)
To: test-report; +Cc: Thomas Monjalon
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119120
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[0] != 0'
#283: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[1] != 0'
#283: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd0[2] != 0'
#283: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.rsvd1 != 0'
#283: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_spec->hdr.flags != 8'
#283: FILE: drivers/net/bnxt/bnxt_flow.c:566:
+ if ((vxlan_spec->hdr.rsvd0[0] != 0) ||
+ (vxlan_spec->hdr.rsvd0[1] != 0) ||
+ (vxlan_spec->hdr.rsvd0[2] != 0) ||
+ (vxlan_spec->hdr.rsvd1 != 0) ||
+ (vxlan_spec->hdr.flags != 8)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[0] != 0xFF'
#520: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+ if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+ vxlan_mask->hdr.vni[2]) &&
+ ((vxlan_mask->hdr.vni[0] != 0xFF) ||
+ (vxlan_mask->hdr.vni[1] != 0xFF) ||
+ (vxlan_mask->hdr.vni[2] != 0xFF))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[1] != 0xFF'
#520: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+ if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+ vxlan_mask->hdr.vni[2]) &&
+ ((vxlan_mask->hdr.vni[0] != 0xFF) ||
+ (vxlan_mask->hdr.vni[1] != 0xFF) ||
+ (vxlan_mask->hdr.vni[2] != 0xFF))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vxlan_mask->hdr.vni[2] != 0xFF'
#520: FILE: drivers/net/ixgbe/ixgbe_flow.c:2492:
+ if ((vxlan_mask->hdr.vni[0] || vxlan_mask->hdr.vni[1] ||
+ vxlan_mask->hdr.vni[2]) &&
+ ((vxlan_mask->hdr.vni[0] != 0xFF) ||
+ (vxlan_mask->hdr.vni[1] != 0xFF) ||
+ (vxlan_mask->hdr.vni[2] != 0xFF))) {
total: 0 errors, 0 warnings, 573 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-25 21:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221025214410.715864-4-thomas@monjalon.net>
2022-10-25 21:45 ` |WARNING| pw119120 [PATCH 3/8] ethdev: use VXLAN protocol struct for flow matching checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).