* |WARNING| pw125052 [PATCH] [v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
@ 2023-03-12 12:39 dpdklab
0 siblings, 0 replies; 4+ messages in thread
From: dpdklab @ 2023-03-12 12:39 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/125052
_apply patch failure_
Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Sunday, March 12 2023 10:54:26
Applied on: CommitID:0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff
Apply patch set 125052 failed:
Checking patch drivers/net/sfc/sfc_dp_rx.h...
Checking patch drivers/net/sfc/sfc_ef100_rx.c...
Hunk #1 succeeded at 810 (offset -13 lines).
error: while searching for:
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
else
rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
error: patch failed: drivers/net/sfc/sfc_ef100_rx.c:889
Checking patch drivers/net/sfc/sfc_rx.c...
Hunk #1 succeeded at 1225 (offset -17 lines).
Applied patch drivers/net/sfc/sfc_dp_rx.h cleanly.
Applying patch drivers/net/sfc/sfc_ef100_rx.c with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Applied patch drivers/net/sfc/sfc_rx.c cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c (rejected hunks)
@@ -889,11 +892,18 @@ sfc_ef100_rx_qstart(struct sfc_dp_rxq *dp_rxq, unsigned int evq_read_ptr,
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
+
+ /*
+ * At the moment, this feature is used only
+ * by the representor proxy Rx queue and is
+ * essential for representor support, so if
+ * it has been requested but is unsupported,
+ * point this inconsistency out to the user.
+ */
if ((unsup_rx_prefix_fields &
- (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
- rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
- else
- rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
+ (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) &&
+ (rxq->flags & SFC_EF100_RXQ_INGRESS_MPORT))
+ return ENOTSUP;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
https://lab.dpdk.org/results/dashboard/patchsets/25698/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 4+ messages in thread
* |WARNING| pw125052 [PATCH] [v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
@ 2023-03-12 11:44 dpdklab
0 siblings, 0 replies; 4+ messages in thread
From: dpdklab @ 2023-03-12 11:44 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/125052
_apply patch failure_
Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Sunday, March 12 2023 10:54:26
Applied on: CommitID:0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff
Apply patch set 125052 failed:
Checking patch drivers/net/sfc/sfc_dp_rx.h...
Checking patch drivers/net/sfc/sfc_ef100_rx.c...
Hunk #1 succeeded at 810 (offset -13 lines).
error: while searching for:
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
else
rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
error: patch failed: drivers/net/sfc/sfc_ef100_rx.c:889
Checking patch drivers/net/sfc/sfc_rx.c...
Hunk #1 succeeded at 1225 (offset -17 lines).
Applied patch drivers/net/sfc/sfc_dp_rx.h cleanly.
Applying patch drivers/net/sfc/sfc_ef100_rx.c with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Applied patch drivers/net/sfc/sfc_rx.c cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c (rejected hunks)
@@ -889,11 +892,18 @@ sfc_ef100_rx_qstart(struct sfc_dp_rxq *dp_rxq, unsigned int evq_read_ptr,
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
+
+ /*
+ * At the moment, this feature is used only
+ * by the representor proxy Rx queue and is
+ * essential for representor support, so if
+ * it has been requested but is unsupported,
+ * point this inconsistency out to the user.
+ */
if ((unsup_rx_prefix_fields &
- (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
- rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
- else
- rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
+ (1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) &&
+ (rxq->flags & SFC_EF100_RXQ_INGRESS_MPORT))
+ return ENOTSUP;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
https://lab.dpdk.org/results/dashboard/patchsets/25698/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 4+ messages in thread
* |WARNING| pw125052 [PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
[not found] <20230312105426.6732-1-ivan.malov@arknetworks.am>
2023-03-12 10:41 ` |WARNING| pw125052 [PATCH v3] " qemudev
@ 2023-03-12 10:54 ` checkpatch
1 sibling, 0 replies; 4+ messages in thread
From: checkpatch @ 2023-03-12 10:54 UTC (permalink / raw)
To: test-report; +Cc: Ivan Malov
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/125052
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#190: FILE: drivers/net/sfc/sfc_ef100_rx.c:906:
+ return ENOTSUP;
total: 0 errors, 1 warnings, 0 checks, 47 lines checked
Ivan Malov mail differs from primary mail, please fix the commit message or update .mailmap.
^ permalink raw reply [flat|nested] 4+ messages in thread
* |WARNING| pw125052 [PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
[not found] <20230312105426.6732-1-ivan.malov@arknetworks.am>
@ 2023-03-12 10:41 ` qemudev
2023-03-12 10:54 ` checkpatch
1 sibling, 0 replies; 4+ messages in thread
From: qemudev @ 2023-03-12 10:41 UTC (permalink / raw)
To: test-report; +Cc: Ivan Malov, zhoumin
Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/125052
_apply patch failure_
Submitter: Ivan Malov <ivan.malov@arknetworks.am>
Date: Sun, 12 Mar 2023 14:54:26 +0400
DPDK git baseline: Repo:dpdk-next-net
Branch: main
CommitID: 0a18da7505ba6e2c663994b8f6f3a9ede8c70b3e
Apply patch set 125052 failed:
Checking patch drivers/net/sfc/sfc_dp_rx.h...
Checking patch drivers/net/sfc/sfc_ef100_rx.c...
Hunk #1 succeeded at 810 (offset -13 lines).
error: while searching for:
else
rxq->flags &= ~SFC_EF100_RXQ_USER_MARK;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_INGRESS_MPORT)) == 0)
rxq->flags |= SFC_EF100_RXQ_INGRESS_MPORT;
else
rxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;
if ((unsup_rx_prefix_fields &
(1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)
error: patch failed: drivers/net/sfc/sfc_ef100_rx.c:889
error: drivers/net/sfc/sfc_ef100_rx.c: patch does not apply
Checking patch drivers/net/sfc/sfc_rx.c...
Hunk #1 succeeded at 1225 (offset -17 lines).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-12 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-12 12:39 |WARNING| pw125052 [PATCH] [v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100 dpdklab
-- strict thread matches above, loose matches on Subject: below --
2023-03-12 11:44 dpdklab
[not found] <20230312105426.6732-1-ivan.malov@arknetworks.am>
2023-03-12 10:41 ` |WARNING| pw125052 [PATCH v3] " qemudev
2023-03-12 10:54 ` checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).