|WARNING| pw127978 [PATCH] [v2] node: add IPv4 reassembly node

[dpdklab@iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/127978

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Friday, June 02 2023 16:48:40 
Applied on: CommitID:abaa473297cf21cb81e5348185a7694ae2f221e7
Apply patch set 127978 failed:

Checking patch doc/guides/prog_guide/graph_lib.rst...
error: while searching for:
the packet out to a particular ethdev_tx node.
``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.

ip6_lookup
~~~~~~~~~~
This node is an intermediate node that does LPM lookup for the received

error: patch failed: doc/guides/prog_guide/graph_lib.rst:388
Checking patch lib/node/ethdev_rx.c...
Checking patch lib/node/ethdev_rx_priv.h...
Checking patch lib/node/ip4_reassembly.c...
Checking patch lib/node/ip4_reassembly_priv.h...
Checking patch lib/node/meson.build...
error: while searching for:
        'null.c',
        'pkt_cls.c',
        'pkt_drop.c',
)
headers = files('rte_node_ip4_api.h', 'rte_node_ip6_api.h', 'rte_node_eth_api.h')
# Strict-aliasing rules are violated by uint8_t[] to context size casts.
cflags += '-fno-strict-aliasing'
deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev']

error: patch failed: lib/node/meson.build:19
Checking patch lib/node/rte_node_ip4_api.h...
Checking patch lib/node/version.map...
error: while searching for:
	rte_node_eth_config;
	rte_node_ip4_route_add;
	rte_node_ip4_rewrite_add;
	rte_node_ip6_rewrite_add;
	rte_node_ip6_route_add;
	rte_node_logtype;

error: patch failed: lib/node/version.map:4
Applying patch doc/guides/prog_guide/graph_lib.rst with 1 reject...
Rejected hunk #1.
Applied patch lib/node/ethdev_rx.c cleanly.
Applied patch lib/node/ethdev_rx_priv.h cleanly.
Applied patch lib/node/ip4_reassembly.c cleanly.
Applied patch lib/node/ip4_reassembly_priv.h cleanly.
Applying patch lib/node/meson.build with 1 reject...
Rejected hunk #1.
Applied patch lib/node/rte_node_ip4_api.h cleanly.
Applying patch lib/node/version.map with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/prog_guide/graph_lib.rst b/doc/guides/prog_guide/graph_lib.rst	(rejected hunks)
@@ -388,6 +388,14 @@ to determine the L2 header to be written to the packet before sending
 the packet out to a particular ethdev_tx node.
 ``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.

+ip4_reassembly
+~~~~~~~~~~~~~~
+This node is an intermediate node that reassembles ipv4 fragmented packets,
+non-fragmented packets pass through the node un-effected. The node rewrites
+it's stream and moves it to the next node.
+The fragment table and death row table should be setup via the
+``rte_node_ip4_reassembly_configure`` API.
+
 ip6_lookup
 ~~~~~~~~~~
 This node is an intermediate node that does LPM lookup for the received
diff a/lib/node/meson.build b/lib/node/meson.build	(rejected hunks)
@@ -19,8 +19,9 @@ sources = files(
         'null.c',
         'pkt_cls.c',
         'pkt_drop.c',
+        'ip4_reassembly.c'
 )
 headers = files('rte_node_ip4_api.h', 'rte_node_ip6_api.h', 'rte_node_eth_api.h')
 # Strict-aliasing rules are violated by uint8_t[] to context size casts.
 cflags += '-fno-strict-aliasing'
-deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev']
+deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev', 'ip_frag']
diff a/lib/node/version.map b/lib/node/version.map	(rejected hunks)
@@ -4,6 +4,7 @@ EXPERIMENTAL {
 	rte_node_eth_config;
 	rte_node_ip4_route_add;
 	rte_node_ip4_rewrite_add;
+	rte_node_ip4_reassembly_configure;
 	rte_node_ip6_rewrite_add;
 	rte_node_ip6_route_add;
 	rte_node_logtype;

https://lab.dpdk.org/results/dashboard/patchsets/26515/

UNH-IOL DPDK Community Lab