From: dawid_jurek <dawid_jurek@vp.pl>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "users@dpdk.org" <users@dpdk.org>
Subject: Re: [dpdk-users] SyntaxError in setup.sh during binding ethernet device
Date: Fri, 29 Jan 2016 14:00:28 +0100 [thread overview]
Message-ID: <123374274-5dbc366f90d74852d84b7f6a9beccadf@pmq3v.m5r2.onet> (raw)
W dniu 2016-01-27 14:48:05 użytkownik Thomas Monjalon <thomas.monjalon@6wind.com> napisał:
> 2016-01-27 14:44, dawid_jurek:
> > W dniu 2016-01-19 11:54:24 użytkownik dawid_jurek <dawid_jurek@vp.pl> napisał:
> > >
> > >
> > > W dniu 2016-01-19 11:19:55 użytkownik Thomas Monjalon <thomas.monjalon@6wind.com> napisał:
> > > > Hi
> > > >
> > > > 2016-01-19 10:45, dawid_jurek:
> > > > > Hello DPDK developers,
> > > > > I experienced issue when I ran tools/setup.sh and chose option [23]: Bind Ethernet device to IGB UIO module.
> > > > > Script Output:
> > > > > File ".../dpdk/dpdk-2.2.0/tools/dpdk_nic_bind.py", line 113
> > > > > """ % locals() # replace items from local variables
> > > > > ^
> > > > > SyntaxError: invalid syntax
> > > > > It turned out that python 2.7 set as default in system was needed.
> > > > > So I added python2 to every line with dpdk_nic_bind.py call in tools/setup.sh and now it works fine.
> > > > > But the question is: is it expected behaviour? Shouldn't it be fixed by simple patch in way I did it?
> > > >
> > > > Yes a patch would be appreciated to make it python 3 friendly.
> > > > Thanks
> > > >
> > >
> > > OK. I will prepare patch for dpdk_nic_bind.py soon.
> > > Regards,
> > > Dawid
> > >
> > >
> >
> > Hello again,
> > patch for this issue was prepared and tested on Arch (Python 3 is default) and Ubuntu (Python 2 is default) distros.
> > In both cases syntax errors from dpdk_nic_bind.py disappeared and everything worked as expected.
> > Patch is very simple and in most cases just adds extra brackets to print functions.
> > Anyway please review this.
>
> It looks simple and good.
> Please could you send it on dev@dpdk.org?
> The procedure is described here:
> http://dpdk.org/dev#send
> and detailed here:
> http://dpdk.org/doc/guides/contributing/patches.html
>
> Thanks
>
Done. Available here:
http://dpdk.org/ml/archives/dev/2016-January/032148.html
Regards,
Dawid
next reply other threads:[~2016-01-29 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 13:00 dawid_jurek [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-27 13:44 dawid_jurek
2016-01-27 13:48 ` Thomas Monjalon
2016-01-19 10:54 dawid_jurek
2016-01-19 9:45 dawid_jurek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=123374274-5dbc366f90d74852d84b7f6a9beccadf@pmq3v.m5r2.onet \
--to=dawid_jurek@vp.pl \
--cc=thomas.monjalon@6wind.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).