DPDK CI discussions
 help / color / Atom feed
* [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files
@ 2020-01-06 11:15 David Marchand
  2020-01-06 22:28 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2020-01-06 11:15 UTC (permalink / raw)
  To: ci; +Cc: thomas, alialnu

Implicitly, if a file has no official maintainer / tree, it is in the
end maintained in the master branch.

This problem has been seen while looking at test failures reported on the
series https://patchwork.dpdk.org/project/dpdk/list/?series=7981.

This series mixes changes in ethdev, net/tap and EAL, and thus should go
through the main repository.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 tools/guess_git_tree.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tools/guess_git_tree.py b/tools/guess_git_tree.py
index 3c6f2da..bc63674 100755
--- a/tools/guess_git_tree.py
+++ b/tools/guess_git_tree.py
@@ -146,8 +146,11 @@ class Maintainers(object):
         tree_list = []
         for _file in files:
             _tree = self._get_tree(_file)
-            if _tree:
-                tree_list.append(_tree)
+            # No identified tree for a file means that it should go through
+            # the main repository.
+            if not _tree:
+                _tree = 'dpdk'
+            tree_list.append(_tree)
         tree = self.get_common_denominator(tree_list)
         if tree == '':
             tree = 'dpdk'
-- 
2.23.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files
  2020-01-06 11:15 [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files David Marchand
@ 2020-01-06 22:28 ` Thomas Monjalon
  2020-01-07 10:08   ` Ali Alnubani
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2020-01-06 22:28 UTC (permalink / raw)
  To: David Marchand; +Cc: ci, alialnu

06/01/2020 12:15, David Marchand:
> Implicitly, if a file has no official maintainer / tree, it is in the
> end maintained in the master branch.
> 
> This problem has been seen while looking at test failures reported on the
> series https://patchwork.dpdk.org/project/dpdk/list/?series=7981.
> 
> This series mixes changes in ethdev, net/tap and EAL, and thus should go
> through the main repository.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> -            if _tree:
> -                tree_list.append(_tree)
> +            # No identified tree for a file means that it should go through
> +            # the main repository.
> +            if not _tree:
> +                _tree = 'dpdk'
> +            tree_list.append(_tree)

It looks good to me.
This is the expected behaviour but it seems the case was
forgotten when writing this function.

Waiting for the review/ack from Ali before merging.
Thanks



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files
  2020-01-06 22:28 ` Thomas Monjalon
@ 2020-01-07 10:08   ` Ali Alnubani
  2020-01-07 18:11     ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Ali Alnubani @ 2020-01-07 10:08 UTC (permalink / raw)
  To: David Marchand; +Cc: ci, Thomas Monjalon

Hi David,
Thanks for the fix.

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, January 7, 2020 12:29 AM
> To: David Marchand <david.marchand@redhat.com>
> Cc: ci@dpdk.org; Ali Alnubani <alialnu@mellanox.com>
> Subject: Re: [PATCH] tools: fix tree detection for "unmaintained" files
> 
> 06/01/2020 12:15, David Marchand:
> > Implicitly, if a file has no official maintainer / tree, it is in the
> > end maintained in the master branch.
> >
> > This problem has been seen while looking at test failures reported on
> > the series
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D7981&amp;data
> =02%7C01%7Calialnu%40mellanox.com%7C973da6c13b094a514bc008d792f7d
> 986%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63713946551617
> 2792&amp;sdata=US%2FBhk2huEVZDPXCUTqgwKNqqMJFuL7oxd049pXKLe
> M%3D&amp;reserved=0.
> >
> > This series mixes changes in ethdev, net/tap and EAL, and thus should
> > go through the main repository.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > -            if _tree:
> > -                tree_list.append(_tree)
> > +            # No identified tree for a file means that it should go through
> > +            # the main repository.
> > +            if not _tree:
> > +                _tree = 'dpdk'
> > +            tree_list.append(_tree)
> 
> It looks good to me.
> This is the expected behaviour but it seems the case was forgotten when
> writing this function.
> 
> Waiting for the review/ack from Ali before merging.
> Thanks
> 

Acked-by: Ali Alnubani <alialnu@mellanox.com>

Thanks,
Ali

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files
  2020-01-07 10:08   ` Ali Alnubani
@ 2020-01-07 18:11     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2020-01-07 18:11 UTC (permalink / raw)
  To: David Marchand, Ali Alnubani; +Cc: ci

07/01/2020 11:08, Ali Alnubani:
> Hi David,
> Thanks for the fix.
> 
> From: Thomas Monjalon <thomas@monjalon.net>
> > 06/01/2020 12:15, David Marchand:
> > > Implicitly, if a file has no official maintainer / tree, it is in the
> > > end maintained in the master branch.
> > >
> > > This problem has been seen while looking at test failures reported on
> > > the series
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> > work.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D7981&amp;data
> > =02%7C01%7Calialnu%40mellanox.com%7C973da6c13b094a514bc008d792f7d
> > 986%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63713946551617
> > 2792&amp;sdata=US%2FBhk2huEVZDPXCUTqgwKNqqMJFuL7oxd049pXKLe
> > M%3D&amp;reserved=0.
> > >
> > > This series mixes changes in ethdev, net/tap and EAL, and thus should
> > > go through the main repository.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > -            if _tree:
> > > -                tree_list.append(_tree)
> > > +            # No identified tree for a file means that it should go through
> > > +            # the main repository.
> > > +            if not _tree:
> > > +                _tree = 'dpdk'
> > > +            tree_list.append(_tree)
> > 
> > It looks good to me.
> > This is the expected behaviour but it seems the case was forgotten when
> > writing this function.
> > 
> > Waiting for the review/ack from Ali before merging.
> > Thanks
> > 
> 
> Acked-by: Ali Alnubani <alialnu@mellanox.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 11:15 [dpdk-ci] [PATCH] tools: fix tree detection for "unmaintained" files David Marchand
2020-01-06 22:28 ` Thomas Monjalon
2020-01-07 10:08   ` Ali Alnubani
2020-01-07 18:11     ` Thomas Monjalon

DPDK CI discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox