DPDK CI discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: David Marchand <david.marchand@redhat.com>, ci@dpdk.org
Subject: Re: [dpdk-ci] [PATCH] tests: run checkpatches.sh from the DPDK directory
Date: Thu, 09 Sep 2021 16:47:35 +0200
Message-ID: <2781044.7MX9mIAz5S@thomas> (raw)
In-Reply-To: <CAJFAV8w4TpTeC8jQ1gDGpgJ5+HqwpvgDifAfo1E4RX5Za5e1rA@mail.gmail.com>

09/09/2021 10:31, David Marchand:
> On Wed, Sep 8, 2021 at 5:19 PM Ali Alnubani <alialnu@nvidia.com> wrote:
> >
> > The unit test check_release_notes was failing because it didn't
> > find some of the DPDK sources, which has been causing the CI
> > script checkpatch.sh to sometimes report false positives.
> >
> > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > ---
> >  tests/checkpatch.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > -report=$($dpdkdir/devtools/checkpatches.sh -q $email) || failed=true
> > +report=$(cd $dpdkdir && devtools/checkpatches.sh -q $email) || failed=true
> I did not find the time to investigate those false positives, thanks
> for the fix.
> Just summarizing the chat I add with Thomas.
> We could fix the checkpatches.sh script in dpdk so that it looks for
> the VERSION file relatively to the script location.
> But it would remove the possibility to call devtools/checkpatches.sh
> from a different working directory.
> Whether this is a valid usecase is unclear, but we don't know what
> other users of this script might be doing.
> Your fix is simple enough and I don't see side effect.
> Acked-by: David Marchand <david.marchand@redhat.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.

      reply	other threads:[~2021-09-09 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 15:19 Ali Alnubani
2021-09-09  8:31 ` David Marchand
2021-09-09 14:47   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2781044.7MX9mIAz5S@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git