DPDK CI discussions
 help / color / mirror / Atom feed
* check-meson.py in CI
@ 2024-05-21 21:32 Patrick Robb
  2024-05-22 10:17 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Patrick Robb @ 2024-05-21 21:32 UTC (permalink / raw)
  To: ci; +Cc: Ferruh Yigit, Aaron Conole, Ali Alnubani, Adam Hassick, Cody Cheng

Hi all,

Ferruh has requested that we start running the
./devtools/check-meson.py script in CI testing. Questions:

1. Should it be similar to how Ali runs checkpatches.sh, in that it
would have it's own patchwork context (check-meson)? I think the one
difference is that it can run just 1x/series, instead of on each
individual patch file.
2. Who should run it? It would be a simple addition for the community
lab, but if there is some compelling reason for it running alongside
checkpatch, let me know Ali.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: check-meson.py in CI
  2024-05-21 21:32 check-meson.py in CI Patrick Robb
@ 2024-05-22 10:17 ` Thomas Monjalon
  2024-05-22 15:47   ` Patrick Robb
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2024-05-22 10:17 UTC (permalink / raw)
  To: Patrick Robb
  Cc: ci, Ferruh Yigit, Aaron Conole, Ali Alnubani, Adam Hassick, Cody Cheng

Hello,

21/05/2024 23:32, Patrick Robb:
> Hi all,
> 
> Ferruh has requested that we start running the
> ./devtools/check-meson.py script in CI testing. Questions:
> 
> 1. Should it be similar to how Ali runs checkpatches.sh, in that it
> would have it's own patchwork context (check-meson)? I think the one
> difference is that it can run just 1x/series, instead of on each
> individual patch file.

checkpatches.sh runs on each patch from mail
check-meson.py does not understand patches,
so it must be run after patches are applied.
It may be nice to run it after each patch, but it is your choice.

> 2. Who should run it? It would be a simple addition for the community
> lab, but if there is some compelling reason for it running alongside
> checkpatch, let me know Ali.

We don't apply patches on dpdk.org.
It would be more convenient to integrate it inside UNH pipeline please.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: check-meson.py in CI
  2024-05-22 10:17 ` Thomas Monjalon
@ 2024-05-22 15:47   ` Patrick Robb
  0 siblings, 0 replies; 3+ messages in thread
From: Patrick Robb @ 2024-05-22 15:47 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: ci, Ferruh Yigit, Aaron Conole, Ali Alnubani, Adam Hassick, Cody Cheng

On Wed, May 22, 2024 at 6:17 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Hello,
>
> 21/05/2024 23:32, Patrick Robb:
> > Hi all,
> >
> > Ferruh has requested that we start running the
> > ./devtools/check-meson.py script in CI testing. Questions:
> >
> > 1. Should it be similar to how Ali runs checkpatches.sh, in that it
> > would have it's own patchwork context (check-meson)? I think the one
> > difference is that it can run just 1x/series, instead of on each
> > individual patch file.
>
> checkpatches.sh runs on each patch from mail
> check-meson.py does not understand patches,
> so it must be run after patches are applied.
> It may be nice to run it after each patch, but it is your choice.
>
> > 2. Who should run it? It would be a simple addition for the community
> > lab, but if there is some compelling reason for it running alongside
> > checkpatch, let me know Ali.
>
> We don't apply patches on dpdk.org.
> It would be more convenient to integrate it inside UNH pipeline please.

Okay sounds good.
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-22 15:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-21 21:32 check-meson.py in CI Patrick Robb
2024-05-22 10:17 ` Thomas Monjalon
2024-05-22 15:47   ` Patrick Robb

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).