DPDK CI discussions
 help / color / mirror / Atom feed
* [dpdk-ci] RHEL7 failures
@ 2021-10-05 19:09 Lincoln Lavoie
  2021-10-05 21:46 ` [dpdk-ci] [dpdk-dev] " Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Lincoln Lavoie @ 2021-10-05 19:09 UTC (permalink / raw)
  To: dev, Qiming Yang, Qi Zhang; +Cc: ci, Aaron Conole, dpdklab

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Hello Qiming and Qi,

The CI is picking up failures when building on RHEL7, where warnings are
being treated as errors.  This looks like something has been merged into
the mainline, as it's failing across all patches.

Here is the specific failure:

./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
  d64 = *(u64 *)&b[0];
  ^
../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
  d32 = *(u32 *)&v[0];
  ^
cc1: all warnings being treated as errors

You can download a full set of logs from here (for a failing run):
https://lab.dpdk.org/results/dashboard/patchsets/19162/

Cheers,
Lincoln

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 2600 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-05 19:09 [dpdk-ci] RHEL7 failures Lincoln Lavoie
@ 2021-10-05 21:46 ` Ferruh Yigit
  2021-10-06 12:39   ` Lincoln Lavoie
  2021-10-07  3:40   ` Zhang, Qi Z
  0 siblings, 2 replies; 16+ messages in thread
From: Ferruh Yigit @ 2021-10-05 21:46 UTC (permalink / raw)
  To: Lincoln Lavoie, dev, Qiming Yang, Qi Zhang
  Cc: ci, Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand

On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
> Hello Qiming and Qi,
> 
> The CI is picking up failures when building on RHEL7, where warnings are
> being treated as errors.  This looks like something has been merged into
> the mainline, as it's failing across all patches.
> 
> Here is the specific failure:
> 
> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
> type-punned pointer will break strict-aliasing rules
> [-Werror=strict-aliasing]
>    d64 = *(u64 *)&b[0];
>    ^
> ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
> type-punned pointer will break strict-aliasing rules
> [-Werror=strict-aliasing]
>    d32 = *(u32 *)&v[0];
>    ^
> cc1: all warnings being treated as errors
> 
> You can download a full set of logs from here (for a failing run):
> https://lab.dpdk.org/results/dashboard/patchsets/19162/
> 

Issue was reported by David, Aman sent the fix [1] and it is already merged by David [2],
it should be fixed now, can you please double check?

[1]
https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman.deep.singh@intel.com/

[2]
https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809021b154

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-05 21:46 ` [dpdk-ci] [dpdk-dev] " Ferruh Yigit
@ 2021-10-06 12:39   ` Lincoln Lavoie
  2021-10-07  3:40   ` Zhang, Qi Z
  1 sibling, 0 replies; 16+ messages in thread
From: Lincoln Lavoie @ 2021-10-06 12:39 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: dev, Qiming Yang, Qi Zhang, ci, Aaron Conole, dpdklab, Singh,
	Aman Deep, David Marchand

[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]

Hi Ferruh,

It looks like the patch does fix the issue with the warning on RHEL7.
There was a failure, but it was in unit testing, and looks unrelated.
Results are here: https://lab.dpdk.org/results/dashboard/patchsets/19171/

Cheers,
Lincoln

On Tue, Oct 5, 2021 at 5:46 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
> > Hello Qiming and Qi,
> >
> > The CI is picking up failures when building on RHEL7, where warnings are
> > being treated as errors.  This looks like something has been merged into
> > the mainline, as it's failing across all patches.
> >
> > Here is the specific failure:
> >
> > ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> > ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
> > type-punned pointer will break strict-aliasing rules
> > [-Werror=strict-aliasing]
> >    d64 = *(u64 *)&b[0];
> >    ^
> > ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> > ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
> > type-punned pointer will break strict-aliasing rules
> > [-Werror=strict-aliasing]
> >    d32 = *(u32 *)&v[0];
> >    ^
> > cc1: all warnings being treated as errors
> >
> > You can download a full set of logs from here (for a failing run):
> > https://lab.dpdk.org/results/dashboard/patchsets/19162/
> >
>
> Issue was reported by David, Aman sent the fix [1] and it is already
> merged by David [2],
> it should be fixed now, can you please double check?
>
> [1]
>
> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman.deep.singh@intel.com/
>
> [2]
>
> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809021b154
>


-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 3876 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-05 21:46 ` [dpdk-ci] [dpdk-dev] " Ferruh Yigit
  2021-10-06 12:39   ` Lincoln Lavoie
@ 2021-10-07  3:40   ` Zhang, Qi Z
  2021-10-11 14:39     ` Thinh Tran
  1 sibling, 1 reply; 16+ messages in thread
From: Zhang, Qi Z @ 2021-10-07  3:40 UTC (permalink / raw)
  To: Yigit, Ferruh, Lincoln Lavoie, dev, Yang, Qiming
  Cc: ci, Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand

Hi Ferruh, David and Aman:

	Sorry for late response due to PRC holiday.
	I have just tested the patch and there is no issue be detected for functions
	Thank you so much for the help!

Regards
Qi

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Wednesday, October 6, 2021 5:46 AM
> To: Lincoln Lavoie <lylavoie@iol.unh.edu>; dev <dev@dpdk.org>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: ci@dpdk.org; Aaron Conole <aconole@redhat.com>; dpdklab
> <dpdklab@iol.unh.edu>; Singh, Aman Deep <aman.deep.singh@intel.com>;
> David Marchand <david.marchand@redhat.com>
> Subject: Re: [dpdk-dev] RHEL7 failures
> 
> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
> > Hello Qiming and Qi,
> >
> > The CI is picking up failures when building on RHEL7, where warnings
> > are being treated as errors.  This looks like something has been
> > merged into the mainline, as it's failing across all patches.
> >
> > Here is the specific failure:
> >
> > ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> > ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
> > type-punned pointer will break strict-aliasing rules
> > [-Werror=strict-aliasing]
> >    d64 = *(u64 *)&b[0];
> >    ^
> > ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> > ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
> > type-punned pointer will break strict-aliasing rules
> > [-Werror=strict-aliasing]
> >    d32 = *(u32 *)&v[0];
> >    ^
> > cc1: all warnings being treated as errors
> >
> > You can download a full set of logs from here (for a failing run):
> > https://lab.dpdk.org/results/dashboard/patchsets/19162/
> >
> 
> Issue was reported by David, Aman sent the fix [1] and it is already merged by
> David [2], it should be fixed now, can you please double check?
> 
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
> .deep.singh@intel.com/
> 
> [2]
> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
> 021b154

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-07  3:40   ` Zhang, Qi Z
@ 2021-10-11 14:39     ` Thinh Tran
  2021-10-11 14:42       ` Lincoln Lavoie
  0 siblings, 1 reply; 16+ messages in thread
From: Thinh Tran @ 2021-10-11 14:39 UTC (permalink / raw)
  To: Zhang, Qi Z, Yigit, Ferruh, Lincoln Lavoie, dev, Yang, Qiming
  Cc: ci, Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand


Hi,
I'm wondering how or when the CI would re-pick up the patches those were 
failed due to this issue?

Regards,
Thinh Tran

On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
> Hi Ferruh, David and Aman:
> 
> 	Sorry for late response due to PRC holiday.
> 	I have just tested the patch and there is no issue be detected for functions
> 	Thank you so much for the help!
> 
> Regards
> Qi
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Wednesday, October 6, 2021 5:46 AM
>> To: Lincoln Lavoie <lylavoie@iol.unh.edu>; dev <dev@dpdk.org>; Yang, Qiming
>> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: ci@dpdk.org; Aaron Conole <aconole@redhat.com>; dpdklab
>> <dpdklab@iol.unh.edu>; Singh, Aman Deep <aman.deep.singh@intel.com>;
>> David Marchand <david.marchand@redhat.com>
>> Subject: Re: [dpdk-dev] RHEL7 failures
>>
>> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>>> Hello Qiming and Qi,
>>>
>>> The CI is picking up failures when building on RHEL7, where warnings
>>> are being treated as errors.  This looks like something has been
>>> merged into the mainline, as it's failing across all patches.
>>>
>>> Here is the specific failure:
>>>
>>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
>>> type-punned pointer will break strict-aliasing rules
>>> [-Werror=strict-aliasing]
>>>     d64 = *(u64 *)&b[0];
>>>     ^
>>> ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
>>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
>>> type-punned pointer will break strict-aliasing rules
>>> [-Werror=strict-aliasing]
>>>     d32 = *(u32 *)&v[0];
>>>     ^
>>> cc1: all warnings being treated as errors
>>>
>>> You can download a full set of logs from here (for a failing run):
>>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
>>>
>>
>> Issue was reported by David, Aman sent the fix [1] and it is already merged by
>> David [2], it should be fixed now, can you please double check?
>>
>> [1]
>> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>> .deep.singh@intel.com/
>>
>> [2]
>> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>> 021b154

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-11 14:39     ` Thinh Tran
@ 2021-10-11 14:42       ` Lincoln Lavoie
  2021-10-11 16:39         ` Thinh Tran
  0 siblings, 1 reply; 16+ messages in thread
From: Lincoln Lavoie @ 2021-10-11 14:42 UTC (permalink / raw)
  To: Thinh Tran
  Cc: Zhang, Qi Z, Yigit, Ferruh, dev, Yang, Qiming, ci, Aaron Conole,
	dpdklab, Singh, Aman Deep, David Marchand

[-- Attachment #1: Type: text/plain, Size: 3025 bytes --]

Hi Thinh,

The CI won't automatically go back and retest failures after a patch was
applied.  This is a corner case, where a bad change was merged and affected
all patches downstream of that merge.  We can retrigger specific patches,
just let us know the patch number or the URI of the patch(es).

Cheers,
Lincoln

On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <thinhtr@linux.vnet.ibm.com>
wrote:

>
> Hi,
> I'm wondering how or when the CI would re-pick up the patches those were
> failed due to this issue?
>
> Regards,
> Thinh Tran
>
> On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
> > Hi Ferruh, David and Aman:
> >
> >       Sorry for late response due to PRC holiday.
> >       I have just tested the patch and there is no issue be detected for
> functions
> >       Thank you so much for the help!
> >
> > Regards
> > Qi
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> >> Sent: Wednesday, October 6, 2021 5:46 AM
> >> To: Lincoln Lavoie <lylavoie@iol.unh.edu>; dev <dev@dpdk.org>; Yang,
> Qiming
> >> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> >> Cc: ci@dpdk.org; Aaron Conole <aconole@redhat.com>; dpdklab
> >> <dpdklab@iol.unh.edu>; Singh, Aman Deep <aman.deep.singh@intel.com>;
> >> David Marchand <david.marchand@redhat.com>
> >> Subject: Re: [dpdk-dev] RHEL7 failures
> >>
> >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
> >>> Hello Qiming and Qi,
> >>>
> >>> The CI is picking up failures when building on RHEL7, where warnings
> >>> are being treated as errors.  This looks like something has been
> >>> merged into the mainline, as it's failing across all patches.
> >>>
> >>> Here is the specific failure:
> >>>
> >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
> >>> type-punned pointer will break strict-aliasing rules
> >>> [-Werror=strict-aliasing]
> >>>     d64 = *(u64 *)&b[0];
> >>>     ^
> >>> ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
> >>> type-punned pointer will break strict-aliasing rules
> >>> [-Werror=strict-aliasing]
> >>>     d32 = *(u32 *)&v[0];
> >>>     ^
> >>> cc1: all warnings being treated as errors
> >>>
> >>> You can download a full set of logs from here (for a failing run):
> >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
> >>>
> >>
> >> Issue was reported by David, Aman sent the fix [1] and it is already
> merged by
> >> David [2], it should be fixed now, can you please double check?
> >>
> >> [1]
> >> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
> >> .deep.singh@intel.com/
> >>
> >> [2]
> >> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
> >> 021b154
>


-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 5958 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-11 14:42       ` Lincoln Lavoie
@ 2021-10-11 16:39         ` Thinh Tran
  2021-10-11 17:17           ` Brandon Lo
  0 siblings, 1 reply; 16+ messages in thread
From: Thinh Tran @ 2021-10-11 16:39 UTC (permalink / raw)
  To: Lincoln Lavoie
  Cc: Zhang, Qi Z, Yigit, Ferruh, dev, Yang, Qiming, ci, Aaron Conole,
	dpdklab, Singh, Aman Deep, David Marchand

Hi Linconln,

I have this patch set 100042  - build/ppc: enable build support for Power10
https://patches.dpdk.org/patch/100042

Thanks,
Thinh Tran



On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
> Hi Thinh, The CI won't automatically go back and retest failures after a 
> patch was applied.  This is a corner case, where a bad change was merged 
> and affected all patches downstream of that merge.  We can retrigger 
> specific patches, just ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
> ZjQcmQRYFpfptBannerEnd
> Hi Thinh,
> 
> The CI won't automatically go back and retest failures after a patch was 
> applied.  This is a corner case, where a bad change was merged and 
> affected all patches downstream of that merge.  We can retrigger 
> specific patches, just let us know the patch number or the URI of the 
> patch(es).
> 
> Cheers,
> Lincoln
> 
> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <thinhtr@linux.vnet.ibm.com 
> <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
> 
> 
>     Hi,
>     I'm wondering how or when the CI would re-pick up the patches those
>     were
>     failed due to this issue?
> 
>     Regards,
>     Thinh Tran
> 
>     On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
>      > Hi Ferruh, David and Aman:
>      >
>      >       Sorry for late response due to PRC holiday.
>      >       I have just tested the patch and there is no issue be
>     detected for functions
>      >       Thank you so much for the help!
>      >
>      > Regards
>      > Qi
>      >
>      >> -----Original Message-----
>      >> From: Yigit, Ferruh <ferruh.yigit@intel.com
>     <mailto:ferruh.yigit@intel.com>>
>      >> Sent: Wednesday, October 6, 2021 5:46 AM
>      >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
>     <mailto:lylavoie@iol.unh.edu>>; dev <dev@dpdk.org
>     <mailto:dev@dpdk.org>>; Yang, Qiming
>      >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>>; Zhang,
>     Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>
>      >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>; Aaron Conole
>     <aconole@redhat.com <mailto:aconole@redhat.com>>; dpdklab
>      >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>; Singh, Aman
>     Deep <aman.deep.singh@intel.com <mailto:aman.deep.singh@intel.com>>;
>      >> David Marchand <david.marchand@redhat.com
>     <mailto:david.marchand@redhat.com>>
>      >> Subject: Re: [dpdk-dev] RHEL7 failures
>      >>
>      >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>      >>> Hello Qiming and Qi,
>      >>>
>      >>> The CI is picking up failures when building on RHEL7, where
>     warnings
>      >>> are being treated as errors.  This looks like something has been
>      >>> merged into the mainline, as it's failing across all patches.
>      >>>
>      >>> Here is the specific failure:
>      >>>
>      >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>      >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
>      >>> type-punned pointer will break strict-aliasing rules
>      >>> [-Werror=strict-aliasing]
>      >>>     d64 = *(u64 *)&b[0];
>      >>>     ^
>      >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
>     '_reg_bit_sel':
>      >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
>      >>> type-punned pointer will break strict-aliasing rules
>      >>> [-Werror=strict-aliasing]
>      >>>     d32 = *(u32 *)&v[0];
>      >>>     ^
>      >>> cc1: all warnings being treated as errors
>      >>>
>      >>> You can download a full set of logs from here (for a failing run):
>      >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
>     <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
>      >>>
>      >>
>      >> Issue was reported by David, Aman sent the fix [1] and it is
>     already merged by
>      >> David [2], it should be fixed now, can you please double check?
>      >>
>      >> [1]
>      >>
>     https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>     <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
>      >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
>      >>
>      >> [2]
>      >>
>     https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>     <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
>      >> 021b154
> 
> 
> 
> -- 
> *Lincoln Lavoie*
> Principal Engineer, Broadband Technologies
> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> https://www.iol.unh.edu <https://www.iol.unh.edu>
> +1-603-674-2755 (m)
> <https://www.iol.unh.edu>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-11 16:39         ` Thinh Tran
@ 2021-10-11 17:17           ` Brandon Lo
  2021-10-11 22:45             ` Thinh Tran
  0 siblings, 1 reply; 16+ messages in thread
From: Brandon Lo @ 2021-10-11 17:17 UTC (permalink / raw)
  To: Thinh Tran
  Cc: Lincoln Lavoie, Zhang, Qi Z, Yigit, Ferruh, dev, Yang, Qiming,
	ci, Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand

Hi Thinh,

I have started a rerun of the patch
https://patches.dpdk.org/patch/100042 (patchset
https://lab.dpdk.org/results/dashboard/patchsets/19066/).
You should see the new results reported over email soon.

Thanks,
Brandon


On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>
> Hi Linconln,
>
> I have this patch set 100042  - build/ppc: enable build support for Power10
> https://patches.dpdk.org/patch/100042
>
> Thanks,
> Thinh Tran
>
>
>
> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
> > Hi Thinh, The CI won't automatically go back and retest failures after a
> > patch was applied.  This is a corner case, where a bad change was merged
> > and affected all patches downstream of that merge.  We can retrigger
> > specific patches, just ZjQcmQRYFpfptBannerStart
> > This Message Is From an External Sender
> > This message came from outside your organization.
> > ZjQcmQRYFpfptBannerEnd
> > Hi Thinh,
> >
> > The CI won't automatically go back and retest failures after a patch was
> > applied.  This is a corner case, where a bad change was merged and
> > affected all patches downstream of that merge.  We can retrigger
> > specific patches, just let us know the patch number or the URI of the
> > patch(es).
> >
> > Cheers,
> > Lincoln
> >
> > On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <thinhtr@linux.vnet.ibm.com
> > <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
> >
> >
> >     Hi,
> >     I'm wondering how or when the CI would re-pick up the patches those
> >     were
> >     failed due to this issue?
> >
> >     Regards,
> >     Thinh Tran
> >
> >     On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
> >      > Hi Ferruh, David and Aman:
> >      >
> >      >       Sorry for late response due to PRC holiday.
> >      >       I have just tested the patch and there is no issue be
> >     detected for functions
> >      >       Thank you so much for the help!
> >      >
> >      > Regards
> >      > Qi
> >      >
> >      >> -----Original Message-----
> >      >> From: Yigit, Ferruh <ferruh.yigit@intel.com
> >     <mailto:ferruh.yigit@intel.com>>
> >      >> Sent: Wednesday, October 6, 2021 5:46 AM
> >      >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
> >     <mailto:lylavoie@iol.unh.edu>>; dev <dev@dpdk.org
> >     <mailto:dev@dpdk.org>>; Yang, Qiming
> >      >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>>; Zhang,
> >     Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>
> >      >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>; Aaron Conole
> >     <aconole@redhat.com <mailto:aconole@redhat.com>>; dpdklab
> >      >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>; Singh, Aman
> >     Deep <aman.deep.singh@intel.com <mailto:aman.deep.singh@intel.com>>;
> >      >> David Marchand <david.marchand@redhat.com
> >     <mailto:david.marchand@redhat.com>>
> >      >> Subject: Re: [dpdk-dev] RHEL7 failures
> >      >>
> >      >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
> >      >>> Hello Qiming and Qi,
> >      >>>
> >      >>> The CI is picking up failures when building on RHEL7, where
> >     warnings
> >      >>> are being treated as errors.  This looks like something has been
> >      >>> merged into the mainline, as it's failing across all patches.
> >      >>>
> >      >>> Here is the specific failure:
> >      >>>
> >      >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> >      >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
> >      >>> type-punned pointer will break strict-aliasing rules
> >      >>> [-Werror=strict-aliasing]
> >      >>>     d64 = *(u64 *)&b[0];
> >      >>>     ^
> >      >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
> >     '_reg_bit_sel':
> >      >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
> >      >>> type-punned pointer will break strict-aliasing rules
> >      >>> [-Werror=strict-aliasing]
> >      >>>     d32 = *(u32 *)&v[0];
> >      >>>     ^
> >      >>> cc1: all warnings being treated as errors
> >      >>>
> >      >>> You can download a full set of logs from here (for a failing run):
> >      >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
> >     <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
> >      >>>
> >      >>
> >      >> Issue was reported by David, Aman sent the fix [1] and it is
> >     already merged by
> >      >> David [2], it should be fixed now, can you please double check?
> >      >>
> >      >> [1]
> >      >>
> >     https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
> >     <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
> >      >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
> >      >>
> >      >> [2]
> >      >>
> >     https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
> >     <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
> >      >> 021b154
> >
> >
> >
> > --
> > *Lincoln Lavoie*
> > Principal Engineer, Broadband Technologies
> > 21 Madbury Rd., Ste. 100, Durham, NH 03824
> > lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> > https://www.iol.unh.edu <https://www.iol.unh.edu>
> > +1-603-674-2755 (m)
> > <https://www.iol.unh.edu>



-- 
Brandon Lo
UNH InterOperability Laboratory
21 Madbury Rd, Suite 100, Durham, NH 03824
blo@iol.unh.edu
www.iol.unh.edu

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-11 17:17           ` Brandon Lo
@ 2021-10-11 22:45             ` Thinh Tran
  2021-10-12  0:57               ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: Thinh Tran @ 2021-10-11 22:45 UTC (permalink / raw)
  To: Brandon Lo
  Cc: Lincoln Lavoie, Zhang, Qi Z, Yigit, Ferruh, dev, Yang, Qiming,
	ci, Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand

Hi Brandon,

Does the rebuild have the fix for RHEL 7? Please check.

I just checked the build status, it still hits the same failure on RHEL 7:

[1502/2903] Compiling C object 
drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base 
-I../drivers/net/ice/base -I. -I.. -Iconfig -I../config 
-Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include 
-I../lib/eal/linux/include -Ilib/eal/x86/include 
-I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal 
-I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics 
-Ilib/telemetry -I../lib/telemetry -pipe -D_FILE_OFFSET_BITS=64 -Wall 
-Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual 
-Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security 
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs 
-Wold-style-definition -Wpointer-arith -Wsign-compare 
-Wstrict-prototypes -Wundef -Wwrite-strings 
-Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native 
-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-unused-value 
-Wno-unused-but-set-variable -Wno-unused-variable -Wno-unused-parameter 
-MD -MQ drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF 
drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o 
drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c 
../drivers/net/ice/base/ice_parser_rt.c
../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing 
type-punned pointer will break strict-aliasing rules 
[-Werror=strict-aliasing]
   d64 = *(u64 *)&b[0];
   ^
../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing 
type-punned pointer will break strict-aliasing rules 
[-Werror=strict-aliasing]
   d32 = *(u32 *)&v[0];
   ^
cc1: all warnings being treated as errors

Thanks,
Thinh Tran

On 10/11/2021 12:17 PM, Brandon Lo wrote:
> Hi Thinh,
> 
> I have started a rerun of the patch
> https://patches.dpdk.org/patch/100042 (patchset
> https://lab.dpdk.org/results/dashboard/patchsets/19066/).
> You should see the new results reported over email soon.
> 
> Thanks,
> Brandon
> 
> 
> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>>
>> Hi Linconln,
>>
>> I have this patch set 100042  - build/ppc: enable build support for Power10
>> https://patches.dpdk.org/patch/100042
>>
>> Thanks,
>> Thinh Tran
>>
>>
>>
>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
>>> Hi Thinh, The CI won't automatically go back and retest failures after a
>>> patch was applied.  This is a corner case, where a bad change was merged
>>> and affected all patches downstream of that merge.  We can retrigger
>>> specific patches, just ZjQcmQRYFpfptBannerStart
>>> This Message Is From an External Sender
>>> This message came from outside your organization.
>>> ZjQcmQRYFpfptBannerEnd
>>> Hi Thinh,
>>>
>>> The CI won't automatically go back and retest failures after a patch was
>>> applied.  This is a corner case, where a bad change was merged and
>>> affected all patches downstream of that merge.  We can retrigger
>>> specific patches, just let us know the patch number or the URI of the
>>> patch(es).
>>>
>>> Cheers,
>>> Lincoln
>>>
>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <thinhtr@linux.vnet.ibm.com
>>> <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
>>>
>>>
>>>      Hi,
>>>      I'm wondering how or when the CI would re-pick up the patches those
>>>      were
>>>      failed due to this issue?
>>>
>>>      Regards,
>>>      Thinh Tran
>>>
>>>      On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
>>>       > Hi Ferruh, David and Aman:
>>>       >
>>>       >       Sorry for late response due to PRC holiday.
>>>       >       I have just tested the patch and there is no issue be
>>>      detected for functions
>>>       >       Thank you so much for the help!
>>>       >
>>>       > Regards
>>>       > Qi
>>>       >
>>>       >> -----Original Message-----
>>>       >> From: Yigit, Ferruh <ferruh.yigit@intel.com
>>>      <mailto:ferruh.yigit@intel.com>>
>>>       >> Sent: Wednesday, October 6, 2021 5:46 AM
>>>       >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
>>>      <mailto:lylavoie@iol.unh.edu>>; dev <dev@dpdk.org
>>>      <mailto:dev@dpdk.org>>; Yang, Qiming
>>>       >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>>; Zhang,
>>>      Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>
>>>       >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>; Aaron Conole
>>>      <aconole@redhat.com <mailto:aconole@redhat.com>>; dpdklab
>>>       >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>; Singh, Aman
>>>      Deep <aman.deep.singh@intel.com <mailto:aman.deep.singh@intel.com>>;
>>>       >> David Marchand <david.marchand@redhat.com
>>>      <mailto:david.marchand@redhat.com>>
>>>       >> Subject: Re: [dpdk-dev] RHEL7 failures
>>>       >>
>>>       >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>>>       >>> Hello Qiming and Qi,
>>>       >>>
>>>       >>> The CI is picking up failures when building on RHEL7, where
>>>      warnings
>>>       >>> are being treated as errors.  This looks like something has been
>>>       >>> merged into the mainline, as it's failing across all patches.
>>>       >>>
>>>       >>> Here is the specific failure:
>>>       >>>
>>>       >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
>>>       >>> type-punned pointer will break strict-aliasing rules
>>>       >>> [-Werror=strict-aliasing]
>>>       >>>     d64 = *(u64 *)&b[0];
>>>       >>>     ^
>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
>>>      '_reg_bit_sel':
>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
>>>       >>> type-punned pointer will break strict-aliasing rules
>>>       >>> [-Werror=strict-aliasing]
>>>       >>>     d32 = *(u32 *)&v[0];
>>>       >>>     ^
>>>       >>> cc1: all warnings being treated as errors
>>>       >>>
>>>       >>> You can download a full set of logs from here (for a failing run):
>>>       >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
>>>      <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
>>>       >>>
>>>       >>
>>>       >> Issue was reported by David, Aman sent the fix [1] and it is
>>>      already merged by
>>>       >> David [2], it should be fixed now, can you please double check?
>>>       >>
>>>       >> [1]
>>>       >>
>>>      https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>>>      <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
>>>       >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
>>>       >>
>>>       >> [2]
>>>       >>
>>>      https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>>>      <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
>>>       >> 021b154
>>>
>>>
>>>
>>> --
>>> *Lincoln Lavoie*
>>> Principal Engineer, Broadband Technologies
>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824
>>> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
>>> https://www.iol.unh.edu <https://www.iol.unh.edu>
>>> +1-603-674-2755 (m)
>>> <https://www.iol.unh.edu>
> 
> 
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-11 22:45             ` Thinh Tran
@ 2021-10-12  0:57               ` Ferruh Yigit
  2021-10-12 12:39                 ` Lincoln Lavoie
  0 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2021-10-12  0:57 UTC (permalink / raw)
  To: Thinh Tran, Brandon Lo
  Cc: Lincoln Lavoie, Zhang, Qi Z, dev, Yang, Qiming, ci, Aaron Conole,
	dpdklab, Singh, Aman Deep, David Marchand

On 10/11/2021 11:45 PM, Thinh Tran wrote:
> Hi Brandon,
> 
> Does the rebuild have the fix for RHEL 7? Please check.
> 
> I just checked the build status, it still hits the same failure on RHEL 7:

https://lab.dpdk.org/results/dashboard/patchsets/19066/

Your patch still applied on 'dpdk (086d426406bd3f6fac96a15bbd871c7fe714bc2d)',
which doesn't have the fix.
It seems 'Rebuild' still using the same commit from dpdk.

Submitting a new version of the patch can be easiest solution to
run CI on correct version.

> 
> [1502/2903] Compiling C object drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
> FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
> ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base -I../drivers/net/ice/base -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-unused-value -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unused-parameter -MD -MQ 
> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c ../drivers/net/ice/base/ice_parser_rt.c
> ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
>    d64 = *(u64 *)&b[0];
>    ^
> ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
>    d32 = *(u32 *)&v[0];
>    ^
> cc1: all warnings being treated as errors
> 
> Thanks,
> Thinh Tran
> 
> On 10/11/2021 12:17 PM, Brandon Lo wrote:
>> Hi Thinh,
>>
>> I have started a rerun of the patch
>> https://patches.dpdk.org/patch/100042 (patchset
>> https://lab.dpdk.org/results/dashboard/patchsets/19066/).
>> You should see the new results reported over email soon.
>>
>> Thanks,
>> Brandon
>>
>>
>> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>>>
>>> Hi Linconln,
>>>
>>> I have this patch set 100042  - build/ppc: enable build support for Power10
>>> https://patches.dpdk.org/patch/100042
>>>
>>> Thanks,
>>> Thinh Tran
>>>
>>>
>>>
>>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
>>>> Hi Thinh, The CI won't automatically go back and retest failures after a
>>>> patch was applied.  This is a corner case, where a bad change was merged
>>>> and affected all patches downstream of that merge.  We can retrigger
>>>> specific patches, just ZjQcmQRYFpfptBannerStart
>>>> This Message Is From an External Sender
>>>> This message came from outside your organization.
>>>> ZjQcmQRYFpfptBannerEnd
>>>> Hi Thinh,
>>>>
>>>> The CI won't automatically go back and retest failures after a patch was
>>>> applied.  This is a corner case, where a bad change was merged and
>>>> affected all patches downstream of that merge.  We can retrigger
>>>> specific patches, just let us know the patch number or the URI of the
>>>> patch(es).
>>>>
>>>> Cheers,
>>>> Lincoln
>>>>
>>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <thinhtr@linux.vnet.ibm.com
>>>> <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
>>>>
>>>>
>>>>      Hi,
>>>>      I'm wondering how or when the CI would re-pick up the patches those
>>>>      were
>>>>      failed due to this issue?
>>>>
>>>>      Regards,
>>>>      Thinh Tran
>>>>
>>>>      On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
>>>>       > Hi Ferruh, David and Aman:
>>>>       >
>>>>       >       Sorry for late response due to PRC holiday.
>>>>       >       I have just tested the patch and there is no issue be
>>>>      detected for functions
>>>>       >       Thank you so much for the help!
>>>>       >
>>>>       > Regards
>>>>       > Qi
>>>>       >
>>>>       >> -----Original Message-----
>>>>       >> From: Yigit, Ferruh <ferruh.yigit@intel.com
>>>>      <mailto:ferruh.yigit@intel.com>>
>>>>       >> Sent: Wednesday, October 6, 2021 5:46 AM
>>>>       >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
>>>>      <mailto:lylavoie@iol.unh.edu>>; dev <dev@dpdk.org
>>>>      <mailto:dev@dpdk.org>>; Yang, Qiming
>>>>       >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>>; Zhang,
>>>>      Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>
>>>>       >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>; Aaron Conole
>>>>      <aconole@redhat.com <mailto:aconole@redhat.com>>; dpdklab
>>>>       >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>; Singh, Aman
>>>>      Deep <aman.deep.singh@intel.com <mailto:aman.deep.singh@intel.com>>;
>>>>       >> David Marchand <david.marchand@redhat.com
>>>>      <mailto:david.marchand@redhat.com>>
>>>>       >> Subject: Re: [dpdk-dev] RHEL7 failures
>>>>       >>
>>>>       >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>>>>       >>> Hello Qiming and Qi,
>>>>       >>>
>>>>       >>> The CI is picking up failures when building on RHEL7, where
>>>>      warnings
>>>>       >>> are being treated as errors.  This looks like something has been
>>>>       >>> merged into the mainline, as it's failing across all patches.
>>>>       >>>
>>>>       >>> Here is the specific failure:
>>>>       >>>
>>>>       >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
>>>>       >>> type-punned pointer will break strict-aliasing rules
>>>>       >>> [-Werror=strict-aliasing]
>>>>       >>>     d64 = *(u64 *)&b[0];
>>>>       >>>     ^
>>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
>>>>      '_reg_bit_sel':
>>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
>>>>       >>> type-punned pointer will break strict-aliasing rules
>>>>       >>> [-Werror=strict-aliasing]
>>>>       >>>     d32 = *(u32 *)&v[0];
>>>>       >>>     ^
>>>>       >>> cc1: all warnings being treated as errors
>>>>       >>>
>>>>       >>> You can download a full set of logs from here (for a failing run):
>>>>       >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
>>>>      <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
>>>>       >>>
>>>>       >>
>>>>       >> Issue was reported by David, Aman sent the fix [1] and it is
>>>>      already merged by
>>>>       >> David [2], it should be fixed now, can you please double check?
>>>>       >>
>>>>       >> [1]
>>>>       >>
>>>>      https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>>>>      <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
>>>>       >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
>>>>       >>
>>>>       >> [2]
>>>>       >>
>>>>      https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>>>>      <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
>>>>       >> 021b154
>>>>
>>>>
>>>>
>>>> -- 
>>>> *Lincoln Lavoie*
>>>> Principal Engineer, Broadband Technologies
>>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824
>>>> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
>>>> https://www.iol.unh.edu <https://www.iol.unh.edu>
>>>> +1-603-674-2755 (m)
>>>> <https://www.iol.unh.edu>
>>
>>
>>


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-12  0:57               ` Ferruh Yigit
@ 2021-10-12 12:39                 ` Lincoln Lavoie
  2021-10-12 13:32                   ` Ferruh Yigit
                                     ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Lincoln Lavoie @ 2021-10-12 12:39 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: Thinh Tran, Brandon Lo, Zhang, Qi Z, dev, Yang, Qiming, ci,
	Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand

[-- Attachment #1: Type: text/plain, Size: 9207 bytes --]

Ferruh and Thinh,

Yes, that will also work and should trigger the rebuild to the tip of the
current git repo / branch.  Apologizes for forgetting that behavior is
built into the runner.

All,

That raises the question, for the planned work to allow triggering rebuilds
/ reruns through patchwork, what is the expected behavior, rerun exactly
what was run before, or move to the current pointer (assuming it's moved
on) and build/run on top of that?  What best aligns with everyone's
expectations, so we don't get confusion, etc.?

Cheers,
Lincoln

On Mon, Oct 11, 2021 at 8:58 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 10/11/2021 11:45 PM, Thinh Tran wrote:
> > Hi Brandon,
> >
> > Does the rebuild have the fix for RHEL 7? Please check.
> >
> > I just checked the build status, it still hits the same failure on RHEL
> 7:
>
> https://lab.dpdk.org/results/dashboard/patchsets/19066/
>
> Your patch still applied on 'dpdk
> (086d426406bd3f6fac96a15bbd871c7fe714bc2d)',
> which doesn't have the fix.
> It seems 'Rebuild' still using the same commit from dpdk.
>
> Submitting a new version of the patch can be easiest solution to
> run CI on correct version.
>
> >
> > [1502/2903] Compiling C object
> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
> > FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
> > ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base
> -I../drivers/net/ice/base -I. -I.. -Iconfig -I../config -Ilib/eal/include
> -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include
> -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
> -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
> -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -pipe
> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include
> rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral
> -Wformat-security -Wmissing-declarations -Wmissing-prototypes
> -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare
> -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers
> -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API
> -DALLOW_INTERNAL_API -Wno-unused-value -Wno-unused-but-set-variable
> -Wno-unused-variable -Wno-unused-parameter -MD -MQ
> > drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF
> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o
> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c
> ../drivers/net/ice/base/ice_parser_rt.c
> > ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> > ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
> type-punned pointer will break strict-aliasing rules
> [-Werror=strict-aliasing]
> >    d64 = *(u64 *)&b[0];
> >    ^
> > ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> > ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
> type-punned pointer will break strict-aliasing rules
> [-Werror=strict-aliasing]
> >    d32 = *(u32 *)&v[0];
> >    ^
> > cc1: all warnings being treated as errors
> >
> > Thanks,
> > Thinh Tran
> >
> > On 10/11/2021 12:17 PM, Brandon Lo wrote:
> >> Hi Thinh,
> >>
> >> I have started a rerun of the patch
> >> https://patches.dpdk.org/patch/100042 (patchset
> >> https://lab.dpdk.org/results/dashboard/patchsets/19066/).
> >> You should see the new results reported over email soon.
> >>
> >> Thanks,
> >> Brandon
> >>
> >>
> >> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <thinhtr@linux.vnet.ibm.com>
> wrote:
> >>>
> >>> Hi Linconln,
> >>>
> >>> I have this patch set 100042  - build/ppc: enable build support for
> Power10
> >>> https://patches.dpdk.org/patch/100042
> >>>
> >>> Thanks,
> >>> Thinh Tran
> >>>
> >>>
> >>>
> >>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
> >>>> Hi Thinh, The CI won't automatically go back and retest failures
> after a
> >>>> patch was applied.  This is a corner case, where a bad change was
> merged
> >>>> and affected all patches downstream of that merge.  We can retrigger
> >>>> specific patches, just ZjQcmQRYFpfptBannerStart
> >>>> This Message Is From an External Sender
> >>>> This message came from outside your organization.
> >>>> ZjQcmQRYFpfptBannerEnd
> >>>> Hi Thinh,
> >>>>
> >>>> The CI won't automatically go back and retest failures after a patch
> was
> >>>> applied.  This is a corner case, where a bad change was merged and
> >>>> affected all patches downstream of that merge.  We can retrigger
> >>>> specific patches, just let us know the patch number or the URI of the
> >>>> patch(es).
> >>>>
> >>>> Cheers,
> >>>> Lincoln
> >>>>
> >>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <
> thinhtr@linux.vnet.ibm.com
> >>>> <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
> >>>>
> >>>>
> >>>>      Hi,
> >>>>      I'm wondering how or when the CI would re-pick up the patches
> those
> >>>>      were
> >>>>      failed due to this issue?
> >>>>
> >>>>      Regards,
> >>>>      Thinh Tran
> >>>>
> >>>>      On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
> >>>>       > Hi Ferruh, David and Aman:
> >>>>       >
> >>>>       >       Sorry for late response due to PRC holiday.
> >>>>       >       I have just tested the patch and there is no issue be
> >>>>      detected for functions
> >>>>       >       Thank you so much for the help!
> >>>>       >
> >>>>       > Regards
> >>>>       > Qi
> >>>>       >
> >>>>       >> -----Original Message-----
> >>>>       >> From: Yigit, Ferruh <ferruh.yigit@intel.com
> >>>>      <mailto:ferruh.yigit@intel.com>>
> >>>>       >> Sent: Wednesday, October 6, 2021 5:46 AM
> >>>>       >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
> >>>>      <mailto:lylavoie@iol.unh.edu>>; dev <dev@dpdk.org
> >>>>      <mailto:dev@dpdk.org>>; Yang, Qiming
> >>>>       >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>>;
> Zhang,
> >>>>      Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>
> >>>>       >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>; Aaron Conole
> >>>>      <aconole@redhat.com <mailto:aconole@redhat.com>>; dpdklab
> >>>>       >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>; Singh,
> Aman
> >>>>      Deep <aman.deep.singh@intel.com <mailto:
> aman.deep.singh@intel.com>>;
> >>>>       >> David Marchand <david.marchand@redhat.com
> >>>>      <mailto:david.marchand@redhat.com>>
> >>>>       >> Subject: Re: [dpdk-dev] RHEL7 failures
> >>>>       >>
> >>>>       >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
> >>>>       >>> Hello Qiming and Qi,
> >>>>       >>>
> >>>>       >>> The CI is picking up failures when building on RHEL7, where
> >>>>      warnings
> >>>>       >>> are being treated as errors.  This looks like something has
> been
> >>>>       >>> merged into the mainline, as it's failing across all
> patches.
> >>>>       >>>
> >>>>       >>> Here is the specific failure:
> >>>>       >>>
> >>>>       >>> ./drivers/net/ice/base/ice_parser_rt.c: In function
> '_hv_bit_sel':
> >>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error:
> dereferencing
> >>>>       >>> type-punned pointer will break strict-aliasing rules
> >>>>       >>> [-Werror=strict-aliasing]
> >>>>       >>>     d64 = *(u64 *)&b[0];
> >>>>       >>>     ^
> >>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
> >>>>      '_reg_bit_sel':
> >>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error:
> dereferencing
> >>>>       >>> type-punned pointer will break strict-aliasing rules
> >>>>       >>> [-Werror=strict-aliasing]
> >>>>       >>>     d32 = *(u32 *)&v[0];
> >>>>       >>>     ^
> >>>>       >>> cc1: all warnings being treated as errors
> >>>>       >>>
> >>>>       >>> You can download a full set of logs from here (for a
> failing run):
> >>>>       >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
> >>>>      <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
> >>>>       >>>
> >>>>       >>
> >>>>       >> Issue was reported by David, Aman sent the fix [1] and it is
> >>>>      already merged by
> >>>>       >> David [2], it should be fixed now, can you please double
> check?
> >>>>       >>
> >>>>       >> [1]
> >>>>       >>
> >>>>
> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
> >>>>      <
> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
> >>>>       >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
> >>>>       >>
> >>>>       >> [2]
> >>>>       >>
> >>>>
> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
> >>>>      <
> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
> >>>>       >> 021b154
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> *Lincoln Lavoie*
> >>>> Principal Engineer, Broadband Technologies
> >>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> >>>> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> >>>> https://www.iol.unh.edu <https://www.iol.unh.edu>
> >>>> +1-603-674-2755 (m)
> >>>> <https://www.iol.unh.edu>
> >>
> >>
> >>
>
>

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 16734 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev]  RHEL7 failures
  2021-10-12 12:39                 ` Lincoln Lavoie
@ 2021-10-12 13:32                   ` Ferruh Yigit
  2021-10-12 13:57                     ` Thomas Monjalon
  2021-10-12 13:49                   ` Thinh Tran
  2021-10-12 13:50                   ` Juraj Linkeš
  2 siblings, 1 reply; 16+ messages in thread
From: Ferruh Yigit @ 2021-10-12 13:32 UTC (permalink / raw)
  To: Lincoln Lavoie, Aaron Conole, David Marchand, Thomas Monjalon
  Cc: Thinh Tran, Brandon Lo, Zhang, Qi Z, dev, Yang, Qiming, ci,
	dpdklab, Singh, Aman Deep

On 10/12/2021 1:39 PM, Lincoln Lavoie wrote:
> Ferruh and Thinh,
> 
> Yes, that will also work and should trigger the rebuild to the tip of the
> current git repo / branch.  Apologizes for forgetting that behavior is
> built into the runner.
> 
> All,
> 
> That raises the question, for the planned work to allow triggering rebuilds
> / reruns through patchwork, what is the expected behavior, rerun exactly
> what was run before, or move to the current pointer (assuming it's moved
> on) and build/run on top of that?  What best aligns with everyone's
> expectations, so we don't get confusion, etc.?
> 

I don't see any problem to rerun the test with latest head of the repo,
eventually patch on the patchwork needs to be merged on top of the latest
head.
Even the intention is only to test infrastructure etc with rerun,
it shouldn't hurt to update the pointer too.

> Cheers,
> Lincoln
> 
> On Mon, Oct 11, 2021 at 8:58 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> On 10/11/2021 11:45 PM, Thinh Tran wrote:
>>> Hi Brandon,
>>>
>>> Does the rebuild have the fix for RHEL 7? Please check.
>>>
>>> I just checked the build status, it still hits the same failure on RHEL
>> 7:
>>
>> https://lab.dpdk.org/results/dashboard/patchsets/19066/
>>
>> Your patch still applied on 'dpdk
>> (086d426406bd3f6fac96a15bbd871c7fe714bc2d)',
>> which doesn't have the fix.
>> It seems 'Rebuild' still using the same commit from dpdk.
>>
>> Submitting a new version of the patch can be easiest solution to
>> run CI on correct version.
>>
>>>
>>> [1502/2903] Compiling C object
>> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
>>> FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
>>> ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base
>> -I../drivers/net/ice/base -I. -I.. -Iconfig -I../config -Ilib/eal/include
>> -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include
>> -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
>> -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
>> -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -pipe
>> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include
>> rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral
>> -Wformat-security -Wmissing-declarations -Wmissing-prototypes
>> -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare
>> -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers
>> -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API
>> -DALLOW_INTERNAL_API -Wno-unused-value -Wno-unused-but-set-variable
>> -Wno-unused-variable -Wno-unused-parameter -MD -MQ
>>> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF
>> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o
>> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c
>> ../drivers/net/ice/base/ice_parser_rt.c
>>> ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
>> type-punned pointer will break strict-aliasing rules
>> [-Werror=strict-aliasing]
>>>     d64 = *(u64 *)&b[0];
>>>     ^
>>> ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
>>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
>> type-punned pointer will break strict-aliasing rules
>> [-Werror=strict-aliasing]
>>>     d32 = *(u32 *)&v[0];
>>>     ^
>>> cc1: all warnings being treated as errors
>>>
>>> Thanks,
>>> Thinh Tran
>>>
>>> On 10/11/2021 12:17 PM, Brandon Lo wrote:
>>>> Hi Thinh,
>>>>
>>>> I have started a rerun of the patch
>>>> https://patches.dpdk.org/patch/100042 (patchset
>>>> https://lab.dpdk.org/results/dashboard/patchsets/19066/).
>>>> You should see the new results reported over email soon.
>>>>
>>>> Thanks,
>>>> Brandon
>>>>
>>>>
>>>> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <thinhtr@linux.vnet.ibm.com>
>> wrote:
>>>>>
>>>>> Hi Linconln,
>>>>>
>>>>> I have this patch set 100042  - build/ppc: enable build support for
>> Power10
>>>>> https://patches.dpdk.org/patch/100042
>>>>>
>>>>> Thanks,
>>>>> Thinh Tran
>>>>>
>>>>>
>>>>>
>>>>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
>>>>>> Hi Thinh, The CI won't automatically go back and retest failures
>> after a
>>>>>> patch was applied.  This is a corner case, where a bad change was
>> merged
>>>>>> and affected all patches downstream of that merge.  We can retrigger
>>>>>> specific patches, just ZjQcmQRYFpfptBannerStart
>>>>>> This Message Is From an External Sender
>>>>>> This message came from outside your organization.
>>>>>> ZjQcmQRYFpfptBannerEnd
>>>>>> Hi Thinh,
>>>>>>
>>>>>> The CI won't automatically go back and retest failures after a patch
>> was
>>>>>> applied.  This is a corner case, where a bad change was merged and
>>>>>> affected all patches downstream of that merge.  We can retrigger
>>>>>> specific patches, just let us know the patch number or the URI of the
>>>>>> patch(es).
>>>>>>
>>>>>> Cheers,
>>>>>> Lincoln
>>>>>>
>>>>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <
>> thinhtr@linux.vnet.ibm.com
>>>>>> <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
>>>>>>
>>>>>>
>>>>>>       Hi,
>>>>>>       I'm wondering how or when the CI would re-pick up the patches
>> those
>>>>>>       were
>>>>>>       failed due to this issue?
>>>>>>
>>>>>>       Regards,
>>>>>>       Thinh Tran
>>>>>>
>>>>>>       On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
>>>>>>        > Hi Ferruh, David and Aman:
>>>>>>        >
>>>>>>        >       Sorry for late response due to PRC holiday.
>>>>>>        >       I have just tested the patch and there is no issue be
>>>>>>       detected for functions
>>>>>>        >       Thank you so much for the help!
>>>>>>        >
>>>>>>        > Regards
>>>>>>        > Qi
>>>>>>        >
>>>>>>        >> -----Original Message-----
>>>>>>        >> From: Yigit, Ferruh <ferruh.yigit@intel.com
>>>>>>       <mailto:ferruh.yigit@intel.com>>
>>>>>>        >> Sent: Wednesday, October 6, 2021 5:46 AM
>>>>>>        >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
>>>>>>       <mailto:lylavoie@iol.unh.edu>>; dev <dev@dpdk.org
>>>>>>       <mailto:dev@dpdk.org>>; Yang, Qiming
>>>>>>        >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>>;
>> Zhang,
>>>>>>       Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>
>>>>>>        >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>; Aaron Conole
>>>>>>       <aconole@redhat.com <mailto:aconole@redhat.com>>; dpdklab
>>>>>>        >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>; Singh,
>> Aman
>>>>>>       Deep <aman.deep.singh@intel.com <mailto:
>> aman.deep.singh@intel.com>>;
>>>>>>        >> David Marchand <david.marchand@redhat.com
>>>>>>       <mailto:david.marchand@redhat.com>>
>>>>>>        >> Subject: Re: [dpdk-dev] RHEL7 failures
>>>>>>        >>
>>>>>>        >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>>>>>>        >>> Hello Qiming and Qi,
>>>>>>        >>>
>>>>>>        >>> The CI is picking up failures when building on RHEL7, where
>>>>>>       warnings
>>>>>>        >>> are being treated as errors.  This looks like something has
>> been
>>>>>>        >>> merged into the mainline, as it's failing across all
>> patches.
>>>>>>        >>>
>>>>>>        >>> Here is the specific failure:
>>>>>>        >>>
>>>>>>        >>> ./drivers/net/ice/base/ice_parser_rt.c: In function
>> '_hv_bit_sel':
>>>>>>        >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error:
>> dereferencing
>>>>>>        >>> type-punned pointer will break strict-aliasing rules
>>>>>>        >>> [-Werror=strict-aliasing]
>>>>>>        >>>     d64 = *(u64 *)&b[0];
>>>>>>        >>>     ^
>>>>>>        >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
>>>>>>       '_reg_bit_sel':
>>>>>>        >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error:
>> dereferencing
>>>>>>        >>> type-punned pointer will break strict-aliasing rules
>>>>>>        >>> [-Werror=strict-aliasing]
>>>>>>        >>>     d32 = *(u32 *)&v[0];
>>>>>>        >>>     ^
>>>>>>        >>> cc1: all warnings being treated as errors
>>>>>>        >>>
>>>>>>        >>> You can download a full set of logs from here (for a
>> failing run):
>>>>>>        >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
>>>>>>       <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
>>>>>>        >>>
>>>>>>        >>
>>>>>>        >> Issue was reported by David, Aman sent the fix [1] and it is
>>>>>>       already merged by
>>>>>>        >> David [2], it should be fixed now, can you please double
>> check?
>>>>>>        >>
>>>>>>        >> [1]
>>>>>>        >>
>>>>>>
>> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>>>>>>       <
>> https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
>>>>>>        >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
>>>>>>        >>
>>>>>>        >> [2]
>>>>>>        >>
>>>>>>
>> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>>>>>>       <
>> https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
>>>>>>        >> 021b154
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Lincoln Lavoie*
>>>>>> Principal Engineer, Broadband Technologies
>>>>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824
>>>>>> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
>>>>>> https://www.iol.unh.edu <https://www.iol.unh.edu>
>>>>>> +1-603-674-2755 (m)
>>>>>> <https://www.iol.unh.edu>
>>>>
>>>>
>>>>
>>
>>
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-12 12:39                 ` Lincoln Lavoie
  2021-10-12 13:32                   ` Ferruh Yigit
@ 2021-10-12 13:49                   ` Thinh Tran
  2021-10-12 13:50                   ` Juraj Linkeš
  2 siblings, 0 replies; 16+ messages in thread
From: Thinh Tran @ 2021-10-12 13:49 UTC (permalink / raw)
  To: Lincoln Lavoie, Ferruh Yigit
  Cc: Brandon Lo, Zhang, Qi Z, dev, Yang, Qiming, ci, Aaron Conole,
	dpdklab, Singh, Aman Deep, David Marchand

Hi,
Thank you all for helping. I will create a new version for my patch.

Thanks,
Thinh Tran

On 10/12/2021 7:39 AM, Lincoln Lavoie wrote:
> Ferruh and Thinh, Yes, that will also work and should trigger the 
> rebuild to the tip of the current git repo / branch.  Apologizes for 
> forgetting that behavior is built into the runner. All, That raises the 
> question, for the planned work to ZjQcmQRYFpfptBannerStart
> This Message Is From an External Sender
> This message came from outside your organization.
> ZjQcmQRYFpfptBannerEnd
> Ferruh and Thinh,
> 
> Yes, that will also work and should trigger the rebuild to the tip of 
> the current git repo / branch.  Apologizes for forgetting that behavior 
> is built into the runner.
> 
> All,
> 
> That raises the question, for the planned work to allow triggering 
> rebuilds / reruns through patchwork, what is the expected behavior, 
> rerun exactly what was run before, or move to the current pointer 
> (assuming it's moved on) and build/run on top of that?  What best aligns 
> with everyone's expectations, so we don't get confusion, etc.?
> 
> Cheers,
> Lincoln
> 
> On Mon, Oct 11, 2021 at 8:58 PM Ferruh Yigit <ferruh.yigit@intel.com 
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 10/11/2021 11:45 PM, Thinh Tran wrote:
>      > Hi Brandon,
>      >
>      > Does the rebuild have the fix for RHEL 7? Please check.
>      >
>      > I just checked the build status, it still hits the same failure
>     on RHEL 7:
> 
>     https://lab.dpdk.org/results/dashboard/patchsets/19066/
>     <https://lab.dpdk.org/results/dashboard/patchsets/19066/>
> 
>     Your patch still applied on 'dpdk
>     (086d426406bd3f6fac96a15bbd871c7fe714bc2d)',
>     which doesn't have the fix.
>     It seems 'Rebuild' still using the same commit from dpdk.
> 
>     Submitting a new version of the patch can be easiest solution to
>     run CI on correct version.
> 
>      >
>      > [1502/2903] Compiling C object
>     drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
>      > FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
>      > ccache cc -Idrivers/net/ice/base/libice_base.a.p
>     -Idrivers/net/ice/base -I../drivers/net/ice/base -I. -I.. -Iconfig
>     -I../config -Ilib/eal/include -I../lib/eal/include
>     -Ilib/eal/linux/include -I../lib/eal/linux/include
>     -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
>     -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs
>     -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry
>     -I../lib/telemetry -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
>     -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated
>     -Wformat -Wformat-nonliteral -Wformat-security
>     -Wmissing-declarations -Wmissing-prototypes -Wnested-externs
>     -Wold-style-definition -Wpointer-arith -Wsign-compare
>     -Wstrict-prototypes -Wundef -Wwrite-strings
>     -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native
>     -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-unused-value
>     -Wno-unused-but-set-variable -Wno-unused-variable
>     -Wno-unused-parameter -MD -MQ
>      > drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF
>     drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o
>     drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c
>     ../drivers/net/ice/base/ice_parser_rt.c
>      > ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>      > ../drivers/net/ice/base/ice_parser_rt.c:201:2: error:
>     dereferencing type-punned pointer will break strict-aliasing rules
>     [-Werror=strict-aliasing]
>      >    d64 = *(u64 *)&b[0];
>      >    ^
>      > ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
>      > ../drivers/net/ice/base/ice_parser_rt.c:458:2: error:
>     dereferencing type-punned pointer will break strict-aliasing rules
>     [-Werror=strict-aliasing]
>      >    d32 = *(u32 *)&v[0];
>      >    ^
>      > cc1: all warnings being treated as errors
>      >
>      > Thanks,
>      > Thinh Tran
>      >
>      > On 10/11/2021 12:17 PM, Brandon Lo wrote:
>      >> Hi Thinh,
>      >>
>      >> I have started a rerun of the patch
>      >> https://patches.dpdk.org/patch/100042
>     <https://patches.dpdk.org/patch/100042> (patchset
>      >> https://lab.dpdk.org/results/dashboard/patchsets/19066/
>     <https://lab.dpdk.org/results/dashboard/patchsets/19066/>).
>      >> You should see the new results reported over email soon.
>      >>
>      >> Thanks,
>      >> Brandon
>      >>
>      >>
>      >> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran
>     <thinhtr@linux.vnet.ibm.com <mailto:thinhtr@linux.vnet.ibm.com>> wrote:
>      >>>
>      >>> Hi Linconln,
>      >>>
>      >>> I have this patch set 100042  - build/ppc: enable build support
>     for Power10
>      >>> https://patches.dpdk.org/patch/100042
>     <https://patches.dpdk.org/patch/100042>
>      >>>
>      >>> Thanks,
>      >>> Thinh Tran
>      >>>
>      >>>
>      >>>
>      >>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
>      >>>> Hi Thinh, The CI won't automatically go back and retest
>     failures after a
>      >>>> patch was applied.  This is a corner case, where a bad change
>     was merged
>      >>>> and affected all patches downstream of that merge.  We can
>     retrigger
>      >>>> specific patches, just ZjQcmQRYFpfptBannerStart
>      >>>> This Message Is From an External Sender
>      >>>> This message came from outside your organization.
>      >>>> ZjQcmQRYFpfptBannerEnd
>      >>>> Hi Thinh,
>      >>>>
>      >>>> The CI won't automatically go back and retest failures after a
>     patch was
>      >>>> applied.  This is a corner case, where a bad change was merged and
>      >>>> affected all patches downstream of that merge.  We can retrigger
>      >>>> specific patches, just let us know the patch number or the URI
>     of the
>      >>>> patch(es).
>      >>>>
>      >>>> Cheers,
>      >>>> Lincoln
>      >>>>
>      >>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran
>     <thinhtr@linux.vnet.ibm.com <mailto:thinhtr@linux.vnet.ibm.com>
>      >>>> <mailto:thinhtr@linux.vnet.ibm.com
>     <mailto:thinhtr@linux.vnet.ibm.com>>> wrote:
>      >>>>
>      >>>>
>      >>>>      Hi,
>      >>>>      I'm wondering how or when the CI would re-pick up the
>     patches those
>      >>>>      were
>      >>>>      failed due to this issue?
>      >>>>
>      >>>>      Regards,
>      >>>>      Thinh Tran
>      >>>>
>      >>>>      On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
>      >>>>       > Hi Ferruh, David and Aman:
>      >>>>       >
>      >>>>       >       Sorry for late response due to PRC holiday.
>      >>>>       >       I have just tested the patch and there is no
>     issue be
>      >>>>      detected for functions
>      >>>>       >       Thank you so much for the help!
>      >>>>       >
>      >>>>       > Regards
>      >>>>       > Qi
>      >>>>       >
>      >>>>       >> -----Original Message-----
>      >>>>       >> From: Yigit, Ferruh <ferruh.yigit@intel.com
>     <mailto:ferruh.yigit@intel.com>
>      >>>>      <mailto:ferruh.yigit@intel.com
>     <mailto:ferruh.yigit@intel.com>>>
>      >>>>       >> Sent: Wednesday, October 6, 2021 5:46 AM
>      >>>>       >> To: Lincoln Lavoie <lylavoie@iol.unh.edu
>     <mailto:lylavoie@iol.unh.edu>
>      >>>>      <mailto:lylavoie@iol.unh.edu
>     <mailto:lylavoie@iol.unh.edu>>>; dev <dev@dpdk.org <mailto:dev@dpdk.org>
>      >>>>      <mailto:dev@dpdk.org <mailto:dev@dpdk.org>>>; Yang, Qiming
>      >>>>       >> <qiming.yang@intel.com <mailto:qiming.yang@intel.com>
>     <mailto:qiming.yang@intel.com <mailto:qiming.yang@intel.com>>>; Zhang,
>      >>>>      Qi Z <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>
>     <mailto:qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>>
>      >>>>       >> Cc: ci@dpdk.org <mailto:ci@dpdk.org>
>     <mailto:ci@dpdk.org <mailto:ci@dpdk.org>>; Aaron Conole
>      >>>>      <aconole@redhat.com <mailto:aconole@redhat.com>
>     <mailto:aconole@redhat.com <mailto:aconole@redhat.com>>>; dpdklab
>      >>>>       >> <dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>
>     <mailto:dpdklab@iol.unh.edu <mailto:dpdklab@iol.unh.edu>>>; Singh, Aman
>      >>>>      Deep <aman.deep.singh@intel.com
>     <mailto:aman.deep.singh@intel.com> <mailto:aman.deep.singh@intel.com
>     <mailto:aman.deep.singh@intel.com>>>;
>      >>>>       >> David Marchand <david.marchand@redhat.com
>     <mailto:david.marchand@redhat.com>
>      >>>>      <mailto:david.marchand@redhat.com
>     <mailto:david.marchand@redhat.com>>>
>      >>>>       >> Subject: Re: [dpdk-dev] RHEL7 failures
>      >>>>       >>
>      >>>>       >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>      >>>>       >>> Hello Qiming and Qi,
>      >>>>       >>>
>      >>>>       >>> The CI is picking up failures when building on
>     RHEL7, where
>      >>>>      warnings
>      >>>>       >>> are being treated as errors.  This looks like
>     something has been
>      >>>>       >>> merged into the mainline, as it's failing across all
>     patches.
>      >>>>       >>>
>      >>>>       >>> Here is the specific failure:
>      >>>>       >>>
>      >>>>       >>> ./drivers/net/ice/base/ice_parser_rt.c: In function
>     '_hv_bit_sel':
>      >>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2:
>     error: dereferencing
>      >>>>       >>> type-punned pointer will break strict-aliasing rules
>      >>>>       >>> [-Werror=strict-aliasing]
>      >>>>       >>>     d64 = *(u64 *)&b[0];
>      >>>>       >>>     ^
>      >>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
>      >>>>      '_reg_bit_sel':
>      >>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2:
>     error: dereferencing
>      >>>>       >>> type-punned pointer will break strict-aliasing rules
>      >>>>       >>> [-Werror=strict-aliasing]
>      >>>>       >>>     d32 = *(u32 *)&v[0];
>      >>>>       >>>     ^
>      >>>>       >>> cc1: all warnings being treated as errors
>      >>>>       >>>
>      >>>>       >>> You can download a full set of logs from here (for a
>     failing run):
>      >>>>       >>>
>     https://lab.dpdk.org/results/dashboard/patchsets/19162/
>     <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
>      >>>>      <https://lab.dpdk.org/results/dashboard/patchsets/19162/
>     <https://lab.dpdk.org/results/dashboard/patchsets/19162/>>
>      >>>>       >>>
>      >>>>       >>
>      >>>>       >> Issue was reported by David, Aman sent the fix [1]
>     and it is
>      >>>>      already merged by
>      >>>>       >> David [2], it should be fixed now, can you please
>     double check?
>      >>>>       >>
>      >>>>       >> [1]
>      >>>>       >>
>      >>>>
>     https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>     <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
>      >>>>     
>     <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>     <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>>
>      >>>>       >> .deep.singh@intel.com/ <http://deep.singh@intel.com/>
>     <http://deep.singh@intel.com/ <http://deep.singh@intel.com/>>
>      >>>>       >>
>      >>>>       >> [2]
>      >>>>       >>
>      >>>>
>     https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>     <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
>      >>>>     
>     <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>     <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>>
>      >>>>       >> 021b154
>      >>>>
>      >>>>
>      >>>>
>      >>>> --
>      >>>> *Lincoln Lavoie*
>      >>>> Principal Engineer, Broadband Technologies
>      >>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824
>      >>>> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
>     <mailto:lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>>
>      >>>> https://www.iol.unh.edu <https://www.iol.unh.edu>
>     <https://www.iol.unh.edu <https://www.iol.unh.edu>>
>      >>>> +1-603-674-2755 (m)
>      >>>> <https://www.iol.unh.edu <https://www.iol.unh.edu>>
>      >>
>      >>
>      >>
> 
> 
> 
> -- 
> *Lincoln Lavoie*
> Principal Engineer, Broadband Technologies
> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> https://www.iol.unh.edu <https://www.iol.unh.edu>
> +1-603-674-2755 (m)
> <https://www.iol.unh.edu>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-12 12:39                 ` Lincoln Lavoie
  2021-10-12 13:32                   ` Ferruh Yigit
  2021-10-12 13:49                   ` Thinh Tran
@ 2021-10-12 13:50                   ` Juraj Linkeš
  2021-10-12 14:00                     ` Thomas Monjalon
  2 siblings, 1 reply; 16+ messages in thread
From: Juraj Linkeš @ 2021-10-12 13:50 UTC (permalink / raw)
  To: Lincoln Lavoie, Ferruh Yigit
  Cc: Thinh Tran, Brandon Lo, Zhang, Qi Z, dev, Yang, Qiming, ci,
	Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand


[-- Attachment #1.1: Type: text/plain, Size: 10712 bytes --]

I'm used to Gerrit where reruns on a given version always run with the same parent commit. I think this makes sense since this would give us a way to rerun with the same parent and the latest parent (using a new upload). Also, the version we're trying to rerun may no longer apply to the current HEAD, so it makes sense from this point of view as well.

Juraj

From: ci <ci-bounces@dpdk.org> On Behalf Of Lincoln Lavoie
Sent: Tuesday, October 12, 2021 2:39 PM
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thinh Tran <thinhtr@linux.vnet.ibm.com>; Brandon Lo <blo@iol.unh.edu>; Zhang, Qi Z <qi.z.zhang@intel.com>; dev <dev@dpdk.org>; Yang, Qiming <qiming.yang@intel.com>; ci@dpdk.org; Aaron Conole <aconole@redhat.com>; dpdklab <dpdklab@iol.unh.edu>; Singh, Aman Deep <aman.deep.singh@intel.com>; David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-ci] [dpdk-dev] RHEL7 failures

Ferruh and Thinh,

Yes, that will also work and should trigger the rebuild to the tip of the current git repo / branch.  Apologizes for forgetting that behavior is built into the runner.

All,

That raises the question, for the planned work to allow triggering rebuilds / reruns through patchwork, what is the expected behavior, rerun exactly what was run before, or move to the current pointer (assuming it's moved on) and build/run on top of that?  What best aligns with everyone's expectations, so we don't get confusion, etc.?

Cheers,
Lincoln

On Mon, Oct 11, 2021 at 8:58 PM Ferruh Yigit <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>> wrote:
On 10/11/2021 11:45 PM, Thinh Tran wrote:
> Hi Brandon,
>
> Does the rebuild have the fix for RHEL 7? Please check.
>
> I just checked the build status, it still hits the same failure on RHEL 7:

https://lab.dpdk.org/results/dashboard/patchsets/19066/

Your patch still applied on 'dpdk (086d426406bd3f6fac96a15bbd871c7fe714bc2d)',
which doesn't have the fix.
It seems 'Rebuild' still using the same commit from dpdk.

Submitting a new version of the patch can be easiest solution to
run CI on correct version.

>
> [1502/2903] Compiling C object drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
> FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o
> ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base -I../drivers/net/ice/base -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-unused-value -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unused-parameter -MD -MQ
> drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c ../drivers/net/ice/base/ice_parser_rt.c
> ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
>    d64 = *(u64 *)&b[0];
>    ^
> ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':
> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
>    d32 = *(u32 *)&v[0];
>    ^
> cc1: all warnings being treated as errors
>
> Thanks,
> Thinh Tran
>
> On 10/11/2021 12:17 PM, Brandon Lo wrote:
>> Hi Thinh,
>>
>> I have started a rerun of the patch
>> https://patches.dpdk.org/patch/100042 (patchset
>> https://lab.dpdk.org/results/dashboard/patchsets/19066/).
>> You should see the new results reported over email soon.
>>
>> Thanks,
>> Brandon
>>
>>
>> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <thinhtr@linux.vnet.ibm.com<mailto:thinhtr@linux.vnet.ibm.com>> wrote:
>>>
>>> Hi Linconln,
>>>
>>> I have this patch set 100042  - build/ppc: enable build support for Power10
>>> https://patches.dpdk.org/patch/100042
>>>
>>> Thanks,
>>> Thinh Tran
>>>
>>>
>>>
>>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:
>>>> Hi Thinh, The CI won't automatically go back and retest failures after a
>>>> patch was applied.  This is a corner case, where a bad change was merged
>>>> and affected all patches downstream of that merge.  We can retrigger
>>>> specific patches, just ZjQcmQRYFpfptBannerStart
>>>> This Message Is From an External Sender
>>>> This message came from outside your organization.
>>>> ZjQcmQRYFpfptBannerEnd
>>>> Hi Thinh,
>>>>
>>>> The CI won't automatically go back and retest failures after a patch was
>>>> applied.  This is a corner case, where a bad change was merged and
>>>> affected all patches downstream of that merge.  We can retrigger
>>>> specific patches, just let us know the patch number or the URI of the
>>>> patch(es).
>>>>
>>>> Cheers,
>>>> Lincoln
>>>>
>>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <thinhtr@linux.vnet.ibm.com<mailto:thinhtr@linux.vnet.ibm.com>
>>>> <mailto:thinhtr@linux.vnet.ibm.com<mailto:thinhtr@linux.vnet.ibm.com>>> wrote:
>>>>
>>>>
>>>>      Hi,
>>>>      I'm wondering how or when the CI would re-pick up the patches those
>>>>      were
>>>>      failed due to this issue?
>>>>
>>>>      Regards,
>>>>      Thinh Tran
>>>>
>>>>      On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:
>>>>       > Hi Ferruh, David and Aman:
>>>>       >
>>>>       >       Sorry for late response due to PRC holiday.
>>>>       >       I have just tested the patch and there is no issue be
>>>>      detected for functions
>>>>       >       Thank you so much for the help!
>>>>       >
>>>>       > Regards
>>>>       > Qi
>>>>       >
>>>>       >> -----Original Message-----
>>>>       >> From: Yigit, Ferruh <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>
>>>>      <mailto:ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>>
>>>>       >> Sent: Wednesday, October 6, 2021 5:46 AM
>>>>       >> To: Lincoln Lavoie <lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>
>>>>      <mailto:lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>>>; dev <dev@dpdk.org<mailto:dev@dpdk.org>
>>>>      <mailto:dev@dpdk.org<mailto:dev@dpdk.org>>>; Yang, Qiming
>>>>       >> <qiming.yang@intel.com<mailto:qiming.yang@intel.com> <mailto:qiming.yang@intel.com<mailto:qiming.yang@intel.com>>>; Zhang,
>>>>      Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com> <mailto:qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>>
>>>>       >> Cc: ci@dpdk.org<mailto:ci@dpdk.org> <mailto:ci@dpdk.org<mailto:ci@dpdk.org>>; Aaron Conole
>>>>      <aconole@redhat.com<mailto:aconole@redhat.com> <mailto:aconole@redhat.com<mailto:aconole@redhat.com>>>; dpdklab
>>>>       >> <dpdklab@iol.unh.edu<mailto:dpdklab@iol.unh.edu> <mailto:dpdklab@iol.unh.edu<mailto:dpdklab@iol.unh.edu>>>; Singh, Aman
>>>>      Deep <aman.deep.singh@intel.com<mailto:aman.deep.singh@intel.com> <mailto:aman.deep.singh@intel.com<mailto:aman.deep.singh@intel.com>>>;
>>>>       >> David Marchand <david.marchand@redhat.com<mailto:david.marchand@redhat.com>
>>>>      <mailto:david.marchand@redhat.com<mailto:david.marchand@redhat.com>>>
>>>>       >> Subject: Re: [dpdk-dev] RHEL7 failures
>>>>       >>
>>>>       >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:
>>>>       >>> Hello Qiming and Qi,
>>>>       >>>
>>>>       >>> The CI is picking up failures when building on RHEL7, where
>>>>      warnings
>>>>       >>> are being treated as errors.  This looks like something has been
>>>>       >>> merged into the mainline, as it's failing across all patches.
>>>>       >>>
>>>>       >>> Here is the specific failure:
>>>>       >>>
>>>>       >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':
>>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing
>>>>       >>> type-punned pointer will break strict-aliasing rules
>>>>       >>> [-Werror=strict-aliasing]
>>>>       >>>     d64 = *(u64 *)&b[0];
>>>>       >>>     ^
>>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c: In function
>>>>      '_reg_bit_sel':
>>>>       >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing
>>>>       >>> type-punned pointer will break strict-aliasing rules
>>>>       >>> [-Werror=strict-aliasing]
>>>>       >>>     d32 = *(u32 *)&v[0];
>>>>       >>>     ^
>>>>       >>> cc1: all warnings being treated as errors
>>>>       >>>
>>>>       >>> You can download a full set of logs from here (for a failing run):
>>>>       >>> https://lab.dpdk.org/results/dashboard/patchsets/19162/
>>>>      <https://lab.dpdk.org/results/dashboard/patchsets/19162/>
>>>>       >>>
>>>>       >>
>>>>       >> Issue was reported by David, Aman sent the fix [1] and it is
>>>>      already merged by
>>>>       >> David [2], it should be fixed now, can you please double check?
>>>>       >>
>>>>       >> [1]
>>>>       >>
>>>>      https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman
>>>>      <https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman>
>>>>       >> .deep.singh@intel.com/<http://deep.singh@intel.com/> <http://deep.singh@intel.com/>
>>>>       >>
>>>>       >> [2]
>>>>       >>
>>>>      https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809
>>>>      <https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809>
>>>>       >> 021b154
>>>>
>>>>
>>>>
>>>> --
>>>> *Lincoln Lavoie*
>>>> Principal Engineer, Broadband Technologies
>>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824
>>>> lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu> <mailto:lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>>
>>>> https://www.iol.unh.edu <https://www.iol.unh.edu>
>>>> +1-603-674-2755 (m)
>>>> <https://www.iol.unh.edu>
>>
>>
>>


--
Lincoln Lavoie
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>
https://www.iol.unh.edu
+1-603-674-2755 (m)
[Image removed by sender.]<https://www.iol.unh.edu>

[-- Attachment #1.2: Type: text/html, Size: 22853 bytes --]

[-- Attachment #2: image001.jpg --]
[-- Type: image/jpeg, Size: 500 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev]  RHEL7 failures
  2021-10-12 13:32                   ` Ferruh Yigit
@ 2021-10-12 13:57                     ` Thomas Monjalon
  0 siblings, 0 replies; 16+ messages in thread
From: Thomas Monjalon @ 2021-10-12 13:57 UTC (permalink / raw)
  To: Lincoln Lavoie, Aaron Conole, David Marchand, Ferruh Yigit
  Cc: Thinh Tran, Brandon Lo, Zhang, Qi Z, dev, Yang, Qiming, ci,
	dpdklab, Singh, Aman Deep

12/10/2021 15:32, Ferruh Yigit:
> On 10/12/2021 1:39 PM, Lincoln Lavoie wrote:
> > Ferruh and Thinh,
> > 
> > Yes, that will also work and should trigger the rebuild to the tip of the
> > current git repo / branch.  Apologizes for forgetting that behavior is
> > built into the runner.
> > 
> > All,
> > 
> > That raises the question, for the planned work to allow triggering rebuilds
> > / reruns through patchwork, what is the expected behavior, rerun exactly
> > what was run before, or move to the current pointer (assuming it's moved
> > on) and build/run on top of that?  What best aligns with everyone's
> > expectations, so we don't get confusion, etc.?
> > 
> 
> I don't see any problem to rerun the test with latest head of the repo,
> eventually patch on the patchwork needs to be merged on top of the latest
> head.
> Even the intention is only to test infrastructure etc with rerun,
> it shouldn't hurt to update the pointer too.

+1 to run on the latest HEAD




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [dpdk-ci] [dpdk-dev] RHEL7 failures
  2021-10-12 13:50                   ` Juraj Linkeš
@ 2021-10-12 14:00                     ` Thomas Monjalon
  0 siblings, 0 replies; 16+ messages in thread
From: Thomas Monjalon @ 2021-10-12 14:00 UTC (permalink / raw)
  To: Lincoln Lavoie, Ferruh Yigit, ci
  Cc: Thinh Tran, Brandon Lo, Zhang, Qi Z, dev, Yang, Qiming, ci,
	Aaron Conole, dpdklab, Singh, Aman Deep, David Marchand,
	Juraj Linkeš

12/10/2021 15:50, Juraj Linkeš:
> I'm used to Gerrit where reruns on a given version always run with the same parent commit. I think this makes sense since this would give us a way to rerun with the same parent and the latest parent (using a new upload). Also, the version we're trying to rerun may no longer apply to the current HEAD, so it makes sense from this point of view as well.

If a patch doesn't apply, it is good to trigger it in CI.
When sending a patch, the expectation is to apply to the latest HEAD,
without knowing exactly neither when it will be effectively applied,
nor when the CI will run any test.

PS: please do not top-post.


> Juraj
> 
> From: ci <ci-bounces@dpdk.org> On Behalf Of Lincoln Lavoie
> All,
> 
> That raises the question, for the planned work to allow triggering rebuilds / reruns through patchwork, what is the expected behavior, rerun exactly what was run before, or move to the current pointer (assuming it's moved on) and build/run on top of that?  What best aligns with everyone's expectations, so we don't get confusion, etc.?
> 
> Cheers,
> Lincoln




^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-10-12 14:00 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 19:09 [dpdk-ci] RHEL7 failures Lincoln Lavoie
2021-10-05 21:46 ` [dpdk-ci] [dpdk-dev] " Ferruh Yigit
2021-10-06 12:39   ` Lincoln Lavoie
2021-10-07  3:40   ` Zhang, Qi Z
2021-10-11 14:39     ` Thinh Tran
2021-10-11 14:42       ` Lincoln Lavoie
2021-10-11 16:39         ` Thinh Tran
2021-10-11 17:17           ` Brandon Lo
2021-10-11 22:45             ` Thinh Tran
2021-10-12  0:57               ` Ferruh Yigit
2021-10-12 12:39                 ` Lincoln Lavoie
2021-10-12 13:32                   ` Ferruh Yigit
2021-10-12 13:57                     ` Thomas Monjalon
2021-10-12 13:49                   ` Thinh Tran
2021-10-12 13:50                   ` Juraj Linkeš
2021-10-12 14:00                     ` Thomas Monjalon

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git