Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD

["Tom Jones" <thj@freebsd.org>]

Hi Bruce,

thanks for letting me know

I'm not tied to anything particularly. This change isn't compatible with the previous API, but I'm not against making it so if that is really the best thing to do. As is, the dpdk changes and the contigmem changes need to come together because the API changes for getting the physical addresses.

It is just the sysctl paths that differ. I'm not sure what the compatibility needs to be for DPDK, for all of my usage I have built the kernel module with the package - making API changes easy.

I'm happy to follow which ever path you think is best.

Sorry for the patch confusion, I'll try to keep the sequence obvious going forward.

Tom

On Fri, May 3, 2024, at 14:03, Bruce Richardson wrote:
> On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote:
>> Add support to the contigmem module on FreeBSD for multiple concurrent
>> files, this enables running multiple dpdk instances with the nic_uio
>> driver.
>> 
>> Add relevant parts in dpdk to support this.
>> 
>> Signed-off-by: Tom Jones <thj@freebsd.org> ---
>
> Thanks for these patches, I hope to review and test them soon.  From an
> initial quick scan through, I think the changes may be easier reviewed if
> split up into more than one patch. For example, could the changes to move
> the "SYSCTL_INT" declarations from being in global to local scope be
> separated out into one patch? Also, if the kernel module changes are
> backward compatible, they could be in a separate patch to the userspace 
> changes to take advantage of the kernel module enhancements.
>
> Is such a split possible or are all the changes tightly tied together?
>
> /Bruce
>
> PS: For sending new versions of this patch, or as a patchset, please add a
> version number so we can track what version is the latest one in patchwork
> and on the mailing list. [Use -v<N> flag to git format-patch] Thanks.

-- 
- Tom