DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tom Jones <thj@freebsd.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] freebsd: Add support for multiple dpdk instances on FreeBSD
Date: Fri, 3 May 2024 14:03:41 +0100	[thread overview]
Message-ID: <ZjTgrbHoxN-7awzw@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240503094615.1427-1-thj@freebsd.org>

On Fri, May 03, 2024 at 09:46:15AM +0000, Tom Jones wrote:
> Add support to the contigmem module on FreeBSD for multiple concurrent
> files, this enables running multiple dpdk instances with the nic_uio
> driver.
> 
> Add relevant parts in dpdk to support this.
> 
> Signed-off-by: Tom Jones <thj@freebsd.org> ---

Thanks for these patches, I hope to review and test them soon.  From an
initial quick scan through, I think the changes may be easier reviewed if
split up into more than one patch. For example, could the changes to move
the "SYSCTL_INT" declarations from being in global to local scope be
separated out into one patch? Also, if the kernel module changes are
backward compatible, they could be in a separate patch to the userspace 
changes to take advantage of the kernel module enhancements.

Is such a split possible or are all the changes tightly tied together?

/Bruce

PS: For sending new versions of this patch, or as a patchset, please add a
version number so we can track what version is the latest one in patchwork
and on the mailing list. [Use -v<N> flag to git format-patch] Thanks.

  reply	other threads:[~2024-05-03 13:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 13:55 Tom Jones
2024-05-03  9:46 ` Tom Jones
2024-05-03 13:03   ` Bruce Richardson [this message]
2024-05-03 13:12     ` Tom Jones
2024-05-03 13:24       ` Bruce Richardson
2024-05-03 16:25   ` Bruce Richardson
2024-05-03 16:48   ` Bruce Richardson
2024-05-03 16:52     ` Bruce Richardson
2024-05-06 15:34       ` Tom Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjTgrbHoxN-7awzw@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thj@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).