DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: Chenbo Xia <chenbo.xia@intel.com>,
	Yuan Wang <yuanx.wang@intel.com>, Xuan Ding <xuan.ding@intel.com>
Subject: Re: [PATCH] vhost: fix log for async dequeue
Date: Fri, 17 Jun 2022 16:00:12 +0200	[thread overview]
Message-ID: <09753bf0-3d54-0749-88a9-e80370982be2@redhat.com> (raw)
In-Reply-To: <20220617054003.1291251-1-david.marchand@redhat.com>



On 6/17/22 07:40, David Marchand wrote:
> Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"),
> vhost logs contain the socket path as a prefix.
> Async dequeue path was copied from the sync dequeue path but a log
> was incorrect.
> 
> Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   lib/vhost/virtio_net.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 68a26eb17d..bedd406b37 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -3529,7 +3529,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
>   
>   		rarp_mbuf = rte_net_make_rarp_packet(mbuf_pool, &dev->mac);
>   		if (rarp_mbuf == NULL) {
> -			VHOST_LOG_DATA(ERR, "Failed to make RARP packet.\n");
> +			VHOST_LOG_DATA(ERR, "(%s) failed to make RARP packet.\n", dev->ifname);
>   			count = 0;
>   			goto out;
>   		}

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2022-06-17 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  5:40 David Marchand
2022-06-17 14:00 ` Maxime Coquelin [this message]
2022-06-17 14:09 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09753bf0-3d54-0749-88a9-e80370982be2@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=xuan.ding@intel.com \
    --cc=yuanx.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).