From: "Xu, Rosen" <rosen.xu@intel.com>
To: Matan Azrad <matan@mellanox.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Pei, Andy" <andy.pei@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers
Date: Wed, 8 Jan 2020 12:39:29 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73AC794C5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <AM0PR0502MB4019AB72F7ADE22FE58C98C3D23E0@AM0PR0502MB4019.eurprd05.prod.outlook.com>
Hi Matan,
> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Wednesday, January 08, 2020 18:46
> To: Xu, Rosen <rosen.xu@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Bie, Tiwei <tiwei.bie@intel.com>; Wang,
> Zhihong <zhihong.wang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>; Pei, Andy <andy.pei@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device
> drivers
>
> Hi Xu
>
> From: Xu, Rosen
> > Hi Matan,
> >
> > Did you think about OVS DPDK?
> > vDPA is a basic module for OVS, currently it will take some exception
> > path packet processing for OVS, so it still needs to integrate eth_dev.
>
> I don't understand your question.
>
> What do you mean by "integrate eth_dev"?
My questions is in OVS DPDK scenario vDPA device implements eth_dev ops,
so create a new class and move ifc code to this new class is not ok.
> > Thanks,
> > Rosen
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> > > Sent: Tuesday, January 07, 2020 15:57
> > > To: Matan Azrad <matan@mellanox.com>; Maxime Coquelin
> > > <maxime.coquelin@redhat.com>; Bie, Tiwei <tiwei.bie@intel.com>;
> > > Wang, Zhihong <zhihong.wang@intel.com>; Wang, Xiao W
> > <xiao.w.wang@intel.com>
> > > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; Thomas
> > > Monjalon <thomas@monjalon.net>
> > > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA
> > > device drivers
> > >
> > > Hi all
> > >
> > > Any comments?
> > >
> > > From: Matan Azrad
> > > > As discussed and as described in RFC "[RFC] net: new vdpa PMD for
> > > > Mellanox devices", new vDPA driver is going to be added for
> > > > Mellanox devices - vDPA
> > > > mlx5 and more.
> > > >
> > > > The only vDPA driver now is the IFC driver that is located in net
> directory.
> > > >
> > > > The IFC driver and the new vDPA mlx5 driver provide the vDPA ops
> > > > introduced in librte_vhost and not the eth-dev ops.
> > > > All the others drivers in net class provide the eth-dev ops.
> > > > The set of features is also different.
> > > >
> > > > Create a new class for vDPA drivers and move IFC to this class.
> > > > Later, all the new drivers that implement the vDPA ops will be
> > > > added to the vDPA class.
> > > >
> > > > Also, a vDPA device driver features list was added to vDPA
> > documentation.
> > > >
> > > > Please review the features list and the series.
> > > >
> > > > Later on, I'm going to send the vDPA mlx5 driver.
> > > >
> > > > Thanks.
> > > >
> > > >
> > > > Matan Azrad (3):
> > > > drivers: introduce vDPA class
> > > > doc: add vDPA feature table
> > > > drivers: move ifc driver to the vDPA class
> > > >
> > > > MAINTAINERS | 6 +-
> > > > doc/guides/conf.py | 5 +
> > > > doc/guides/index.rst | 1 +
> > > > doc/guides/nics/features/ifcvf.ini | 8 -
> > > > doc/guides/nics/ifc.rst | 106 ---
> > > > doc/guides/nics/index.rst | 1 -
> > > > doc/guides/vdpadevs/features/default.ini | 55 ++
> > > > doc/guides/vdpadevs/features/ifcvf.ini | 8 +
> > > > doc/guides/vdpadevs/features_overview.rst | 65 ++
> > > > doc/guides/vdpadevs/ifc.rst | 106 +++
> > > > doc/guides/vdpadevs/index.rst | 15 +
> > > > drivers/Makefile | 2 +
> > > > drivers/meson.build | 1 +
> > > > drivers/net/Makefile | 3 -
> > > > drivers/net/ifc/Makefile | 34 -
> > > > drivers/net/ifc/base/ifcvf.c | 329 --------
> > > > drivers/net/ifc/base/ifcvf.h | 162 ----
> > > > drivers/net/ifc/base/ifcvf_osdep.h | 52 --
> > > > drivers/net/ifc/ifcvf_vdpa.c | 1280 -----------------------------
> > > > drivers/net/ifc/meson.build | 9 -
> > > > drivers/net/ifc/rte_pmd_ifc_version.map | 3 -
> > > > drivers/net/meson.build | 1 -
> > > > drivers/vdpa/Makefile | 14 +
> > > > drivers/vdpa/ifc/Makefile | 34 +
> > > > drivers/vdpa/ifc/base/ifcvf.c | 329 ++++++++
> > > > drivers/vdpa/ifc/base/ifcvf.h | 162 ++++
> > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 52 ++
> > > > drivers/vdpa/ifc/ifcvf_vdpa.c | 1280
> > > > +++++++++++++++++++++++++++++
> > > > drivers/vdpa/ifc/meson.build | 9 +
> > > > drivers/vdpa/ifc/rte_pmd_ifc_version.map | 3 +
> > > > drivers/vdpa/meson.build | 8 +
> > > > 31 files changed, 2152 insertions(+), 1991 deletions(-) delete
> > > > mode
> > > > 100644 doc/guides/nics/features/ifcvf.ini
> > > > delete mode 100644 doc/guides/nics/ifc.rst create mode 100644
> > > > doc/guides/vdpadevs/features/default.ini
> > > > create mode 100644 doc/guides/vdpadevs/features/ifcvf.ini
> > > > create mode 100644 doc/guides/vdpadevs/features_overview.rst
> > > > create mode 100644 doc/guides/vdpadevs/ifc.rst create mode
> > > > 100644 doc/guides/vdpadevs/index.rst delete mode 100644
> > > > drivers/net/ifc/Makefile delete mode 100644
> > > > drivers/net/ifc/base/ifcvf.c delete mode 100644
> > > > drivers/net/ifc/base/ifcvf.h delete mode 100644
> > > > drivers/net/ifc/base/ifcvf_osdep.h
> > > > delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c delete mode
> > > > 100644 drivers/net/ifc/meson.build delete mode 100644
> > > > drivers/net/ifc/rte_pmd_ifc_version.map
> > > > create mode 100644 drivers/vdpa/Makefile create mode 100644
> > > > drivers/vdpa/ifc/Makefile create mode 100644
> > > > drivers/vdpa/ifc/base/ifcvf.c create mode 100644
> > > > drivers/vdpa/ifc/base/ifcvf.h create mode 100644
> > > > drivers/vdpa/ifc/base/ifcvf_osdep.h
> > > > create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c create mode
> > > > 100644 drivers/vdpa/ifc/meson.build create mode 100644
> > > > drivers/vdpa/ifc/rte_pmd_ifc_version.map
> > > > create mode 100644 drivers/vdpa/meson.build
> > > >
> > > > --
> > > > 1.8.3.1
next prev parent reply other threads:[~2020-01-08 12:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 15:19 Matan Azrad
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 1/3] drivers: introduce vDPA class Matan Azrad
2020-01-07 17:32 ` Maxime Coquelin
2020-01-08 21:28 ` Thomas Monjalon
2020-01-09 8:00 ` Maxime Coquelin
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table Matan Azrad
2020-01-07 17:39 ` Maxime Coquelin
2020-01-08 5:28 ` Tiwei Bie
2020-01-08 7:20 ` Andrew Rybchenko
2020-01-08 10:42 ` Matan Azrad
2020-01-08 13:11 ` Andrew Rybchenko
2020-01-08 17:01 ` Matan Azrad
2020-01-09 2:15 ` Tiwei Bie
2020-01-09 8:08 ` Matan Azrad
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 3/3] drivers: move ifc driver to the vDPA class Matan Azrad
2020-01-07 18:17 ` Maxime Coquelin
2020-01-07 7:57 ` [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Matan Azrad
2020-01-08 5:44 ` Xu, Rosen
2020-01-08 10:45 ` Matan Azrad
2020-01-08 12:39 ` Xu, Rosen [this message]
2020-01-08 12:58 ` Thomas Monjalon
2020-01-09 2:27 ` Xu, Rosen
2020-01-09 8:41 ` Thomas Monjalon
2020-01-09 9:23 ` Maxime Coquelin
2020-01-09 9:49 ` Xu, Rosen
2020-01-09 10:42 ` Maxime Coquelin
2020-01-10 2:40 ` Xu, Rosen
2020-01-09 10:42 ` Maxime Coquelin
2020-01-09 10:53 ` Xu, Rosen
2020-01-09 11:34 ` Matan Azrad
2020-01-10 2:38 ` Xu, Rosen
2020-01-10 9:21 ` Thomas Monjalon
2020-01-10 14:18 ` Xu, Rosen
2020-01-10 16:27 ` Thomas Monjalon
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 " Matan Azrad
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 1/3] drivers: introduce vDPA class Matan Azrad
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table Matan Azrad
2020-01-10 18:26 ` Thomas Monjalon
2020-01-13 22:40 ` Thomas Monjalon
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class Matan Azrad
2020-01-09 17:25 ` Matan Azrad
2020-01-10 1:55 ` Wang, Haiyue
2020-01-10 9:07 ` Matan Azrad
2020-01-10 9:13 ` Thomas Monjalon
2020-01-10 12:31 ` Wang, Haiyue
2020-01-10 12:34 ` Maxime Coquelin
2020-01-10 12:59 ` Thomas Monjalon
2020-01-10 19:17 ` Kevin Traynor
2020-01-13 22:57 ` Thomas Monjalon
2020-01-13 23:08 ` [dpdk-dev] [PATCH v2 0/3] Introduce new class for vDPA device drivers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73AC794C5@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).