From: Timothy McDaniel <timothy.mcdaniel@intel.com> Cc: dev@dpdk.org, erik.g.carrillo@intel.com, gage.eads@intel.com, harry.van.haaren@intel.com, jerinj@marvell.com Subject: [dpdk-dev] [PATCH v6 00/23] Add DLB PMD Date: Fri, 23 Oct 2020 13:32:09 -0500 Message-ID: <1603477952-583-1-git-send-email-timothy.mcdaniel@intel.com> (raw) In-Reply-To: <1596138614-17409-2-git-send-email-timothy.mcdaniel@intel.com> The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that connect producer and consumer cores, and implements load-balanced queueing features including: - Lock-free multi-producer/multi-consumer operation. - Multiple priority levels for varying traffic types. - 'Direct' traffic (i.e. multi-producer/single-consumer) - Simple unordered load-balanced distribution. - Atomic lock-free load balancing across multiple consumers. - Queue element reordering feature allowing ordered load-balanced distribution. The DLB hardware supports both load balanced and directed ports and queues. Unlike other eventdev devices already in the repo, not all DLB ports and queues are equally capable. In particular, directed ports are limited to a single link, and must be connected to a directed queue. Additionally, even though LDB ports may link multiple queues, the number of queues that may be linked is limited by hardware. Another difference is that DLB does not have a straightforward way of carrying the flow_id in the queue elements (QE) that the hardware operates on. While reviewing the code, please be aware that this PMD has full control over the DLB hardware. Intel will be extending the DLB PMD in the future (not as part of this first series) with a mode that we refer to as the bifurcated PMD. The bifurcated PMD communicates with a kernel driver to configure the device, ports, and queues, and memory maps device MMIO so datapath operations occur purely in user-space. The framework to support both the PF PMD and bifurcated PMD exists in this patchset, and is why the iface.[ch] layer is present. Major changes in v6 after dpdk reviews: ===================== - fixed meson conditional build. Moved test into driver’s meson.build file instead of event/meson.build - documentation is populated as associated code is introduced - add log_register in add dynamic logging patch - rename RTE_xxx symbol(s) as DLB2_xxx - replaced function ptr enqueue_four with direct call to movdir64b - remove unused port_pages - broke up probe patch into 3 smaller patches for easier review - changed param order of movdir64b/movntdq to match intrinsics - added self to MAINTAINERS files - squashed announcement of availability into last patch in series - correct spelling errors and delete repeated words - DPDK_21.0 -> DPDK 21 in map file - add experimental banner to public structs and APIs - implemented other suggestions from code reviews of DLB2 PMD. The software is very similar in form so some DLB2 reviews comments were applicable to DLB as well Major changes in v5 after dpdk reviews and additional internal reviews by colleagues at Intel: ================ - implement changes requested in code reviews by Gage Eads and Mike Chen - fix a memzone leak - convert to use eal rte-cpuflags patch from Liang Ma Major changes in v4 after dpdk reviews and additional internal reviews by colleagues at Intel: ================ - Remove make infrastructure - shared code (pf/base) is now added incrementally - flexible interface (iface.[ch]) is now added incrementally - removed calls to rte_panic - do not call pthread_create directly - remove unused internal API, os_time - convert rte_atomic to __atomic builtins - broke out eventdev ABI changes, test/api changes, and new internal PCI named probe API - relocated enqueue logic to enqueue patch Major Changes in V3: ================ - Fixed a memory corruption issue due to not allocating enough CQ memory for depths < 8. Hardware requires minimum allocation to be at least 8 entries. - Address review comments from Gage and Mattias. - Remove versioning - minor formatting changes Major changes in V2: ================ - Correct ABI break that was present in V1. - Address some of the review comments received from Mattias. I will address the remaining items identified by Mattias in the next patch delivery. - General code cleanup based on internal code reviews Depends-on: patch-79539 ("eal: add new x86 cpuid support for WAITPKG") Timothy McDaniel (23): event/dlb: add documentation and meson infrastructure event/dlb: add dynamic logging event/dlb: add private data structures and constants event/dlb: add definitions shared with LKM or shared code event/dlb: add inline functions event/dlb: add eventdev probe event/dlb: add flexible interface event/dlb: add probe-time hardware init event/dlb: add xstats event/dlb: add infos get and configure event/dlb: add queue and port default conf event/dlb: add queue setup event/dlb: add port setup event/dlb: add port link event/dlb: add port unlink and port unlinks in progress event/dlb: add eventdev start event/dlb: add enqueue and its burst variants event/dlb: add dequeue and its burst variants event/dlb: add eventdev stop and close event/dlb: add PMD's token pop public interface event/dlb: add PMD self-tests event/dlb: add queue and port release event/dlb: add timeout ticks entry point MAINTAINERS | 5 + app/test/test_eventdev.c | 7 + config/rte_config.h | 8 +- doc/api/doxy-api-index.md | 1 + doc/guides/eventdevs/dlb.rst | 341 ++ doc/guides/eventdevs/index.rst | 1 + doc/guides/rel_notes/release_20_11.rst | 5 + drivers/event/dlb/dlb.c | 4129 ++++++++++++++ drivers/event/dlb/dlb_iface.c | 79 + drivers/event/dlb/dlb_iface.h | 82 + drivers/event/dlb/dlb_inline_fns.h | 59 + drivers/event/dlb/dlb_log.h | 25 + drivers/event/dlb/dlb_priv.h | 513 ++ drivers/event/dlb/dlb_selftest.c | 1551 +++++ drivers/event/dlb/dlb_user.h | 814 +++ drivers/event/dlb/dlb_xstats.c | 1222 ++++ drivers/event/dlb/meson.build | 21 + drivers/event/dlb/pf/base/dlb_hw_types.h | 334 ++ drivers/event/dlb/pf/base/dlb_osdep.h | 310 + drivers/event/dlb/pf/base/dlb_osdep_bitmap.h | 441 ++ drivers/event/dlb/pf/base/dlb_osdep_list.h | 131 + drivers/event/dlb/pf/base/dlb_osdep_types.h | 31 + drivers/event/dlb/pf/base/dlb_regs.h | 2368 ++++++++ drivers/event/dlb/pf/base/dlb_resource.c | 6904 +++++++++++++++++++++++ drivers/event/dlb/pf/base/dlb_resource.h | 876 +++ drivers/event/dlb/pf/dlb_main.c | 586 ++ drivers/event/dlb/pf/dlb_main.h | 47 + drivers/event/dlb/pf/dlb_pf.c | 750 +++ drivers/event/dlb/rte_pmd_dlb.c | 38 + drivers/event/dlb/rte_pmd_dlb.h | 77 + drivers/event/dlb/rte_pmd_dlb_event_version.map | 9 + drivers/event/meson.build | 2 +- 32 files changed, 21765 insertions(+), 2 deletions(-) create mode 100644 doc/guides/eventdevs/dlb.rst create mode 100644 drivers/event/dlb/dlb.c create mode 100644 drivers/event/dlb/dlb_iface.c create mode 100644 drivers/event/dlb/dlb_iface.h create mode 100644 drivers/event/dlb/dlb_inline_fns.h create mode 100644 drivers/event/dlb/dlb_log.h create mode 100644 drivers/event/dlb/dlb_priv.h create mode 100644 drivers/event/dlb/dlb_selftest.c create mode 100644 drivers/event/dlb/dlb_user.h create mode 100644 drivers/event/dlb/dlb_xstats.c create mode 100644 drivers/event/dlb/meson.build create mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h create mode 100644 drivers/event/dlb/pf/base/dlb_regs.h create mode 100644 drivers/event/dlb/pf/base/dlb_resource.c create mode 100644 drivers/event/dlb/pf/base/dlb_resource.h create mode 100644 drivers/event/dlb/pf/dlb_main.c create mode 100644 drivers/event/dlb/pf/dlb_main.h create mode 100644 drivers/event/dlb/pf/dlb_pf.c create mode 100644 drivers/event/dlb/rte_pmd_dlb.c create mode 100644 drivers/event/dlb/rte_pmd_dlb.h create mode 100644 drivers/event/dlb/rte_pmd_dlb_event_version.map -- 2.6.4
next prev parent reply other threads:[~2020-10-23 18:38 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1593232671-5690-0-git-send-email-timothy.mcdaniel@intel.com> 2020-07-30 19:49 ` [dpdk-dev] [PATCH 00/27] Add Intel DLM PMD to 20.11 McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites McDaniel, Timothy 2020-08-11 17:44 ` Jerin Jacob 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 00/22] Add DLB PMD Timothy McDaniel 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 01/22] event/dlb: add documentation and meson infrastructure Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 02/22] event/dlb: add dynamic logging Timothy McDaniel 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 03/22] event/dlb: add private data structures and constants Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 04/22] event/dlb: add definitions shared with LKM or shared code Timothy McDaniel 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 05/22] event/dlb: add inline functions Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 06/22] event/dlb: add probe Timothy McDaniel 2020-10-18 12:49 ` Jerin Jacob 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 07/22] event/dlb: add xstats Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 08/22] event/dlb: add infos get and configure Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 09/22] event/dlb: add queue and port default conf Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 10/22] event/dlb: add queue setup Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 11/22] event/dlb: add port setup Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 12/22] event/dlb: add port link Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 13/22] event/dlb: add port unlink and port unlinks in progress Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 14/22] event/dlb: add eventdev start Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 15/22] event/dlb: add enqueue and its burst variants Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 16/22] event/dlb: add dequeue " Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 17/22] event/dlb: add eventdev stop and close Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 18/22] event/dlb: add PMD's token pop public interface Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 19/22] event/dlb: add PMD self-tests Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 20/22] event/dlb: add queue and port release Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 21/22] event/dlb: add timeout ticks entry point Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 22/22] doc: Add new DLB eventdev driver to relnotes Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-23 18:32 ` Timothy McDaniel [this message] 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 01/23] event/dlb: add documentation and meson infrastructure Timothy McDaniel 2020-10-24 13:05 ` Jerin Jacob 2020-10-26 16:02 ` McDaniel, Timothy 2020-10-24 14:05 ` Thomas Monjalon 2020-10-26 16:12 ` McDaniel, Timothy 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 02/23] event/dlb: add dynamic logging Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 03/23] event/dlb: add private data structures and constants Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 04/23] event/dlb: add definitions shared with LKM or shared code Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 05/23] event/dlb: add inline functions Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 06/23] event/dlb: add eventdev probe Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 07/23] event/dlb: add flexible interface Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 08/23] event/dlb: add probe-time hardware init Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 09/23] event/dlb: add xstats Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 10/23] event/dlb: add infos get and configure Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 11/23] event/dlb: add queue and port default conf Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 12/23] event/dlb: add queue setup Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 13/23] event/dlb: add port setup Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 14/23] event/dlb: add port link Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 15/23] event/dlb: add port unlink and port unlinks in progress Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 16/23] event/dlb: add eventdev start Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 17/23] event/dlb: add enqueue and its burst variants Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 18/23] event/dlb: add dequeue " Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 19/23] event/dlb: add eventdev stop and close Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 20/23] event/dlb: add PMD's token pop public interface Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 21/23] event/dlb: add PMD self-tests Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 22/23] event/dlb: add queue and port release Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 23/23] event/dlb: add timeout ticks entry point Timothy McDaniel 2020-07-30 19:49 ` [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro McDaniel, Timothy 2020-08-11 17:48 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 03/27] event/dlb: add shared code version 10.7.9 McDaniel, Timothy 2020-08-11 18:22 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran 2020-07-30 19:49 ` [dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure McDaniel, Timothy 2020-08-11 18:24 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation McDaniel, Timothy 2020-08-11 18:26 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging McDaniel, Timothy 2020-08-11 18:27 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 09/27] event/dlb: add inline functions used in multiple files McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 13/27] event/dlb: add xstats support McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 15/27] event/dlb: add probe McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 18/27] event/dlb: add queue setup McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 19/27] event/dlb: add port_setup McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 20/27] event/dlb: add port_link McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close McDaniel, Timothy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1603477952-583-1-git-send-email-timothy.mcdaniel@intel.com \ --to=timothy.mcdaniel@intel.com \ --cc=dev@dpdk.org \ --cc=erik.g.carrillo@intel.com \ --cc=gage.eads@intel.com \ --cc=harry.van.haaren@intel.com \ --cc=jerinj@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git