From: "Eads, Gage" <gage.eads@intel.com> To: "McDaniel, Timothy" <timothy.mcdaniel@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Carrillo, Erik G" <erik.g.carrillo@intel.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com>, "jerinj@marvell.com" <jerinj@marvell.com> Subject: Re: [dpdk-dev] [PATCH v5 11/22] event/dlb: add port setup Date: Tue, 20 Oct 2020 20:06:50 +0000 Message-ID: <SN6PR11MB25745FC7487034E388EDBAE1F61F0@SN6PR11MB2574.namprd11.prod.outlook.com> (raw) In-Reply-To: <1602961456-17392-12-git-send-email-timothy.mcdaniel@intel.com> [...] > +static int > +dlb_pf_ldb_port_create(struct dlb_hw_dev *handle, > + struct dlb_create_ldb_port_args *cfg, > + enum dlb_cq_poll_modes poll_mode) > +{ > + struct dlb_dev *dlb_dev = (struct dlb_dev *)handle->pf_dev; > + struct dlb_cmd_response response = {0}; > + int ret; > + uint8_t *port_base; > + const struct rte_memzone *mz; > + int alloc_sz, qe_sz, cq_alloc_depth; > + rte_iova_t pp_dma_base; > + rte_iova_t pc_dma_base; > + rte_iova_t cq_dma_base; > + int is_dir = false; > + > + DLB_INFO(dev->dlb_device, "Entering %s()\n", __func__); > + > + if (poll_mode == DLB_CQ_POLL_MODE_STD) > + qe_sz = sizeof(struct dlb_dequeue_qe); > + else > + qe_sz = RTE_CACHE_LINE_SIZE; > + > + /* The hardware always uses a CQ depth of at least > + * DLB_MIN_HARDWARE_CQ_DEPTH, even though from the user > + * perspective we support a depth as low as 1 for LDB ports. > + */ > + cq_alloc_depth = RTE_MAX(cfg->cq_depth, > DLB_MIN_HARDWARE_CQ_DEPTH); > + > + /* Calculate the port memory required, including two cache lines for > + * credit pop counts. Round up to the nearest cache line. > + */ > + alloc_sz = 2 * RTE_CACHE_LINE_SIZE + cq_alloc_depth * qe_sz; > + alloc_sz = RTE_CACHE_LINE_ROUNDUP(alloc_sz); > + > + port_base = dlb_alloc_coherent_aligned(&mz, &pc_dma_base, > + alloc_sz, PAGE_SIZE); > + if (port_base == NULL) > + return -ENOMEM; > + > + /* Lock the page in memory */ > + ret = rte_mem_lock_page(port_base); > + if (ret < 0) { > + DLB_LOG_ERR("dlb pf pmd could not lock page for device i/o\n"); > + goto create_port_err; > + } > + > + memset(port_base, 0, alloc_sz); > + cq_dma_base = (uintptr_t)(pc_dma_base + (2 * > RTE_CACHE_LINE_SIZE)); > + > + ret = dlb_hw_create_ldb_port(&dlb_dev->hw, > + handle->domain_id, > + cfg, > + pc_dma_base, > + cq_dma_base, > + &response); > + if (ret) > + goto create_port_err; > + > + pp_dma_base = (uintptr_t)dlb_dev->hw.func_kva + PP_BASE(is_dir); > + dlb_port[response.id][DLB_LDB].pp_addr = > + (void *)(uintptr_t)(pp_dma_base + (PAGE_SIZE * response.id)); > + > + dlb_port[response.id][DLB_LDB].cq_base = > + (void *)(uintptr_t)(port_base + (2 * RTE_CACHE_LINE_SIZE)); > + > + dlb_port[response.id][DLB_LDB].ldb_popcount = > + (void *)(uintptr_t)port_base; > + dlb_port[response.id][DLB_LDB].dir_popcount = (void *)(uintptr_t) > + (port_base + RTE_CACHE_LINE_SIZE); > + dlb_port[response.id][DLB_LDB].mz = mz; > + > + *(struct dlb_cmd_response *)cfg->response = response; > + > + DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, > ret); > + > +create_port_err: Need to free the memzone if the PMD jumps to this label > + > + return ret; > +} > + > +static int > +dlb_pf_dir_port_create(struct dlb_hw_dev *handle, > + struct dlb_create_dir_port_args *cfg, > + enum dlb_cq_poll_modes poll_mode) > +{ > + struct dlb_dev *dlb_dev = (struct dlb_dev *)handle->pf_dev; > + struct dlb_cmd_response response = {0}; > + int ret; > + uint8_t *port_base; > + const struct rte_memzone *mz; > + int alloc_sz, qe_sz; > + rte_iova_t pp_dma_base; > + rte_iova_t pc_dma_base; > + rte_iova_t cq_dma_base; > + int is_dir = true; > + > + DLB_INFO(dev->dlb_device, "Entering %s()\n", __func__); > + > + if (poll_mode == DLB_CQ_POLL_MODE_STD) > + qe_sz = sizeof(struct dlb_dequeue_qe); > + else > + qe_sz = RTE_CACHE_LINE_SIZE; > + > + /* Calculate the port memory required, including two cache lines for > + * credit pop counts. Round up to the nearest cache line. > + */ > + alloc_sz = 2 * RTE_CACHE_LINE_SIZE + cfg->cq_depth * qe_sz; > + alloc_sz = RTE_CACHE_LINE_ROUNDUP(alloc_sz); > + > + port_base = dlb_alloc_coherent_aligned(&mz, &pc_dma_base, > + alloc_sz, PAGE_SIZE); > + if (port_base == NULL) > + return -ENOMEM; > + > + /* Lock the page in memory */ > + ret = rte_mem_lock_page(port_base); > + if (ret < 0) { > + DLB_LOG_ERR("dlb pf pmd could not lock page for device i/o\n"); > + goto create_port_err; > + } > + > + memset(port_base, 0, alloc_sz); > + cq_dma_base = (uintptr_t)(pc_dma_base + (2 * > RTE_CACHE_LINE_SIZE)); > + > + ret = dlb_hw_create_dir_port(&dlb_dev->hw, > + handle->domain_id, > + cfg, > + pc_dma_base, > + cq_dma_base, > + &response); > + if (ret) > + goto create_port_err; > + > + pp_dma_base = (uintptr_t)dlb_dev->hw.func_kva + PP_BASE(is_dir); > + dlb_port[response.id][DLB_DIR].pp_addr = > + (void *)(uintptr_t)(pp_dma_base + (PAGE_SIZE * response.id)); > + > + dlb_port[response.id][DLB_DIR].cq_base = > + (void *)(uintptr_t)(port_base + (2 * RTE_CACHE_LINE_SIZE)); > + > + dlb_port[response.id][DLB_DIR].ldb_popcount = > + (void *)(uintptr_t)port_base; > + dlb_port[response.id][DLB_DIR].dir_popcount = (void *)(uintptr_t) > + (port_base + RTE_CACHE_LINE_SIZE); > + dlb_port[response.id][DLB_DIR].mz = mz; > + > + *(struct dlb_cmd_response *)cfg->response = response; > + > + DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, > ret); > + > +create_port_err: > + Ditto Thanks, Gage
next prev parent reply other threads:[~2020-10-20 20:08 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1593232671-5690-0-git-send-email-timothy.mcdaniel@intel.com> 2020-07-30 19:49 ` [dpdk-dev] [PATCH 00/27] Add Intel DLM PMD to 20.11 McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites McDaniel, Timothy 2020-08-11 17:44 ` Jerin Jacob 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 00/22] Add DLB PMD Timothy McDaniel 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 01/22] event/dlb: add documentation and meson infrastructure Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 02/22] event/dlb: add dynamic logging Timothy McDaniel 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 03/22] event/dlb: add private data structures and constants Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 04/22] event/dlb: add definitions shared with LKM or shared code Timothy McDaniel 2020-10-17 19:03 ` [dpdk-dev] [PATCH v5 05/22] event/dlb: add inline functions Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 06/22] event/dlb: add probe Timothy McDaniel 2020-10-18 12:49 ` Jerin Jacob 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 07/22] event/dlb: add xstats Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 08/22] event/dlb: add infos get and configure Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 09/22] event/dlb: add queue and port default conf Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 10/22] event/dlb: add queue setup Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 11/22] event/dlb: add port setup Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage [this message] 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 12/22] event/dlb: add port link Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 13/22] event/dlb: add port unlink and port unlinks in progress Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 14/22] event/dlb: add eventdev start Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 15/22] event/dlb: add enqueue and its burst variants Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 16/22] event/dlb: add dequeue " Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 17/22] event/dlb: add eventdev stop and close Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 18/22] event/dlb: add PMD's token pop public interface Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 19/22] event/dlb: add PMD self-tests Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 20/22] event/dlb: add queue and port release Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 21/22] event/dlb: add timeout ticks entry point Timothy McDaniel 2020-10-17 19:04 ` [dpdk-dev] [PATCH v5 22/22] doc: Add new DLB eventdev driver to relnotes Timothy McDaniel 2020-10-20 20:06 ` Eads, Gage 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 00/23] Add DLB PMD Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 01/23] event/dlb: add documentation and meson infrastructure Timothy McDaniel 2020-10-24 13:05 ` Jerin Jacob 2020-10-26 16:02 ` McDaniel, Timothy 2020-10-24 14:05 ` Thomas Monjalon 2020-10-26 16:12 ` McDaniel, Timothy 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 02/23] event/dlb: add dynamic logging Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 03/23] event/dlb: add private data structures and constants Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 04/23] event/dlb: add definitions shared with LKM or shared code Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 05/23] event/dlb: add inline functions Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 06/23] event/dlb: add eventdev probe Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 07/23] event/dlb: add flexible interface Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 08/23] event/dlb: add probe-time hardware init Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 09/23] event/dlb: add xstats Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 10/23] event/dlb: add infos get and configure Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 11/23] event/dlb: add queue and port default conf Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 12/23] event/dlb: add queue setup Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 13/23] event/dlb: add port setup Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 14/23] event/dlb: add port link Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 15/23] event/dlb: add port unlink and port unlinks in progress Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 16/23] event/dlb: add eventdev start Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 17/23] event/dlb: add enqueue and its burst variants Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 18/23] event/dlb: add dequeue " Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 19/23] event/dlb: add eventdev stop and close Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 20/23] event/dlb: add PMD's token pop public interface Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 21/23] event/dlb: add PMD self-tests Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 22/23] event/dlb: add queue and port release Timothy McDaniel 2020-10-23 18:32 ` [dpdk-dev] [PATCH v6 23/23] event/dlb: add timeout ticks entry point Timothy McDaniel 2020-07-30 19:49 ` [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro McDaniel, Timothy 2020-08-11 17:48 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 03/27] event/dlb: add shared code version 10.7.9 McDaniel, Timothy 2020-08-11 18:22 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran 2020-07-30 19:49 ` [dpdk-dev] [PATCH 04/27] event/dlb: add make and meson build infrastructure McDaniel, Timothy 2020-08-11 18:24 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 05/27] event/dlb: add DLB documentation McDaniel, Timothy 2020-08-11 18:26 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging McDaniel, Timothy 2020-08-11 18:27 ` Jerin Jacob 2020-07-30 19:49 ` [dpdk-dev] [PATCH 07/27] event/dlb: add private data structures and constants McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 08/27] event/dlb: add definitions shared with LKM or shared code McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 09/27] event/dlb: add inline functions used in multiple files McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 10/27] event/dlb: add PFPMD-specific interface layer to shared code McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 11/27] event/dlb: add flexible PMD to device interfaces McDaniel, Timothy 2020-07-30 19:49 ` [dpdk-dev] [PATCH 12/27] event/dlb: add the PMD's public interfaces McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 13/27] event/dlb: add xstats support McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 15/27] event/dlb: add probe McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 16/27] event/dlb: add infos_get and configure McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 17/27] event/dlb: add queue_def_conf and port_def_conf McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 18/27] event/dlb: add queue setup McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 19/27] event/dlb: add port_setup McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 20/27] event/dlb: add port_link McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 21/27] event/dlb: add queue_release and port_release McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 22/27] event/dlb: add port_unlink and port_unlinks_in_progress McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 23/27] event/dlb: add eventdev_start McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 24/27] event/dlb: add timeout_ticks, dump, xstats, and selftest McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 25/27] event/dlb: add enqueue and its burst variants McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 26/27] event/dlb: add dequeue, dequeue_burst, and variants McDaniel, Timothy 2020-07-30 19:50 ` [dpdk-dev] [PATCH 27/27] event/dlb: add eventdev_stop and eventdev_close McDaniel, Timothy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR11MB25745FC7487034E388EDBAE1F61F0@SN6PR11MB2574.namprd11.prod.outlook.com \ --to=gage.eads@intel.com \ --cc=dev@dpdk.org \ --cc=erik.g.carrillo@intel.com \ --cc=harry.van.haaren@intel.com \ --cc=jerinj@marvell.com \ --cc=timothy.mcdaniel@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git