DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bus/pci/windows: support for PCI scan allowed and blocked lists
@ 2021-02-18  5:40 Khoa To
  2021-02-18 18:40 ` [dpdk-dev] [PATCH v2] " Khoa To
  0 siblings, 1 reply; 4+ messages in thread
From: Khoa To @ 2021-02-18  5:40 UTC (permalink / raw)
  To: dev; +Cc: dmitry.kozliuk, pallavi.kadam

From: Khoa To <khot@microsoft.com>

EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan.  This evaluation is missing in the Windows implementation of rte_pci_scan.
This patch provides this missing functionality, so that apps can specify which NetUIO devices to ignore during PCI bus scan.

Signed-off-by: Khoa To <khot@microsoft.com>
---
 drivers/bus/pci/windows/pci.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
index f66258452..0bba05eb4 100644
--- a/drivers/bus/pci/windows/pci.c
+++ b/drivers/bus/pci/windows/pci.c
@@ -396,6 +396,7 @@ rte_pci_scan(void)
 	DWORD device_index = 0, found_device = 0;
 	HDEVINFO dev_info;
 	SP_DEVINFO_DATA device_info_data;
+	struct rte_pci_addr addr;
 
 	/* for debug purposes, PCI can be disabled */
 	if (!rte_eal_has_pci())
@@ -420,6 +421,13 @@ rte_pci_scan(void)
 		    &GUID_DEVCLASS_NET) ||
 			IsEqualGUID(&(device_info_data.ClassGuid),
 			    &GUID_DEVCLASS_NETUIO)) {
+
+			if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0)
+				continue;
+
+			if (rte_pci_ignore_device(&addr))
+				continue;
+
 			ret = pci_scan_one(dev_info, &device_info_data);
 			if (ret == ERROR_SUCCESS)
 				found_device++;
-- 
2.29.0.vfs.0.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists
  2021-02-18  5:40 [dpdk-dev] [PATCH] bus/pci/windows: support for PCI scan allowed and blocked lists Khoa To
@ 2021-02-18 18:40 ` Khoa To
  2021-02-18 18:53   ` Ranjit Menon
  0 siblings, 1 reply; 4+ messages in thread
From: Khoa To @ 2021-02-18 18:40 UTC (permalink / raw)
  To: dev; +Cc: dmitry.kozliuk, pallavi.kadam

EAL -a and -b options are used to specify which PCI devices are
explicitly allowed or blocked during PCI bus scan.  This evaluation
is missing in the Windows implementation of rte_pci_scan.
This patch provides this missing functionality, so that apps can specify
which NetUIO devices to ignore during PCI bus scan.

Signed-off-by: Khoa To <khot@linux.microsoft.com>
---

v2:
* Truncate commit description lines to 75 charaters or less


 drivers/bus/pci/windows/pci.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
index f66258452..0bba05eb4 100644
--- a/drivers/bus/pci/windows/pci.c
+++ b/drivers/bus/pci/windows/pci.c
@@ -396,6 +396,7 @@ rte_pci_scan(void)
 	DWORD device_index = 0, found_device = 0;
 	HDEVINFO dev_info;
 	SP_DEVINFO_DATA device_info_data;
+	struct rte_pci_addr addr;
 
 	/* for debug purposes, PCI can be disabled */
 	if (!rte_eal_has_pci())
@@ -420,6 +421,13 @@ rte_pci_scan(void)
 		    &GUID_DEVCLASS_NET) ||
 			IsEqualGUID(&(device_info_data.ClassGuid),
 			    &GUID_DEVCLASS_NETUIO)) {
+
+			if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0)
+				continue;
+
+			if (rte_pci_ignore_device(&addr))
+				continue;
+
 			ret = pci_scan_one(dev_info, &device_info_data);
 			if (ret == ERROR_SUCCESS)
 				found_device++;
-- 
2.29.0.vfs.0.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists
  2021-02-18 18:40 ` [dpdk-dev] [PATCH v2] " Khoa To
@ 2021-02-18 18:53   ` Ranjit Menon
  2021-02-18 21:23     ` Dmitry Kozlyuk
  0 siblings, 1 reply; 4+ messages in thread
From: Ranjit Menon @ 2021-02-18 18:53 UTC (permalink / raw)
  To: Khoa To, dev; +Cc: dmitry.kozliuk, pallavi.kadam

Hi Khoa,

On 2/18/2021 10:40 AM, Khoa To wrote:
> EAL -a and -b options are used to specify which PCI devices are
> explicitly allowed or blocked during PCI bus scan.  This evaluation
> is missing in the Windows implementation of rte_pci_scan.
> This patch provides this missing functionality, so that apps can specify
> which NetUIO devices to ignore during PCI bus scan.
>
> Signed-off-by: Khoa To <khot@linux.microsoft.com>
> ---
>
> v2:
> * Truncate commit description lines to 75 charaters or less
>
>
>   drivers/bus/pci/windows/pci.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index f66258452..0bba05eb4 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -396,6 +396,7 @@ rte_pci_scan(void)
>   	DWORD device_index = 0, found_device = 0;
>   	HDEVINFO dev_info;
>   	SP_DEVINFO_DATA device_info_data;
> +	struct rte_pci_addr addr;
>   
>   	/* for debug purposes, PCI can be disabled */
>   	if (!rte_eal_has_pci())
> @@ -420,6 +421,13 @@ rte_pci_scan(void)
>   		    &GUID_DEVCLASS_NET) ||
>   			IsEqualGUID(&(device_info_data.ClassGuid),
>   			    &GUID_DEVCLASS_NETUIO)) {
> +
> +			if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0)
> +				continue;
> +
> +			if (rte_pci_ignore_device(&addr))
> +				continue;
> +
>   			ret = pci_scan_one(dev_info, &device_info_data);
>   			if (ret == ERROR_SUCCESS)
>   				found_device++;
I think this change can be made inside the pci_scan_one() function where 
we already call

get_device_pci_address().

ranjit m.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists
  2021-02-18 18:53   ` Ranjit Menon
@ 2021-02-18 21:23     ` Dmitry Kozlyuk
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Kozlyuk @ 2021-02-18 21:23 UTC (permalink / raw)
  To: Ranjit Menon; +Cc: Khoa To, dev, pallavi.kadam

On Thu, 18 Feb 2021 10:53:54 -0800, Ranjit Menon wrote:
> > +
> > +			if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0)
> > +				continue;
> > +
> > +			if (rte_pci_ignore_device(&addr))
> > +				continue;
> > +
> >   			ret = pci_scan_one(dev_info, &device_info_data);
> >   			if (ret == ERROR_SUCCESS)
> >   				found_device++;  
> I think this change can be made inside the pci_scan_one() function where 
> we already call
> 
> get_device_pci_address().

+1, even to place this check before other actions in pci_scan_one().

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-18 21:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18  5:40 [dpdk-dev] [PATCH] bus/pci/windows: support for PCI scan allowed and blocked lists Khoa To
2021-02-18 18:40 ` [dpdk-dev] [PATCH v2] " Khoa To
2021-02-18 18:53   ` Ranjit Menon
2021-02-18 21:23     ` Dmitry Kozlyuk

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git