From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove duplicated offload display
Date: Wed, 24 Feb 2021 12:29:22 +0000 [thread overview]
Message-ID: <1d905352-0358-a395-b3bf-3f062a14d8a3@intel.com> (raw)
In-Reply-To: <CY4PR11MB1750CAE6C8AAB6CDD54CD90499B09@CY4PR11MB1750.namprd11.prod.outlook.com>
On 2/7/2021 1:58 AM, Li, Xiaoyun wrote:
>
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Friday, February 5, 2021 22:27
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>;
>> Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
>> Subject: [PATCH] app/testpmd: remove duplicated offload display
>>
>> "show port cap all|<port_id>" was to display offload configuration of port(s).
>>
>> But later two other commands added to show same information in more
>> accurate way:
>> show port (port_id) rx_offload configuration show port (port_id) tx_offload
>> configuration
>>
>> These new commands can both show port and queue level configuration, also
>> with their capabilities counterparts easier to see offload capability and
>> configuration of the port in similar syntax.
>>
>> So the functionality is duplicated and removing this version, to favor the new
>> commands.
>>
>> Another problem with this command is it requires each new offload to be added
>> into the function to display them, and there were missing offloads that are not
>> displayed, this requirement for sure will create gaps by time as new offloads
>> added.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-02-24 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 14:26 Ferruh Yigit
2021-02-05 16:40 ` Lance Richardson
2021-02-07 1:47 ` Li, Xiaoyun
2021-02-07 1:58 ` Li, Xiaoyun
2021-02-24 12:29 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d905352-0358-a395-b3bf-3f062a14d8a3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).