* [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx
@ 2017-05-04 15:43 Ferruh Yigit
2017-05-09 7:24 ` Olivier Matz
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-04 15:43 UTC (permalink / raw)
To: Tetsuya Mukawa; +Cc: dev, Ferruh Yigit, Olivier Matz
mbuf next and nb_segs fields already have the default values when get
from mempool, no need to update them in PMD.
See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/null/rte_eth_null.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index abf3ec7..2c94339 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
packet_size);
bufs[i]->data_len = (uint16_t)packet_size;
bufs[i]->pkt_len = packet_size;
- bufs[i]->nb_segs = 1;
- bufs[i]->next = NULL;
bufs[i]->port = h->internals->port_id;
}
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx
2017-05-04 15:43 [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx Ferruh Yigit
@ 2017-05-09 7:24 ` Olivier Matz
2017-05-12 11:59 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2017-05-09 7:24 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Tetsuya Mukawa, dev
On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> mbuf next and nb_segs fields already have the default values when get
> from mempool, no need to update them in PMD.
>
> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/null/rte_eth_null.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index abf3ec7..2c94339 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
> packet_size);
> bufs[i]->data_len = (uint16_t)packet_size;
> bufs[i]->pkt_len = packet_size;
> - bufs[i]->nb_segs = 1;
> - bufs[i]->next = NULL;
> bufs[i]->port = h->internals->port_id;
> }
>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx
2017-05-09 7:24 ` Olivier Matz
@ 2017-05-12 11:59 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-12 11:59 UTC (permalink / raw)
To: Olivier Matz; +Cc: Tetsuya Mukawa, dev
On 5/9/2017 8:24 AM, Olivier Matz wrote:
> On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> mbuf next and nb_segs fields already have the default values when get
>> from mempool, no need to update them in PMD.
>>
>> See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-12 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 15:43 [dpdk-dev] [PATCH] net/null: do not touch mbuf next or nb segs on Rx Ferruh Yigit
2017-05-09 7:24 ` Olivier Matz
2017-05-12 11:59 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).