From: <kkanas@marvell.com> To: <dev@dpdk.org>, <david.marchand@redhat.com>, <ferruh.yigit@linux.intel.com> Subject: Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest Date: Fri, 8 Nov 2019 11:21:32 +0100 Message-ID: <20191108102135.7249-1-kkanas@marvell.com> (raw) In-Reply-To: <CAJFAV8yQhQ2nqPKLzFvptLBqsZZChXbF-kK7uBJgqotrPEZrbg@mail.gmail.com> Hi David, Thanks for review, hopefully this patch will addresses most of the sutff. Rest I will address here. > > > + const char *procdir = "/proc/self/fd/"; > > self is a Linux thing. > This won't work on FreeBSD. IMHO original code didn't worked on FreeBSD as well. I have created function to adress in third patch > No need to set status, this (forked) process will panic. I am using status to save errno as it value can be overwritten on unlikely event of closedir failure. --- v3 changes: add missing closedir fix strtol string validation test removed empty line remove unecssary initalization add check for '.' and '..' to avoid errors in parsing entries fix commit message add FreeBSD function for closing files v2 changes: fix commit message Krzysztof Kanas (3): test: fix timeout in flags autotest test: move close files to separate function test: fix FreeBSD file closing function process.h | 183 ++++++++++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 138 insertions(+), 45 deletions(-)
next prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-02 7:52 [dpdk-dev] [PATCH] test: fix process dup fd close kkanas 2019-09-02 9:49 ` [dpdk-dev] [PATCH v2] " kkanas 2019-09-23 11:32 ` Krzysztof Kanas 2019-10-30 9:06 ` David Marchand 2019-11-04 7:52 ` [dpdk-dev] [EXT] " Krzysztof Kanas 2019-11-06 14:36 ` David Marchand 2019-11-06 14:58 ` [dpdk-dev] " David Marchand 2019-11-08 10:21 ` kkanas [this message] 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 1/3] test: fix timeout in flags autotest kkanas 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 2/3] test: move close files to separate function kkanas 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 3/3] test: fix FreeBSD file closing function kkanas 2019-11-08 11:05 ` [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest David Marchand 2019-11-08 11:11 ` David Marchand 2019-11-08 13:45 ` David Marchand 2019-11-12 8:26 ` [dpdk-dev] [EXT] " Krzysztof Kanas 2019-11-12 20:34 ` David Marchand 2019-11-13 13:35 ` Krzysztof Kanas 2019-11-12 20:31 ` [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process David Marchand 2019-11-14 19:31 ` Kevin Traynor 2019-11-15 8:11 ` David Marchand
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108102135.7249-1-kkanas@marvell.com \ --to=kkanas@marvell.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions Archives are clonable: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/ public-inbox