From: Krzysztof Kanas <kkanas@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Krzysztof Kanas <kkanas@marvell.com>, dev <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@linux.intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 0/3] test: fix timeout in flags autotest
Date: Wed, 13 Nov 2019 13:35:52 +0000 [thread overview]
Message-ID: <38f1713f-8df7-279c-b038-a23e73908a23@marvell.com> (raw)
In-Reply-To: <CAJFAV8xuQBc8pjszuwrE2HFThuotPhK7WvQeR+coTxLan-6Pbw@mail.gmail.com>
On 12/11/2019 21:34, David Marchand wrote:
> On Tue, Nov 12, 2019 at 9:29 AM Krzysztof Kanas <kkanas@marvell.com> wrote:
>> On 19-11-08 14:45, David Marchand wrote:
>>> External Email
>>>
>>> ----------------------------------------------------------------------
>>> On Fri, Nov 8, 2019 at 12:05 PM David Marchand
>>> <david.marchand@redhat.com> wrote:
>>>> On Fri, Nov 8, 2019 at 11:21 AM <kkanas@marvell.com> wrote:
>>>>> Hi David,
>>>>>
>>>>> Thanks for review, hopefully this patch will addresses most of the sutff.
>>>>> Rest I will address here.
>>>>>
>>>>>>> + const char *procdir = "/proc/self/fd/";
>>>>>> self is a Linux thing.
>>>>>> This won't work on FreeBSD.
>>>>> IMHO original code didn't worked on FreeBSD as well.
>>>>> I have created function to adress in third patch
>>>> Indeed...
>>>>
>>>> Well, wait.
>>>> Why do we need to close those file descriptors?
>>>> FreeBSD has been like this for quite some time.
>>> We don't know what this is used for.
>>>
>>> We know it does not work on FreeBSD, but this does not seem to be a problem.
>>> Introducing something more on FreeBSD is a risk with no actual benefit
>>> at first sight.
>> Ok.
>>
>>> Either we take only the first patch under a #ifdef EXEC_ENV_LINUX or
>>> we leave this as is.
>> I would like have that because ARM64 is main platform for me and this
>> makes the test pass, and fixes the difference between the comment and
>> the code.
>>> Krzystof, is this a problem for you if we postpone and investigate
>>> further for 20.02?
>> Not a problem. I would like to have fix for EXEC_ENV_LINUX for now.
>> Rest, FreeBSD case and the decisions weather this whole code should be
>> deleted can be made later.
> In my tests of the original code, I never saw anything but access -1 ENOENT.
> Anyway, just sent a v4, your v3 patch, with just cosmetics and
> commitlog updated.
ACK. Tested, the v4 patch works fine.
>
>
--
Best Regards
--
Krzysztof Kanas kkanas@marvell.com
next prev parent reply other threads:[~2019-11-13 13:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 7:52 [dpdk-dev] [PATCH] test: fix process dup fd close kkanas
2019-09-02 9:49 ` [dpdk-dev] [PATCH v2] " kkanas
2019-09-23 11:32 ` Krzysztof Kanas
2019-10-30 9:06 ` David Marchand
2019-11-04 7:52 ` [dpdk-dev] [EXT] " Krzysztof Kanas
2019-11-06 14:36 ` David Marchand
2019-11-06 14:58 ` [dpdk-dev] " David Marchand
2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest kkanas
2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 1/3] " kkanas
2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 2/3] test: move close files to separate function kkanas
2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 3/3] test: fix FreeBSD file closing function kkanas
2019-11-08 11:05 ` [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest David Marchand
2019-11-08 11:11 ` David Marchand
2019-11-08 13:45 ` David Marchand
2019-11-12 8:26 ` [dpdk-dev] [EXT] " Krzysztof Kanas
2019-11-12 20:34 ` David Marchand
2019-11-13 13:35 ` Krzysztof Kanas [this message]
2019-11-12 20:31 ` [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process David Marchand
2019-11-14 19:31 ` Kevin Traynor
2019-11-15 8:11 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f1713f-8df7-279c-b038-a23e73908a23@marvell.com \
--to=kkanas@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).