From: David Marchand <david.marchand@redhat.com> To: Krzysztof Kanas <kkanas@marvell.com> Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>, Kevin Traynor <ktraynor@redhat.com> Subject: [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process Date: Fri, 15 Nov 2019 09:11:37 +0100 Message-ID: <f3fe38d3-2f00-92d5-8165-a324984c3e50@redhat.com> (raw) In-Reply-To: <de643714-ff74-53bc-0ed0-b28e92eb9c66@redhat.com> On Thu, Nov 14, 2019 at 8:32 PM Kevin Traynor <ktraynor@redhat.com> wrote: > > On 12/11/2019 20:31, David Marchand wrote: > > From: Krzysztof Kanas <kkanas@marvell.com> > > > > Caught while investigating timeouts on a ARM64 server. > > > > Stracing a test process running the eal_flags_autotest, we can see that > > the fork helper is checking all possible file descriptors from > > getdtablesize() to 2, and close the existing ones. > > We can do better by inspecting this forked process /proc/self/fd > > directory. > > > > Besides, checking file descriptors via /proc/self/fd only makes sense for > > Linux. This code was a noop on FreeBSD. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Krzysztof Kanas <kkanas@marvell.com> > > Signed-off-by: David Marchand <david.marchand@redhat.com> Tested-by: Krzysztof Kanas <kkanas@marvell.com> > Seems to be an improvement on what is existing. > > Acked-by: Kevin Traynor <ktraynor@redhat.com> > Applied, thanks. -- David Marchand
prev parent reply other threads:[~2019-11-15 8:11 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-02 7:52 [dpdk-dev] [PATCH] test: fix process dup fd close kkanas 2019-09-02 9:49 ` [dpdk-dev] [PATCH v2] " kkanas 2019-09-23 11:32 ` Krzysztof Kanas 2019-10-30 9:06 ` David Marchand 2019-11-04 7:52 ` [dpdk-dev] [EXT] " Krzysztof Kanas 2019-11-06 14:36 ` David Marchand 2019-11-06 14:58 ` [dpdk-dev] " David Marchand 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest kkanas 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 1/3] " kkanas 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 2/3] test: move close files to separate function kkanas 2019-11-08 10:21 ` [dpdk-dev] [PATCH v3 3/3] test: fix FreeBSD file closing function kkanas 2019-11-08 11:05 ` [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest David Marchand 2019-11-08 11:11 ` David Marchand 2019-11-08 13:45 ` David Marchand 2019-11-12 8:26 ` [dpdk-dev] [EXT] " Krzysztof Kanas 2019-11-12 20:34 ` David Marchand 2019-11-13 13:35 ` Krzysztof Kanas 2019-11-12 20:31 ` [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process David Marchand 2019-11-14 19:31 ` Kevin Traynor 2019-11-15 8:11 ` David Marchand [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f3fe38d3-2f00-92d5-8165-a324984c3e50@redhat.com \ --to=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=kkanas@marvell.com \ --cc=ktraynor@redhat.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git