DPDK patches and discussions
 help / color / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: zhihongx.peng@intel.com
Cc: xiaolong.ye@intel.com, wenzhuo.lu@intel.com,
	konstantin.ananyev@intel.com, dev@dpdk.org,
	liang-min.wang@intel.com
Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD
Date: Thu, 26 Mar 2020 15:01:50 -0700
Message-ID: <20200326150150.6ac5829f@hermes.lan> (raw)
In-Reply-To: <20200325033111.9650-1-zhihongx.peng@intel.com>

On Tue, 24 Mar 2020 23:31:11 -0400
zhihongx.peng@intel.com wrote:

> +/*BSD has no interrupt mechanism, so force NIC status synchronization.*/
> +#ifdef RTE_EXEC_ENV_FREEBSD
> +	wait = 1;
> +#endif
> +

Please format comments correctly.
Is there a better way to detect interrupt mechanism with a function?
#ifdef's make for hard to maintain code.


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  3:31 zhihongx.peng
2020-03-26 22:01 ` Stephen Hemminger [this message]
2020-03-25  7:32 zhihongx.peng

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200326150150.6ac5829f@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=liang-min.wang@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaolong.ye@intel.com \
    --cc=zhihongx.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox