From: Fidaullah Noonari <fidaullah.noonari@emumba.com>
To: stephen@networkplumber.org
Cc: dev@dpdk.org, Fidaullah Noonari <fidaullah.noonari@emumba.com>
Subject: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind
Date: Mon, 21 Mar 2022 17:27:27 +0500 [thread overview]
Message-ID: <20220321122727.614290-1-fidaullah.noonari@emumba.com> (raw)
In-Reply-To: <20220315062652.78332-1-fidaullah.noonari@emumba.com>
binding with vfio driver, when IOMMU is disabled, causes program to crash.
this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is
disabled, it changes vfio into unsafe noiommu mode and prints warning
message.
Signed-off-by: Fidaullah Noonari <fidaullah.noonari@emumba.com>
---
usertools/dpdk-devbind.py | 47 +++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index ace4627218..e2181efac8 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -96,6 +96,7 @@
b_flag = None
status_flag = False
force_flag = False
+noiommu_flag = False
args = []
@@ -466,6 +467,39 @@ def unbind_all(dev_list, force=False):
unbind_one(d, force)
+def has_iommu():
+ """Check if IOMMU is enabled on system"""
+ return len(os.listdir("/sys/class/iommu")) > 0
+
+
+def check_noiommu_mode():
+ """checks and enables the noiommu mode for vfio drivers"""
+ global noiommu_flag
+ filename = "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode"
+
+ try:
+ with open(filename,"r") as f:
+ if f.read(1) == "1":
+ return
+ except OSError as err:
+ sys.exit("Error: failed to enable unsafe noiommu mode - Cannot open %s: %s"
+ % (filename, err))
+
+ if not noiommu_flag:
+ print("Error: failed to bind vfio-pci - IOMMU support is disabled")
+ print("Info: use --noiommu-mode for binding in noiommu mode")
+ sys.exit()
+
+ try:
+ with open(filename, "w") as f:
+ f.write("1")
+ f.close()
+ except OSError as err:
+ sys.exit("Error: failed to enable unsafe noiommu mode - Cannot open %s: %s"
+ % (filename, err))
+ print("Warning: enabling unsafe no IOMMU mode for vfio drivers")
+
+
def bind_all(dev_list, driver, force=False):
"""Bind method, takes a list of device locations"""
global devices
@@ -492,6 +526,10 @@ def bind_all(dev_list, driver, force=False):
except ValueError as ex:
sys.exit(ex)
+ # check for IOMMU support
+ if driver == "vfio-pci" and not has_iommu():
+ check_noiommu_mode()
+
for d in dev_list:
bind_one(d, driver, force)
@@ -634,6 +672,7 @@ def parse_args():
global status_flag
global status_dev
global force_flag
+ global noiommu_flag
global args
parser = argparse.ArgumentParser(
@@ -687,6 +726,12 @@ def parse_args():
Override restriction on binding devices in use by Linux"
WARNING: This can lead to loss of network connection and should be used with caution.
""")
+ parser.add_argument(
+ '--noiommu-mode',
+ action='store_true',
+ help="""
+if IOMMU is not available, Enables no IOMMU mode for vfio drivers.
+ """)
parser.add_argument(
'devices',
metavar='DEVICE',
@@ -706,6 +751,8 @@ def parse_args():
status_dev = "all"
if opt.force:
force_flag = True
+ if opt.noiommu_mode:
+ noiommu_flag = True
if opt.bind:
b_flag = opt.bind
elif opt.unbind:
--
2.25.1
next prev parent reply other threads:[~2022-03-21 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 6:26 [PATCH v2] " Fidaullah Noonari
2022-03-15 9:17 ` Bruce Richardson
2022-03-21 12:27 ` Fidaullah Noonari [this message]
2022-03-31 14:37 ` [PATCH v3] " Burakov, Anatoly
2022-03-31 14:44 ` Bruce Richardson
2022-10-10 23:02 ` Thomas Monjalon
2022-10-12 12:38 ` [PATCH v4] " Fidaullah Noonari
2024-07-01 17:51 ` Stephen Hemminger
2024-10-02 18:13 ` [PATCH] usertools/devbind: add support for non-IOMMU mode Stephen Hemminger
2024-10-03 9:27 ` Bruce Richardson
2024-10-17 15:34 ` Thomas Monjalon
2023-07-06 18:22 ` [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind Stephen Hemminger
2023-10-31 18:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321122727.614290-1-fidaullah.noonari@emumba.com \
--to=fidaullah.noonari@emumba.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).