DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Fidaullah Noonari <fidaullah.noonari@emumba.com>,
	<stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind
Date: Thu, 31 Mar 2022 15:37:40 +0100	[thread overview]
Message-ID: <518e43f6-29d6-b86e-aa48-83868d0f8d25@intel.com> (raw)
In-Reply-To: <20220321122727.614290-1-fidaullah.noonari@emumba.com>

On 21-Mar-22 12:27 PM, Fidaullah Noonari wrote:
> binding with vfio driver, when IOMMU is disabled, causes program to crash.
> this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is
> disabled, it changes vfio into unsafe noiommu mode and prints warning
> message.
> 
> Signed-off-by: Fidaullah Noonari <fidaullah.noonari@emumba.com>
> ---

Hi,

> +def check_noiommu_mode():
> +    """checks and enables the noiommu mode for vfio drivers"""
> +    global noiommu_flag
> +    filename = "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode"
> +
> +    try:
> +        with open(filename,"r") as f:
> +            if f.read(1) == "1":
> +                return
> +    except OSError as err:
> +        sys.exit("Error: failed to enable unsafe noiommu mode - Cannot open %s: %s"
> +                % (filename, err))

Nitpick, but maybe use f-strings instead of old-school string interpolation?

> +
> +    if not noiommu_flag:
> +        print("Error: failed to bind vfio-pci - IOMMU support is disabled")
> +        print("Info: use --noiommu-mode for binding in noiommu mode")
> +        sys.exit()
> +
> +    try:
> +        with open(filename, "w") as f:
> +            f.write("1")
> +            f.close()
> +    except OSError as err:
> +        sys.exit("Error: failed to enable unsafe noiommu mode - Cannot open %s: %s"
> +                % (filename, err))

Same as above.

Otherwise LGTM,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  reply	other threads:[~2022-03-31 14:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  6:26 [PATCH v2] " Fidaullah Noonari
2022-03-15  9:17 ` Bruce Richardson
2022-03-21 12:27 ` [PATCH v3] " Fidaullah Noonari
2022-03-31 14:37   ` Burakov, Anatoly [this message]
2022-03-31 14:44     ` Bruce Richardson
2022-10-10 23:02       ` Thomas Monjalon
2022-10-12 12:38   ` [PATCH v4] " Fidaullah Noonari
2024-07-01 17:51     ` Stephen Hemminger
2024-10-02 18:13     ` [PATCH] usertools/devbind: add support for non-IOMMU mode Stephen Hemminger
2024-10-03  9:27       ` Bruce Richardson
2024-10-17 15:34         ` Thomas Monjalon
2023-07-06 18:22   ` [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind Stephen Hemminger
2023-10-31 18:34   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518e43f6-29d6-b86e-aa48-83868d0f8d25@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=fidaullah.noonari@emumba.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).