From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: cristian.dumitrescu@intel.com, thomas@monjalon.net, dev@dpdk.org,
Chengwen Feng <fengchengwen@huawei.com>
Subject: Re: [PATCH 0/4] cfgfile: enhance error detecting
Date: Thu, 4 Jul 2024 17:29:51 -0700 [thread overview]
Message-ID: <20240704172951.1cb43fd5@hermes.local> (raw)
In-Reply-To: <20240704171433.4c96f9f6@hermes.local>
On Thu, 4 Jul 2024 17:14:33 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> On Thu, 4 Jul 2024 17:12:56 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Tue, Feb 20, 2024 at 5:00 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
> > >
> > > When I was trying to debug a problem introduced by config.ini in
> > > test-dma-perf, I found the cfgfile library should enhance error
> > > detecting, so got this patchset.
> > >
> > > Chengwen Feng (4):
> > > cfgfile: remove dead code
> > > cfgfile: support verify name and value
> > > cfgfile: verify add section and entry result
> > > cfgfile: add unique name flag
> > >
> > > lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
> > > lib/cfgfile/rte_cfgfile.h | 7 ++++
> > > 2 files changed, 59 insertions(+), 18 deletions(-)
> >
> > Please review.
> >
> >
>
>
> Somewhat related, why is the cfgfile test disabled?
> The line for test_cfgfile is commented out in app/test/meson.build
The existing test won't build because of broken resource stuff which is
also not built. Probably best to yank the whole test and resource stuff
out until Christian fixes it.
next prev parent reply other threads:[~2024-07-05 0:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 3:58 Chengwen Feng
2024-02-20 3:58 ` [PATCH 1/4] cfgfile: remove dead code Chengwen Feng
2024-07-04 21:28 ` Stephen Hemminger
2024-02-20 3:58 ` [PATCH 2/4] cfgfile: support verify name and value Chengwen Feng
2024-07-04 21:29 ` Stephen Hemminger
2024-02-20 3:58 ` [PATCH 3/4] cfgfile: verify add section and entry result Chengwen Feng
2024-07-04 21:30 ` Stephen Hemminger
2024-02-20 3:58 ` [PATCH 4/4] cfgfile: add unique name flag Chengwen Feng
2024-07-04 21:36 ` Stephen Hemminger
2024-07-05 9:37 ` fengchengwen
2024-07-04 15:12 ` [PATCH 0/4] cfgfile: enhance error detecting David Marchand
2024-07-05 0:14 ` Stephen Hemminger
2024-07-05 0:29 ` Stephen Hemminger [this message]
2024-07-04 21:40 ` Stephen Hemminger
2024-07-05 8:39 ` Bruce Richardson
2024-07-05 9:31 ` [PATCH v2 " Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 1/4] cfgfile: remove dead code Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 2/4] cfgfile: support verify name and value Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 3/4] cfgfile: verify add section and entry result Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 4/4] cfgfile: add strict parse flag Chengwen Feng
2024-09-06 1:03 ` [PATCH v2 0/4] cfgfile: enhance error detecting fengchengwen
2024-10-09 22:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704172951.1cb43fd5@hermes.local \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).