From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Chengwen Feng <fengchengwen@huawei.com>, <thomas@monjalon.net>,
<dev@dpdk.org>, <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH 0/4] cfgfile: enhance error detecting
Date: Fri, 5 Jul 2024 09:39:33 +0100 [thread overview]
Message-ID: <ZoexRUAKDxSpZzkp@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240704144055.524c65e0@hermes.local>
On Thu, Jul 04, 2024 at 02:40:55PM -0700, Stephen Hemminger wrote:
> On Tue, 20 Feb 2024 03:58:36 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> > When I was trying to debug a problem introduced by config.ini in
> > test-dma-perf, I found the cfgfile library should enhance error
> > detecting, so got this patchset.
> >
> > Chengwen Feng (4):
> > cfgfile: remove dead code
> > cfgfile: support verify name and value
> > cfgfile: verify add section and entry result
> > cfgfile: add unique name flag
> >
> > lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
> > lib/cfgfile/rte_cfgfile.h | 7 ++++
> > 2 files changed, 59 insertions(+), 18 deletions(-)
> >
>
>
> The existing cfgfile in DPDK is quite limited, and there are better
> libraries available; not sure why a reinvention was necessary.
>
At the time, it was done to avoid having additional external dependencies.
Since then, it's generally been relatively trouble free, so it's never been
felt worth the effort to replace, I suspect.
/Bruce
next prev parent reply other threads:[~2024-07-05 8:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 3:58 Chengwen Feng
2024-02-20 3:58 ` [PATCH 1/4] cfgfile: remove dead code Chengwen Feng
2024-07-04 21:28 ` Stephen Hemminger
2024-02-20 3:58 ` [PATCH 2/4] cfgfile: support verify name and value Chengwen Feng
2024-07-04 21:29 ` Stephen Hemminger
2024-02-20 3:58 ` [PATCH 3/4] cfgfile: verify add section and entry result Chengwen Feng
2024-07-04 21:30 ` Stephen Hemminger
2024-02-20 3:58 ` [PATCH 4/4] cfgfile: add unique name flag Chengwen Feng
2024-07-04 21:36 ` Stephen Hemminger
2024-07-05 9:37 ` fengchengwen
2024-07-04 15:12 ` [PATCH 0/4] cfgfile: enhance error detecting David Marchand
2024-07-05 0:14 ` Stephen Hemminger
2024-07-05 0:29 ` Stephen Hemminger
2024-07-04 21:40 ` Stephen Hemminger
2024-07-05 8:39 ` Bruce Richardson [this message]
2024-07-05 9:31 ` [PATCH v2 " Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 1/4] cfgfile: remove dead code Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 2/4] cfgfile: support verify name and value Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 3/4] cfgfile: verify add section and entry result Chengwen Feng
2024-07-05 9:31 ` [PATCH v2 4/4] cfgfile: add strict parse flag Chengwen Feng
2024-09-06 1:03 ` [PATCH v2 0/4] cfgfile: enhance error detecting fengchengwen
2024-10-09 22:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoexRUAKDxSpZzkp@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).