Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/2/2021 11:28 AM, Thomas Monjalon wrote:
> 02/11/2021 11:04, Ferruh Yigit:
>> On 11/1/2021 10:20 PM, Thomas Monjalon wrote:
>>> 01/11/2021 14:35, Ferruh Yigit:
>>>> 'get_maintainer.pl' by default returns authors that has fixes in
>>>> relevant code, to reduce the output only maintainers from MAINTAINERS
>>>> file, disabling fixes authors, by making '--no-fixes' default.
>>>
>>> Do you mean it is not Cc'ing people who have contributed to the file?
>>> Is it keeping Cc of people having contributed to the commit being fixed?
>>>
>>
>> It is adding both, people contributed to the file and contributed to the commit
>> it is fixing. More details from tool is below [1].
>>
>> Intention to cc'ing the people who introduced the commit you are fixing
>> makes sense.
>> But as far as I can see it adds all xxx-by names from the fix commit, not
>> just author, that may add some unrelated people.
>>
>> Let me give a sample:
>> Commit A: ("ethdev: add namespace")
>>             It updates bunch of drivers and it has acks from various
>>             driver maintainers.
>>
>> Commit B: ("net/txgbe: fix link macro")
>>             Fixing Commit A for one driver (txgbe)
>>
>> If --fixes is used on 'Commit B', the author of 'Commit A' and all people
>> acked 'Commit A' is added. But none of the acks were related to 'Commit B'.
>> So as a result unrelated people cc'ed for 'Commit B'.
>>
>>
>> If the commit and fix commit are more narrow scope, this make sense.
>> So we may prefer to keep '--fixes' if we are OK to some noises in some cases.
> 
> Yes I prefer Cc'ing everybody.
> In case where the people are not needed for sure, I don't use the script.
> 

OK to drop this patch, but I think good to have first one (1/2).

> 
>> [1]
>>   From 'get_maintainer.pl':
>>      --fixes => for patches, add signatures of commits with 'Fixes: <commit>' (default: 1 (on))
>>
>>
>> And form commit log that adding the feature:
>> 2f5bd343694e ("scripts/get_maintainer.pl: add signatures from Fixes: <badcommit> lines in commit message")
>>
>>       A Fixes: lines in a commit message generally indicate that a previous
>>       commit was inadequate for whatever reason.
>>       
>>       The signers of the previous inadequate commit should also be cc'd on
>>       this new commit so update get_maintainer to find the old commit and add
>>       the original signers.
>>
>