DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>,
	Raslan Darawsheh <rasland@mellanox.com>,
	Dekel Peled <dekelp@mellanox.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location
Date: Tue, 16 Jun 2020 17:18:44 +0100	[thread overview]
Message-ID: <3be96603-42c7-d4a9-6718-930019be10aa@intel.com> (raw)
In-Reply-To: <AM0PR0502MB4019353F09082C422B7DB616D29D0@AM0PR0502MB4019.eurprd05.prod.outlook.com>

On 6/16/2020 5:06 PM, Matan Azrad wrote:
> Hi
> 
> Ferruh, Raslan
> 
> This patch is not a fix, we don't need to backport it.

Why not backport it?

> I don't think we need fixes and cc stable here.
> 
> Matan
> 
> From: Raslan Darawsheh
>> Hi,
>>
>>> -----Original Message-----
>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>>> Sent: Tuesday, June 16, 2020 1:28 PM
>>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
>>> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
>>> Raslan Darawsheh <rasland@mellanox.com>
>>> Cc: dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
>>> correct location
>>>
>>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
>>>> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
>>>> above function flow_dv_validate_item_gtp(), where it is used.
>>>>
>>>> Patch was applied together with other patches which modified the
>>>> same file, so the mask was located further away from the function it
>>>> is used in.
>>>>
>>>> This patch moves the mask definition to the proper location.
>>>>
>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>>> Acked-by: Matan Azrad <matan@mellanox.com>
>>>>
>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
>>>
>>>
>>> Better to add this as 'Fixes', instead of reference, so this way it
>>> helps for the backporting etc..
>>>
>>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
>>>     Cc: stable@dpdk.org
>>
>> I'll change it in next-net-mlx accordingly,
>>
>> Kindest regards,
>> Raslan Darawsheh


  reply	other threads:[~2020-06-16 16:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 13:25 Dekel Peled
2020-06-14 10:29 ` Raslan Darawsheh
2020-06-16 10:27 ` Ferruh Yigit
2020-06-16 13:40   ` Raslan Darawsheh
2020-06-16 16:06     ` Matan Azrad
2020-06-16 16:18       ` Ferruh Yigit [this message]
2020-06-16 16:23         ` Matan Azrad
2020-06-16 16:53           ` Ferruh Yigit
2020-06-17 11:43             ` Matan Azrad
2020-06-17 12:59               ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3be96603-42c7-d4a9-6718-930019be10aa@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).