Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 6/10/2020 2:25 PM, Dekel Peled wrote:
> Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just
> above function flow_dv_validate_item_gtp(), where it is used.
> 
> Patch was applied together with other patches which modified the same
> file, so the mask was located further away from the function it is
> used in.
> 
> This patch moves the mask definition to the proper location.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> 
> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")


Better to add this as 'Fixes', instead of reference, so this way it helps for
the backporting etc..

    Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to indexed")
    Cc: stable@dpdk.org


> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
> index 81f5bd4..d645d2d 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1639,18 +1639,6 @@ struct field_modify_info modify_tcp[] = {
>  	return 0;
>  }
>  
> -/*
> - * GTP flags are contained in 1 byte of the format:
> - * -------------------------------------------
> - * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
> - * |-----------------------------------------|
> - * | value | Version | PT | Res | E | S | PN |
> - * -------------------------------------------
> - *
> - * Matching is supported only for GTP flags E, S, PN.
> - */
> -#define MLX5_GTP_FLAGS_MASK	0x07
> -
>  /**
>   * Validate VLAN item.
>   *
> @@ -1724,6 +1712,18 @@ struct field_modify_info modify_tcp[] = {
>  	return 0;
>  }
>  
> +/*
> + * GTP flags are contained in 1 byte of the format:
> + * -------------------------------------------
> + * | bit   | 0 - 2   | 3  | 4   | 5 | 6 | 7  |
> + * |-----------------------------------------|
> + * | value | Version | PT | Res | E | S | PN |
> + * -------------------------------------------
> + *
> + * Matching is supported only for GTP flags E, S, PN.
> + */
> +#define MLX5_GTP_FLAGS_MASK	0x07
> +
>  /**
>   * Validate GTP item.
>   *
>