Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location

[Matan Azrad <matan@mellanox.com>]

From: Ferruh Yigit:
> On 6/16/2020 5:23 PM, Matan Azrad wrote:
> >
> >
> > From: Ferruh Yigit
> >> On 6/16/2020 5:06 PM, Matan Azrad wrote:
> >>> Hi
> >>>
> >>> Ferruh, Raslan
> >>>
> >>> This patch is not a fix, we don't need to backport it.
> >>
> >> Why not backport it?
> >
> > There is no a bug fix.
> > The behavior will not be changed.
> >
> > It is just for comfort.
> 
> It is not fix in the functionality, yes. But since it is merged into master, why
> not backport it, backporting reduces possible conflicts in related code later.

We can say it for any patch in master.
 
> Also if this increases the readability of the code, why not stable trees benefit
> from it too?

It is not too important in some cases, therefore doesn't worth the potential effort of backporting.

I think this is grey case, maybe one thing we can let the maintainer to decide...

I will not insist...

> >>> I don't think we need fixes and cc stable here.
> >>>
> >>> Matan
> >>>
> >>> From: Raslan Darawsheh
> >>>> Hi,
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >>>>> Sent: Tuesday, June 16, 2020 1:28 PM
> >>>>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
> >>>>> <matan@mellanox.com>; Slava Ovsiienko
> >> <viacheslavo@mellanox.com>;
> >>>>> Raslan Darawsheh <rasland@mellanox.com>
> >>>>> Cc: dev@dpdk.org
> >>>>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to
> >>>>> correct location
> >>>>>
> >>>>> On 6/10/2020 2:25 PM, Dekel Peled wrote:
> >>>>>> Recent patch [1] added definition of mask
> MLX5_GTP_FLAGS_MASK,
> >> just
> >>>>>> above function flow_dv_validate_item_gtp(), where it is used.
> >>>>>>
> >>>>>> Patch was applied together with other patches which modified the
> >>>>>> same file, so the mask was located further away from the function
> >>>>>> it is used in.
> >>>>>>
> >>>>>> This patch moves the mask definition to the proper location.
> >>>>>>
> >>>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> >>>>>> Acked-by: Matan Azrad <matan@mellanox.com>
> >>>>>>
> >>>>>> [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags")
> >>>>>
> >>>>>
> >>>>> Better to add this as 'Fixes', instead of reference, so this way
> >>>>> it helps for the backporting etc..
> >>>>>
> >>>>>     Fixes: b88341ca35fc ("net/mlx5: convert flow dev handle to
> indexed")
> >>>>>     Cc: stable@dpdk.org
> >>>>
> >>>> I'll change it in next-net-mlx accordingly,
> >>>>
> >>>> Kindest regards,
> >>>> Raslan Darawsheh
> >