DPDK patches and discussions
 help / color / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, "Wei Hu (Xavier" <xavier.huwei@huawei.com>
Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
Date: Mon, 19 Oct 2020 11:03:33 +0800
Message-ID: <3eff91b3-e175-3cad-a98e-5ddb39132672@huawei.com> (raw)
In-Reply-To: <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com>



在 2020/10/16 20:16, Ferruh Yigit 写道:
> On 10/14/2020 3:26 AM, Ferruh Yigit wrote:
>> Queue stats are stored in 'struct rte_eth_stats' as array and array size
>> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.
>>
>> As a result of technical board discussion, decided to remove the queue
>> statistics from 'struct rte_eth_stats' in the long term.
>>
>> Instead PMDs should represent the queue statistics via xstats, this
>> gives more flexibility on the number of the queues supported.
>>
>> Currently queue stats in the xstats are filled by ethdev layer, using
>> some basic stats, when queue stats removed from basic stats the
>> responsibility to fill the relevant xstats will be pushed to the PMDs.
>>
>> During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS'
>> device flag is created. Initially all PMDs using xstats set this flag.
>> The PMDs implemented queue stats in the xstats should clear the flag.
>>
>> When all PMDs switch to the xstats for the queue stats, queue stats
>> related fields from 'struct rte_eth_stats' will be removed, as well as
>> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
>> Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be
>> removed.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Hi Thomas, Andrew,
> 
> What do you think having the patch for this release?
> 
> 
> Connor, Xavier,
> 
> Are you OK to superseded your existing patch [1] with this approach?
> [1] https://patches.dpdk.org/patch/78886/
Hi, Ferruh,
	it is ok, we will continue the work with your solution. Thanks.


> .

  parent reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 16:46 [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats Ferruh Yigit
2020-10-12 16:46 ` [dpdk-dev] [RFC 2/2] doc: announce queue stats moving " Ferruh Yigit
2020-10-12 16:55   ` [dpdk-dev] [dpdk-techboard] " Stephen Hemminger
2020-10-12 21:53 ` [dpdk-dev] [RFC 1/2] ethdev: move queue stats " Thomas Monjalon
2020-10-13  8:31   ` Andrew Rybchenko
2020-10-13  9:05     ` Thomas Monjalon
2020-10-13  9:16       ` Andrew Rybchenko
2020-10-13 22:41         ` Ferruh Yigit
2020-10-13 15:04       ` Stephen Hemminger
2020-10-13 22:53   ` Ferruh Yigit
2020-10-14  2:26 ` [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Ferruh Yigit
2020-10-14  2:26   ` [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats Ferruh Yigit
2020-10-14  8:43     ` Kinsella, Ray
2020-10-16 14:34       ` Thomas Monjalon
2020-10-16 14:36         ` Bruce Richardson
2020-10-16 14:37         ` Jerin Jacob
2020-10-16 15:07         ` Stephen Hemminger
2020-10-16 17:48           ` Ajit Khaparde
2020-10-14  9:35     ` Igor Ryzhov
2020-10-14  9:45       ` Thomas Monjalon
2020-10-15  7:55         ` Igor Ryzhov
2020-10-15  8:03           ` Thomas Monjalon
2020-10-15 17:39             ` Igor Ryzhov
2020-10-15 17:45               ` Thomas Monjalon
2020-10-14  8:40   ` [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Wang, Haiyue
2020-10-14  8:46   ` Wang, Xiao W
2020-10-16 12:16   ` Ferruh Yigit
2020-10-16 14:32     ` Thomas Monjalon
2020-10-16 21:38       ` Ferruh Yigit
2020-10-19  3:03     ` Min Hu (Connor) [this message]
2020-10-18 12:09   ` Xu, Rosen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3eff91b3-e175-3cad-a98e-5ddb39132672@huawei.com \
    --to=humin29@huawei.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox