From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Haiyue Wang <haiyue.wang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API
Date: Mon, 11 Oct 2021 16:23:27 +0300 [thread overview]
Message-ID: <4846eca4-4b70-1ff9-9886-eb80a4bb1974@oktetlabs.ru> (raw)
In-Reply-To: <9b5b19c0-aa85-3502-0718-81e5f33a03f4@oktetlabs.ru>
On 10/6/21 12:09 PM, Andrew Rybchenko wrote:
> On 10/6/21 11:51 AM, Ferruh Yigit wrote:
>> On 9/28/2021 4:48 PM, Andrew Rybchenko wrote:
>>> diff --git a/drivers/net/virtio/virtio_ethdev.c
>>> b/drivers/net/virtio/virtio_ethdev.c
>>> index da1633d77e..c82089930f 100644
>>> --- a/drivers/net/virtio/virtio_ethdev.c
>>> +++ b/drivers/net/virtio/virtio_ethdev.c
>>> @@ -1894,7 +1894,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
>>> }
>>> eth_dev->dev_ops = &virtio_eth_dev_ops;
>>> - eth_dev->rx_descriptor_done = virtio_dev_rx_queue_done;
>>
>> Checking twice, should 'virtio_dev_rx_queue_done()' declaration and
>> definition be removed?
>> It seems there is no user of the function except here.
>
> Yes, I lost it from my view.
>
Fixed in v2.
next prev parent reply other threads:[~2021-10-11 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 15:48 Andrew Rybchenko
2021-09-30 13:26 ` Ferruh Yigit
2021-10-05 19:16 ` Thomas Monjalon
2021-10-11 13:22 ` Andrew Rybchenko
2021-10-06 8:51 ` Ferruh Yigit
2021-10-06 9:09 ` Andrew Rybchenko
2021-10-11 13:23 ` Andrew Rybchenko [this message]
2021-10-11 13:24 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-10-11 14:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4846eca4-4b70-1ff9-9886-eb80a4bb1974@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).