* [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD
@ 2016-03-31 9:12 Daniel Mrzyglod
2016-03-31 11:22 ` Sergio Gonzalez Monroy
2016-03-31 12:43 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD Daniel Mrzyglod
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Mrzyglod @ 2016-03-31 9:12 UTC (permalink / raw)
To: dev
There were misssed typedef for u_char - <sys/types.h>
There were missed network definitions - <netinet/in.h>
Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
examples/ipsec-secgw/esp.c | 4 +++-
examples/ipsec-secgw/ipsec.c | 2 +-
examples/ipsec-secgw/rt.c | 1 +
examples/ipsec-secgw/sa.c | 2 ++
examples/ipsec-secgw/sp.c | 2 ++
5 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
index ca0fc56..7b0e04c 100644
--- a/examples/ipsec-secgw/esp.c
+++ b/examples/ipsec-secgw/esp.c
@@ -33,8 +33,10 @@
#include <stdint.h>
#include <stdlib.h>
-#include <netinet/ip.h>
#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <netinet/ip.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index d385100..baf30d4 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -30,7 +30,7 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
+#include <sys/types.h>
#include <netinet/in.h>
#include <netinet/ip.h>
diff --git a/examples/ipsec-secgw/rt.c b/examples/ipsec-secgw/rt.c
index c3bb4de..a6d0866 100644
--- a/examples/ipsec-secgw/rt.c
+++ b/examples/ipsec-secgw/rt.c
@@ -34,6 +34,7 @@
/*
* Routing Table (RT)
*/
+#include <sys/types.h>
#include <rte_lpm.h>
#include <rte_errno.h>
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 91a5f6e..a5b8a63 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -34,6 +34,8 @@
/*
* Security Associations
*/
+#include <sys/types.h>
+#include <netinet/in.h>
#include <netinet/ip.h>
#include <rte_memzone.h>
diff --git a/examples/ipsec-secgw/sp.c b/examples/ipsec-secgw/sp.c
index 7972f40..4f16730 100644
--- a/examples/ipsec-secgw/sp.c
+++ b/examples/ipsec-secgw/sp.c
@@ -34,6 +34,8 @@
/*
* Security Policies
*/
+#include <sys/types.h>
+#include <netinet/in.h>
#include <netinet/ip.h>
#include <rte_acl.h>
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD
2016-03-31 9:12 [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD Daniel Mrzyglod
@ 2016-03-31 11:22 ` Sergio Gonzalez Monroy
2016-03-31 12:43 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD Daniel Mrzyglod
1 sibling, 0 replies; 5+ messages in thread
From: Sergio Gonzalez Monroy @ 2016-03-31 11:22 UTC (permalink / raw)
To: Daniel Mrzyglod; +Cc: dev
Commit title shouldn't contain capital letters.
On 31/03/2016 10:12, Daniel Mrzyglod wrote:
> There were misssed typedef for u_char - <sys/types.h>
> There were missed network definitions - <netinet/in.h>
Something a bit more descriptive along the lines of:
In FreeBSD, sys/types.h and netinet/in.h need to be included before
netinet/ip.h.
> Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
> examples/ipsec-secgw/esp.c | 4 +++-
> examples/ipsec-secgw/ipsec.c | 2 +-
> examples/ipsec-secgw/rt.c | 1 +
> examples/ipsec-secgw/sa.c | 2 ++
> examples/ipsec-secgw/sp.c | 2 ++
> 5 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
> index ca0fc56..7b0e04c 100644
> --- a/examples/ipsec-secgw/esp.c
> +++ b/examples/ipsec-secgw/esp.c
> @@ -33,8 +33,10 @@
>
> #include <stdint.h>
> #include <stdlib.h>
> -#include <netinet/ip.h>
> #include <sys/types.h>
> +#include <sys/socket.h>
Do we need sys/socket.h?
Sergio
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD
2016-03-31 9:12 [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD Daniel Mrzyglod
2016-03-31 11:22 ` Sergio Gonzalez Monroy
@ 2016-03-31 12:43 ` Daniel Mrzyglod
2016-03-31 13:02 ` Sergio Gonzalez Monroy
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Mrzyglod @ 2016-03-31 12:43 UTC (permalink / raw)
To: dev; +Cc: sergio.gonzalez.monroy
In FreeBSD, sys/types.h and netinet/in.h need to be included before
netinet/ip.h
There were misssed typedef for u_char - <sys/types.h>
There were missed network definitions - <netinet/in.h>
Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
examples/ipsec-secgw/esp.c | 3 ++-
examples/ipsec-secgw/ipsec-secgw.c | 2 ++
examples/ipsec-secgw/ipsec.c | 2 +-
examples/ipsec-secgw/ipsec.h | 2 --
examples/ipsec-secgw/rt.c | 1 +
examples/ipsec-secgw/sa.c | 2 ++
examples/ipsec-secgw/sp.c | 2 ++
7 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c
index ca0fc56..1927380 100644
--- a/examples/ipsec-secgw/esp.c
+++ b/examples/ipsec-secgw/esp.c
@@ -33,9 +33,10 @@
#include <stdint.h>
#include <stdlib.h>
-#include <netinet/ip.h>
#include <sys/types.h>
#include <sys/stat.h>
+#include <netinet/in.h>
+#include <netinet/ip.h>
#include <fcntl.h>
#include <unistd.h>
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index d6c9a5d..1d6c81b 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -36,6 +36,8 @@
#include <stdint.h>
#include <inttypes.h>
#include <sys/types.h>
+#include <netinet/in.h>
+#include <netinet/ip.h>
#include <string.h>
#include <sys/queue.h>
#include <stdarg.h>
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index d385100..baf30d4 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -30,7 +30,7 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
+#include <sys/types.h>
#include <netinet/in.h>
#include <netinet/ip.h>
diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h
index 8eb4e76..a13fdef 100644
--- a/examples/ipsec-secgw/ipsec.h
+++ b/examples/ipsec-secgw/ipsec.h
@@ -35,8 +35,6 @@
#define __IPSEC_H__
#include <stdint.h>
-#include <netinet/in.h>
-#include <netinet/ip.h>
#include <rte_byteorder.h>
#include <rte_ip.h>
diff --git a/examples/ipsec-secgw/rt.c b/examples/ipsec-secgw/rt.c
index c3bb4de..a6d0866 100644
--- a/examples/ipsec-secgw/rt.c
+++ b/examples/ipsec-secgw/rt.c
@@ -34,6 +34,7 @@
/*
* Routing Table (RT)
*/
+#include <sys/types.h>
#include <rte_lpm.h>
#include <rte_errno.h>
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 91a5f6e..a5b8a63 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -34,6 +34,8 @@
/*
* Security Associations
*/
+#include <sys/types.h>
+#include <netinet/in.h>
#include <netinet/ip.h>
#include <rte_memzone.h>
diff --git a/examples/ipsec-secgw/sp.c b/examples/ipsec-secgw/sp.c
index 7972f40..4f16730 100644
--- a/examples/ipsec-secgw/sp.c
+++ b/examples/ipsec-secgw/sp.c
@@ -34,6 +34,8 @@
/*
* Security Policies
*/
+#include <sys/types.h>
+#include <netinet/in.h>
#include <netinet/ip.h>
#include <rte_acl.h>
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD
2016-03-31 12:43 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD Daniel Mrzyglod
@ 2016-03-31 13:02 ` Sergio Gonzalez Monroy
2016-03-31 20:28 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Sergio Gonzalez Monroy @ 2016-03-31 13:02 UTC (permalink / raw)
To: Daniel Mrzyglod, dev
On 31/03/2016 13:43, Daniel Mrzyglod wrote:
> In FreeBSD, sys/types.h and netinet/in.h need to be included before
> netinet/ip.h
>
> There were misssed typedef for u_char - <sys/types.h>
> There were missed network definitions - <netinet/in.h>
>
> Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>
Other than typo in commit message: "misssed"
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD
2016-03-31 13:02 ` Sergio Gonzalez Monroy
@ 2016-03-31 20:28 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2016-03-31 20:28 UTC (permalink / raw)
To: Daniel Mrzyglod; +Cc: dev, Sergio Gonzalez Monroy
2016-03-31 14:02, Sergio Gonzalez Monroy:
> On 31/03/2016 13:43, Daniel Mrzyglod wrote:
> > In FreeBSD, sys/types.h and netinet/in.h need to be included before
> > netinet/ip.h
> >
> > There were misssed typedef for u_char - <sys/types.h>
> > There were missed network definitions - <netinet/in.h>
> >
> > Failure #13: http://dpdk.org/ml/archives/test-report/2016-March/001896.html
> >
> > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> >
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
> Other than typo in commit message: "misssed"
>
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-31 20:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-31 9:12 [dpdk-dev] [PATCH] examples/ipsec-secgw: Fix Missed Headers For FreeBSD Daniel Mrzyglod
2016-03-31 11:22 ` Sergio Gonzalez Monroy
2016-03-31 12:43 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix missed headers for FreeBSD Daniel Mrzyglod
2016-03-31 13:02 ` Sergio Gonzalez Monroy
2016-03-31 20:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).