[PATCH] net/nfp: fix getting firmware version

[PATCH] net/nfp: fix getting firmware version

[Chaoyong He]

The VF PMD can not get a valid 'cpp' data filed in the 'struct
nfp_net_hw', the value of which will be NULL always. This cause any
logic which use of 'cpp' will make the app crash.

Fix this by delete the support of getting firmware version of VF.

Fixes: 128c8ad951bf ("net/nfp: support getting firmware version")
Cc: chaoyong.he@corigine.com

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_ethdev_vf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c
index f971bb8903..9020cd399b 100644
--- a/drivers/net/nfp/nfp_ethdev_vf.c
+++ b/drivers/net/nfp/nfp_ethdev_vf.c
@@ -241,7 +241,6 @@ static const struct eth_dev_ops nfp_netvf_eth_dev_ops = {
 	.tx_queue_release	= nfp_net_tx_queue_release,
 	.rx_queue_intr_enable   = nfp_rx_queue_intr_enable,
 	.rx_queue_intr_disable  = nfp_rx_queue_intr_disable,
-	.fw_version_get         = nfp_net_firmware_version_get,
 };
 
 static inline void
-- 
2.39.1

Re: [PATCH] net/nfp: fix getting firmware version

[Ferruh Yigit]

On 6/15/2023 2:30 AM, Chaoyong He wrote:
> The VF PMD can not get a valid 'cpp' data filed in the 'struct
> nfp_net_hw', the value of which will be NULL always. This cause any
> logic which use of 'cpp' will make the app crash.
> 

It is not fixing getting FW version, but fixing crash by removing FW
get, updating patch title while merging.

> Fix this by delete the support of getting firmware version of VF.
> 
> Fixes: 128c8ad951bf ("net/nfp: support getting firmware version")
> Cc: chaoyong.he@corigine.com
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>

Applied to dpdk-next-net/main, thanks.