From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Xiaoyun Li <xiaoyun.li@intel.com>, Rosen Xu <rosen.xu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before device start
Date: Thu, 28 Oct 2021 19:23:07 +0100 [thread overview]
Message-ID: <61c8c94e-6c63-17e9-0950-5ddc8b327437@intel.com> (raw)
In-Reply-To: <CACZ4nhu=qdLeGmhs3NNbLucoYfDLPaZ+9GaiMYgvuBZSPQp_jQ@mail.gmail.com>
On 10/25/2021 7:06 PM, Ajit Khaparde wrote:
> On Sun, Oct 24, 2021 at 9:42 AM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> There is no point to do rte_eth_dev_mtu_set() before configure since
>> set MTU value is overwritten on configure anyway. So, setting of MTU
>> before configure is rejected now on ethdev level.
>>
>> If testpmd is going to do configure (e.g. just after testpmd start
>> with disabled devices start up or any configuration changes in stopped
>> state which require reconfigure), just save requested MTU in device
>> config to be applied on reconfigure.
>>
>> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
>> Fixes: be0433cf953c ("ethdev: forbid MTU set before device configure")
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2021-10-28 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 16:42 Andrew Rybchenko
2021-10-25 18:06 ` Ajit Khaparde
2021-10-28 18:23 ` Ferruh Yigit [this message]
2021-11-02 2:37 ` Jiang, YuX
2021-11-10 7:23 ` Jiang, YuX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c8c94e-6c63-17e9-0950-5ddc8b327437@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ivan.ilchenko@oktetlabs.ru \
--cc=konstantin.ananyev@intel.com \
--cc=rosen.xu@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).