From: Ferruh Yigit <ferruh.yigit@intel.com> To: Satheesh Paul <psatheesh@marvell.com>, Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar Kokkilagadda <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, "Satha Koteswara Rao Kottidi" <skoteshwar@marvell.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@nvidia.com>, "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH 22.02 2/2] net/cnxk: add devargs for configuring SDP channel mask Date: Wed, 12 Jan 2022 10:57:36 +0000 Message-ID: <6ffd00b2-2b1b-872b-f47d-56ad26824460@intel.com> (raw) In-Reply-To: <DM5PR18MB2245A0C50F51E27E518EACD9BD519@DM5PR18MB2245.namprd18.prod.outlook.com> On 1/11/2022 2:29 PM, Satheesh Paul wrote: > Hi, > > Please find reply inline. > > Thanks, > Satheesh. > > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: 11 January 2022 05:26 PM > To: Satheesh Paul <psatheesh@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com> > Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > Subject: [EXT] Re: [dpdk-dev] [PATCH 22.02 2/2] net/cnxk: add devargs for configuring SDP channel mask > > External Email > > ---------------------------------------------------------------------- > On 11/9/2021 9:42 AM, psatheesh@marvell.com wrote: >> From: Satheesh Paul <psatheesh@marvell.com> >> >> This patch adds support to configure channel mask which will be used >> by rte flow when adding flow rules on SDP interfaces. >> > >> Hi Satheesh, > >> + Ori & Andrew. > >> What 'SDP' stands for? > It stands for "System DMA Packet Interface". This is when the system acts as PCIe endpoint. For instance, an x86 machine can act as a host having an Octeon TX* board plugged through this PCIe interface and packets are transferred through this PCIe interface. > >> And can this new devarg be provided with flow rule? Why it needs to be a new devarg? > SDP and its channel related info are specific to the hardware and rte flow api cannot be extended to support them. Hence, it is added as a new devarg. > >> Can you please give a sample of the rte flow API that will be used? > This channel mask will be used by the rte_flow_create() api. It is actually transparent at rte_flow_create() invocation itself. That is, at the time of rte_flow_create() invocation, user does not give any additional information. But internally, the driver's flow creation api takes the SDP channel/mask value supplied at the startup and applies it. Basically, in Octeon tx*, the interfaces have a "channel identifier" number. The rules in packet classification hardware are configured to match the channel number. With this change, we are relaxing the exact match and are allowing a range for this SDP interface. > Got it. I am still not quite clear what SDP is, but from below document my understanding was user need to provide these channel & mask while creating a flow rule, but according above description that is not the case, but this is internal to the driver, so I am OK to proceed. Thanks for clarification. > Thanks, > ferruh > > >> Signed-off-by: Satheesh Paul <psatheesh@marvell.com> >> --- >> doc/guides/nics/cnxk.rst | 21 ++++++++++++++ >> drivers/net/cnxk/cnxk_ethdev_devargs.c | 40 ++++++++++++++++++++++++-- >> 2 files changed, 59 insertions(+), 2 deletions(-) >> >> diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst index >> 837ffc02b4..470e01b811 100644 >> --- a/doc/guides/nics/cnxk.rst >> +++ b/doc/guides/nics/cnxk.rst >> @@ -276,6 +276,27 @@ Runtime Config Options >> set with this custom mask, inbound encrypted traffic from all ports with >> matching channel number pattern will be directed to the inline IPSec device. >> >> +- ``SDP device channel and mask`` (default ``none``) >> + Set channel and channel mask configuration for the SDP device. This >> + will be used when creating flow rules on the SDP device. >> + >> + By default, for rules created on the SDP device, the RTE Flow API sets the >> + channel number and mask to cover the entire SDP channel range in the channel >> + field of the MCAM entry. This behaviour can be modified using the >> + ``sdp_channel_mask`` ``devargs`` parameter. >> + >> + For example:: >> + >> + -a 0002:1d:00.0,sdp_channel_mask=0x700/0xf00 >> + >> + With the above configuration, RTE Flow rules API will set the channel >> + and channel mask as 0x700 and 0xF00 in the MCAM entries of the flow rules >> + created on the SDP device. This option needs to be used when more than one >> + SDP interface is in use and RTE Flow rules created need to distinguish >> + between traffic from each SDP interface. The channel and mask combination >> + specified should match all the channels(or rings) configured on the SDP >> + interface. >> + >> .. note:: >> > > <...>
next prev parent reply other threads:[~2022-01-12 10:57 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-09 9:42 [dpdk-dev] [PATCH 22.02 1/2] common/cnxk: support to set channel mask for SDP interfaces psatheesh 2021-11-09 9:42 ` [dpdk-dev] [PATCH 22.02 2/2] net/cnxk: add devargs for configuring SDP channel mask psatheesh 2022-01-11 11:56 ` Ferruh Yigit 2022-01-11 14:29 ` [EXT] " Satheesh Paul 2022-01-12 10:57 ` Ferruh Yigit [this message] 2021-12-21 10:18 ` [dpdk-dev] [PATCH 22.02 1/2] common/cnxk: support to set channel mask for SDP interfaces Jerin Jacob
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ffd00b2-2b1b-872b-f47d-56ad26824460@intel.com \ --to=ferruh.yigit@intel.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=kirankumark@marvell.com \ --cc=ndabilpuram@marvell.com \ --cc=orika@nvidia.com \ --cc=psatheesh@marvell.com \ --cc=skori@marvell.com \ --cc=skoteshwar@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git