From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qiming Chen <chenqiming_huawei@163.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] net/pcap: improve rx statistics
Date: Thu, 9 Sep 2021 11:20:48 +0100 [thread overview]
Message-ID: <7ccc7438-ca74-2e31-36bf-d89c5a601e6f@intel.com> (raw)
In-Reply-To: <20210909082323.10658-1-chenqiming_huawei@163.com>
On 9/9/2021 9:23 AM, Qiming Chen wrote:
> In the receiving direction, if alloc mbuf or jumbo process failed, there
> is no err_pkts count, which makes it difficult to locate the problem.
> Because alloc mbuf failed, the rx_nombuf field is counted.
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
<...>
> @@ -742,7 +746,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> {
> unsigned int i;
> unsigned long rx_packets_total = 0, rx_bytes_total = 0;
> - unsigned long rx_missed_total = 0;
> + unsigned long rx_missed_total = 0, rx_nombuf = 0, rx_err_total = 0;
Since all other variables for same purpose has '_total' suffix, let's add it to
the 'rx_nombuf' too.
And can you please start a new line for new two variables:
unsigned long rx_nombuf_total = 0, rx_err_total = 0;
next prev parent reply other threads:[~2021-09-09 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 3:16 [dpdk-dev] [PATCH] net/pcap: improve rxtx statistics Qiming Chen
2021-08-26 3:23 ` [dpdk-dev] [PATCH v2] " Qiming Chen
2021-09-08 12:29 ` Ferruh Yigit
2021-09-09 2:45 ` [dpdk-dev] [PATCH v3] net/pcap: improve rx statistics Qiming Chen
2021-09-09 3:29 ` Stephen Hemminger
2021-09-09 10:20 ` Ferruh Yigit
2021-09-09 4:16 ` [dpdk-dev] [PATCH v4] " Qiming Chen
2021-09-09 8:05 ` Ferruh Yigit
2021-09-09 8:23 ` [dpdk-dev] [PATCH v5] " Qiming Chen
2021-09-09 10:20 ` Ferruh Yigit [this message]
2021-09-09 12:28 ` [dpdk-dev] [PATCH v6] " Qiming Chen
2021-09-09 14:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ccc7438-ca74-2e31-36bf-d89c5a601e6f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenqiming_huawei@163.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).