* [dpdk-dev] [PATCH v1] eal: ignore alignment warnings for x86 @ 2020-04-29 5:26 Haiyue Wang 2020-04-29 6:49 ` [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector Haiyue Wang 0 siblings, 1 reply; 5+ messages in thread From: Haiyue Wang @ 2020-04-29 5:26 UTC (permalink / raw) To: dev, bruce.richardson, konstantin.ananyev, ian.stokes; +Cc: Haiyue Wang There several alignment warnings when including rte_memcpy header file externally like OVS for x86. Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> --- lib/librte_eal/x86/include/rte_memcpy.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h index ba44c4a32..6f5e0feb4 100644 --- a/lib/librte_eal/x86/include/rte_memcpy.h +++ b/lib/librte_eal/x86/include/rte_memcpy.h @@ -22,6 +22,10 @@ extern "C" { #endif +#ifndef __INTEL_COMPILER +#pragma GCC diagnostic ignored "-Wcast-align" +#endif + /** * Copy bytes from one location to another. The locations must not overlap. * -- 2.26.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector 2020-04-29 5:26 [dpdk-dev] [PATCH v1] eal: ignore alignment warnings for x86 Haiyue Wang @ 2020-04-29 6:49 ` Haiyue Wang 2020-04-29 8:29 ` Wang, Haiyue 2020-04-29 8:40 ` Kevin Traynor 0 siblings, 2 replies; 5+ messages in thread From: Haiyue Wang @ 2020-04-29 6:49 UTC (permalink / raw) To: dev, bruce.richardson, konstantin.ananyev, ian.stokes; +Cc: Haiyue Wang There several alignment warnings when including rte_memcpy header file externally like OVS for x86. Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> --- v2: Use __GUNC__ macro to apply for suppressing the warning. --- lib/librte_eal/x86/include/rte_memcpy.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h index ba44c4a32..d4cfe8dd5 100644 --- a/lib/librte_eal/x86/include/rte_memcpy.h +++ b/lib/librte_eal/x86/include/rte_memcpy.h @@ -22,6 +22,10 @@ extern "C" { #endif +#ifdef __GNUC__ +#pragma GCC diagnostic ignored "-Wcast-align" +#endif + /** * Copy bytes from one location to another. The locations must not overlap. * -- 2.26.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector 2020-04-29 6:49 ` [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector Haiyue Wang @ 2020-04-29 8:29 ` Wang, Haiyue 2020-04-29 8:40 ` Kevin Traynor 1 sibling, 0 replies; 5+ messages in thread From: Wang, Haiyue @ 2020-04-29 8:29 UTC (permalink / raw) To: dev, Richardson, Bruce, Ananyev, Konstantin, Stokes, Ian Dropped this patch, it is better to let the application to decide the warning level. BR, Haiyue > -----Original Message----- > From: Wang, Haiyue <haiyue.wang@intel.com> > Sent: Wednesday, April 29, 2020 14:49 > To: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Stokes, Ian <ian.stokes@intel.com> > Cc: Wang, Haiyue <haiyue.wang@intel.com> > Subject: [PATCH v2] eal: ignore alignment warnings for x86 vector > > There several alignment warnings when including rte_memcpy header file > externally like OVS for x86. > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > --- > v2: Use __GUNC__ macro to apply for suppressing the warning. > --- > lib/librte_eal/x86/include/rte_memcpy.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h > index ba44c4a32..d4cfe8dd5 100644 > --- a/lib/librte_eal/x86/include/rte_memcpy.h > +++ b/lib/librte_eal/x86/include/rte_memcpy.h > @@ -22,6 +22,10 @@ > extern "C" { > #endif > > +#ifdef __GNUC__ > +#pragma GCC diagnostic ignored "-Wcast-align" > +#endif > + > /** > * Copy bytes from one location to another. The locations must not overlap. > * > -- > 2.26.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector 2020-04-29 6:49 ` [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector Haiyue Wang 2020-04-29 8:29 ` Wang, Haiyue @ 2020-04-29 8:40 ` Kevin Traynor 2020-04-29 16:17 ` Wang, Haiyue 1 sibling, 1 reply; 5+ messages in thread From: Kevin Traynor @ 2020-04-29 8:40 UTC (permalink / raw) To: Haiyue Wang, dev, bruce.richardson, konstantin.ananyev, ian.stokes On 29/04/2020 07:49, Haiyue Wang wrote: > There several alignment warnings when including rte_memcpy header file > externally like OVS for x86. > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > --- > v2: Use __GUNC__ macro to apply for suppressing the warning. > --- > lib/librte_eal/x86/include/rte_memcpy.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h > index ba44c4a32..d4cfe8dd5 100644 > --- a/lib/librte_eal/x86/include/rte_memcpy.h > +++ b/lib/librte_eal/x86/include/rte_memcpy.h > @@ -22,6 +22,10 @@ > extern "C" { > #endif > > +#ifdef __GNUC__ > +#pragma GCC diagnostic ignored "-Wcast-align" > +#endif > + Hi - have a look at this thread and the comments about a similar topic, they are relevant here too. http://inbox.dpdk.org/dev/20200416184549.10747-1-ktraynor@redhat.com/ > /** > * Copy bytes from one location to another. The locations must not overlap. > * > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector 2020-04-29 8:40 ` Kevin Traynor @ 2020-04-29 16:17 ` Wang, Haiyue 0 siblings, 0 replies; 5+ messages in thread From: Wang, Haiyue @ 2020-04-29 16:17 UTC (permalink / raw) To: Kevin Traynor, dev, Richardson, Bruce, Ananyev, Konstantin, Stokes, Ian > -----Original Message----- > From: Kevin Traynor <ktraynor@redhat.com> > Sent: Wednesday, April 29, 2020 16:41 > To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; > Ananyev, Konstantin <konstantin.ananyev@intel.com>; Stokes, Ian <ian.stokes@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector > > On 29/04/2020 07:49, Haiyue Wang wrote: > > There several alignment warnings when including rte_memcpy header file > > externally like OVS for x86. > > > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > > --- > > v2: Use __GUNC__ macro to apply for suppressing the warning. > > --- > > lib/librte_eal/x86/include/rte_memcpy.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h > > index ba44c4a32..d4cfe8dd5 100644 > > --- a/lib/librte_eal/x86/include/rte_memcpy.h > > +++ b/lib/librte_eal/x86/include/rte_memcpy.h > > @@ -22,6 +22,10 @@ > > extern "C" { > > #endif > > > > +#ifdef __GNUC__ > > +#pragma GCC diagnostic ignored "-Wcast-align" > > +#endif > > + > > Hi - have a look at this thread and the comments about a similar topic, > they are relevant here too. > http://inbox.dpdk.org/dev/20200416184549.10747-1-ktraynor@redhat.com/ > This issue happened on GCC 9.3.0 and build DPDK successfully, but compiling the OVS-DPDK has lot of warnings. Do we need to fix this ? > > /** > > * Copy bytes from one location to another. The locations must not overlap. > > * > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-29 16:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-29 5:26 [dpdk-dev] [PATCH v1] eal: ignore alignment warnings for x86 Haiyue Wang 2020-04-29 6:49 ` [dpdk-dev] [PATCH v2] eal: ignore alignment warnings for x86 vector Haiyue Wang 2020-04-29 8:29 ` Wang, Haiyue 2020-04-29 8:40 ` Kevin Traynor 2020-04-29 16:17 ` Wang, Haiyue
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).