* [dpdk-dev] [PATCH] net/qede: fix resource leak
@ 2016-11-30 12:32 Yong Wang
2016-12-08 16:52 ` Ferruh Yigit
2016-12-13 11:52 ` Ferruh Yigit
0 siblings, 2 replies; 5+ messages in thread
From: Yong Wang @ 2016-11-30 12:32 UTC (permalink / raw)
To: harish.patil; +Cc: dev, Yong Wang
Current code does not close 'fd' on function exit, leaking resources.
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/qede/qede_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index ab22409..b666e1c 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
if (fstat(fd, &st) < 0) {
DP_NOTICE(edev, false, "Can't stat firmware file\n");
+ close(fd);
return -1;
}
@@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
if (edev->fw_len < 104) {
DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n",
edev->fw_len);
+ close(fd);
return -EINVAL;
}
+ close(fd);
return 0;
}
#endif
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/qede: fix resource leak
2016-11-30 12:32 [dpdk-dev] [PATCH] net/qede: fix resource leak Yong Wang
@ 2016-12-08 16:52 ` Ferruh Yigit
2016-12-12 19:32 ` Harish Patil
2016-12-13 11:52 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2016-12-08 16:52 UTC (permalink / raw)
To: Yong Wang, harish.patil; +Cc: dev, Harish Patil
On 11/30/2016 12:32 PM, Yong Wang wrote:
> Current code does not close 'fd' on function exit, leaking resources.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
Add new mail address of the maintainer.
CC: Harish Patil <harish.patil@cavium.com>
<...>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/qede: fix resource leak
2016-12-08 16:52 ` Ferruh Yigit
@ 2016-12-12 19:32 ` Harish Patil
2016-12-13 11:51 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Harish Patil @ 2016-12-12 19:32 UTC (permalink / raw)
To: Ferruh Yigit, Yong Wang, Harish Patil; +Cc: dev
>On 11/30/2016 12:32 PM, Yong Wang wrote:
>> Current code does not close 'fd' on function exit, leaking resources.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>> ---
>
>Add new mail address of the maintainer.
>
>CC: Harish Patil <harish.patil@cavium.com>
>
><...>
>
Acked-by: Harish Patil <harish.patil@qlogic.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/qede: fix resource leak
2016-12-12 19:32 ` Harish Patil
@ 2016-12-13 11:51 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2016-12-13 11:51 UTC (permalink / raw)
To: Harish Patil, Yong Wang; +Cc: dev
On 12/12/2016 7:32 PM, Harish Patil wrote:
>
>> On 11/30/2016 12:32 PM, Yong Wang wrote:
>>> Current code does not close 'fd' on function exit, leaking resources.
>>>
>>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>>> ---
>>
>> Add new mail address of the maintainer.
>>
>> CC: Harish Patil <harish.patil@cavium.com>
>>
>> <...>
>>
>
> Acked-by: Harish Patil <harish.patil@qlogic.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/qede: fix resource leak
2016-11-30 12:32 [dpdk-dev] [PATCH] net/qede: fix resource leak Yong Wang
2016-12-08 16:52 ` Ferruh Yigit
@ 2016-12-13 11:52 ` Ferruh Yigit
1 sibling, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2016-12-13 11:52 UTC (permalink / raw)
To: Yong Wang, harish.patil; +Cc: dpdk stable, DPDK
On 11/30/2016 12:32 PM, Yong Wang wrote:
> Current code does not close 'fd' on function exit, leaking resources.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
CC: stable@dpdk.org
> ---
> drivers/net/qede/qede_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
> index ab22409..b666e1c 100644
> --- a/drivers/net/qede/qede_main.c
> +++ b/drivers/net/qede/qede_main.c
> @@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
>
> if (fstat(fd, &st) < 0) {
> DP_NOTICE(edev, false, "Can't stat firmware file\n");
> + close(fd);
> return -1;
> }
>
> @@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
> if (edev->fw_len < 104) {
> DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n",
> edev->fw_len);
> + close(fd);
> return -EINVAL;
> }
>
> + close(fd);
> return 0;
> }
> #endif
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-13 11:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-30 12:32 [dpdk-dev] [PATCH] net/qede: fix resource leak Yong Wang
2016-12-08 16:52 ` Ferruh Yigit
2016-12-12 19:32 ` Harish Patil
2016-12-13 11:51 ` Ferruh Yigit
2016-12-13 11:52 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).